From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0141C43461 for ; Thu, 17 Sep 2020 10:02:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5AB6020838 for ; Thu, 17 Sep 2020 10:02:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726380AbgIQKCm (ORCPT ); Thu, 17 Sep 2020 06:02:42 -0400 Received: from mga09.intel.com ([134.134.136.24]:32026 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726360AbgIQKCl (ORCPT ); Thu, 17 Sep 2020 06:02:41 -0400 X-Greylist: delayed 434 seconds by postgrey-1.27 at vger.kernel.org; Thu, 17 Sep 2020 06:02:41 EDT IronPort-SDR: B+xH0zFmjQIIhZFtByEb1uFS4KP+tIhp/hdDsPEYoPils0TxuAu9obgiFv6DkNRPHceuPAEYMA xNs0//Q/78QQ== X-IronPort-AV: E=McAfee;i="6000,8403,9746"; a="160590741" X-IronPort-AV: E=Sophos;i="5.76,436,1592895600"; d="scan'208";a="160590741" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Sep 2020 02:55:20 -0700 IronPort-SDR: 6AWgY6k2jSM6QsujXaNtiiUDS/Fn+dL8VWCglFvIAk26Fo4St2OUfqS3ZchJAQuNrr212bTyNP sdO6q+0OmcHw== X-IronPort-AV: E=Sophos;i="5.76,436,1592895600"; d="scan'208";a="452231616" Received: from lahna.fi.intel.com (HELO lahna) ([10.237.72.163]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Sep 2020 02:55:16 -0700 Received: by lahna (sSMTP sendmail emulation); Thu, 17 Sep 2020 12:55:14 +0300 Date: Thu, 17 Sep 2020 12:55:14 +0300 From: Mika Westerberg To: Bartosz Golaszewski Cc: Linus Walleij , Andy Shevchenko , Kent Gibson , Anders Roxell , linux-gpio@vger.kernel.org, linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski Subject: Re: [PATCH next v2] gpiolib: check for parent device in devprop_gpiochip_set_names() Message-ID: <20200917095514.GO2495@lahna.fi.intel.com> References: <20200917074857.6716-1-brgl@bgdev.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200917074857.6716-1-brgl@bgdev.pl> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org On Thu, Sep 17, 2020 at 09:48:57AM +0200, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > It's possible for a GPIO chip to not have a parent device (whose > properties we inspect for 'gpio-line-names'). In this case we should > simply return from devprop_gpiochip_set_names(). Add an appropriate > check for this use-case. > > Fixes: 7cba1a4d5e16 ("gpiolib: generalize devprop_gpiochip_set_names() for device properties") > Reported-by: Anders Roxell > Signed-off-by: Bartosz Golaszewski > Reviewed-by: Andy Shevchenko > Tested-by: Anders Roxell FWIW, Reviewed-by: Mika Westerberg