From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C585CC2D0A8 for ; Mon, 28 Sep 2020 09:47:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7C260221EC for ; Mon, 28 Sep 2020 09:47:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="QSvKozpy" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726655AbgI1JrM (ORCPT ); Mon, 28 Sep 2020 05:47:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52788 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726559AbgI1JrL (ORCPT ); Mon, 28 Sep 2020 05:47:11 -0400 Received: from mail-pg1-x543.google.com (mail-pg1-x543.google.com [IPv6:2607:f8b0:4864:20::543]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A5E8BC061755 for ; Mon, 28 Sep 2020 02:47:11 -0700 (PDT) Received: by mail-pg1-x543.google.com with SMTP id 7so370303pgm.11 for ; Mon, 28 Sep 2020 02:47:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=sByFvzANNavXstWIngm0BaCccoxXcpgpgCM5Oz7ddDc=; b=QSvKozpy4dwqhQ3rm2KwqwK/O8nSux1S09jdTfHI1J273nxM5rEIfPP1WJXCY/fPu4 dbrSOz51lPZZSOe4akRbLX74WJlrqNHqGi0lSz6gR5R+512/PBm+n9/QFRDYRBwKeYBZ Nvmm9Rv9GwdsvYRvfKiQvhRdSDnzhPi7OccY7poPFhiTND0z+0H4s2UtyuFwQTeRggLi pJZUSEWKf9j+x4CqBZZ5+Sfi8Rc1QMN4/31RS3j5+mb1V4bh9wCEuXkJfCWE07vpixqZ HsmulRCsj5e5M2pIUO4y0aelzRVfCQor/CBXf6f/P6qQ/Zd/KLlkJhc483NeLJsOiDl1 UVxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=sByFvzANNavXstWIngm0BaCccoxXcpgpgCM5Oz7ddDc=; b=LNSiI0i5hwoz/C7HeaLSkezvUTqYkil05PYwRCDbKl+cQDM4tDw6aUgIXWcVdMCfx4 ql9NOIJHKYg3mSYuNkj1bMYXiAsQ8ODf0/GXhnyVBb21f4l4E+Ke39rt1sbJa7T4B9bK 3StSjdhm0/k8Y7Csbr0Y8q9p6NNi5GqHgzUMlNIeHdTfcWKWZEg5hjN0gfFW1xoK50HG f+RU+Sk+N1n1r05BIpKQNGuCE8crz+b2W3+KYd6OiYNWQN4ydLCEJXF964GZtwNtbSkA 8C7sztH8BcLa55b3tgeTcZ1YI2FI2tAAlf/ztomVOGQryxizlrcun2V9+Hh17hhJ74ML /dUw== X-Gm-Message-State: AOAM533PYFcP2Tbwa1QAQt9syBwIytmyOGGwx4kUHhvQK1dEjLgFwa7p USctTW8+8ElnMJUe/hUZx/g7 X-Google-Smtp-Source: ABdhPJyEqUCMQ5YQbSuGTIK/wFn0PQfjKFE1yYJVltrnkh9bccuAL1DaU3x6A/Y/8EkftfiR7/YNEQ== X-Received: by 2002:a62:6dc3:0:b029:13c:1611:658d with SMTP id i186-20020a626dc30000b029013c1611658dmr9450782pfc.10.1601286431063; Mon, 28 Sep 2020 02:47:11 -0700 (PDT) Received: from linux ([103.59.133.81]) by smtp.gmail.com with ESMTPSA id z7sm761284pgc.35.2020.09.28.02.47.08 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 28 Sep 2020 02:47:10 -0700 (PDT) Date: Mon, 28 Sep 2020 15:17:04 +0530 From: Manivannan Sadhasivam To: Kalle Valo Cc: Stephen Rothwell , David Miller , Networking , Govind Singh , Loic Poulain , Linux Next Mailing List , Linux Kernel Mailing List , ath11k@lists.infradead.org Subject: Re: linux-next: build failure after merge of the mhi tree Message-ID: <20200928094704.GB11515@linux> References: <20200928184230.2d973291@canb.auug.org.au> <20200928091035.GA11515@linux> <87eemmfdn3.fsf@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87eemmfdn3.fsf@codeaurora.org> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org On Mon, Sep 28, 2020 at 12:34:40PM +0300, Kalle Valo wrote: > Manivannan Sadhasivam writes: > > > On Mon, Sep 28, 2020 at 06:42:30PM +1000, Stephen Rothwell wrote: > >> Hi all, > >> > >> After merging the mhi tree, today's linux-next build (x86_64 allmodconfig) > >> failed like this: > >> > >> drivers/net/wireless/ath/ath11k/mhi.c:27:4: error: 'struct > >> mhi_channel_config' has no member named 'auto_start' > >> 27 | .auto_start = false, > >> | ^~~~~~~~~~ > >> drivers/net/wireless/ath/ath11k/mhi.c:42:4: error: 'struct > >> mhi_channel_config' has no member named 'auto_start' > >> 42 | .auto_start = false, > >> | ^~~~~~~~~~ > >> drivers/net/wireless/ath/ath11k/mhi.c:57:4: error: 'struct > >> mhi_channel_config' has no member named 'auto_start' > >> 57 | .auto_start = true, > >> | ^~~~~~~~~~ > >> drivers/net/wireless/ath/ath11k/mhi.c:72:4: error: 'struct > >> mhi_channel_config' has no member named 'auto_start' > >> 72 | .auto_start = true, > >> | ^~~~~~~~~~ > >> > >> Caused by commit > >> > >> ed39d7816885 ("bus: mhi: Remove auto-start option") > >> > >> interacting with commit > >> > >> 1399fb87ea3e ("ath11k: register MHI controller device for QCA6390") > >> > >> from the net-next tree. > >> > >> I applied the following merge fix patch, but maybe more is required. > >> Even if so, this could be fixed now in the net-next tree. > >> > >> From: Stephen Rothwell > >> Date: Mon, 28 Sep 2020 18:39:41 +1000 > >> Subject: [PATCH] fix up for "ath11k: register MHI controller device for QCA6390" > >> > >> Signed-off-by: Stephen Rothwell > > > > Sorry, I forgot to submit a patch against net-next for fixing this while merging > > the MHI change. > > Try to notify the ath11k list (CCed) whenever changing MHI API so that > we (ath11k folks) can be prepared for any major changes. > Okay sure, will do! > > But your change looks good and I can just modify the subject/description and > > resubmit. Or if Dave prefers to fix the original commit itself in net-next, > > I'm fine! > > Actually I prefer to apply the fix to my ath.git tree, less conflicts > that way (I have still quite a lot of ath11k patches pending for -next). > I'll then send a pull request to Dave end of this week. > > So please submit the patch like a normal ath11k patch documented here: > Okay. Thanks, Mani > https://wireless.wiki.kernel.org/en/users/drivers/ath11k/submittingpatches > > -- > https://patchwork.kernel.org/project/linux-wireless/list/ > > https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches