From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 366A1C4741F for ; Mon, 28 Sep 2020 20:09:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CB3BB21924 for ; Mon, 28 Sep 2020 20:09:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="At/lupLa" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726409AbgI1UJi (ORCPT ); Mon, 28 Sep 2020 16:09:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36188 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726389AbgI1UJi (ORCPT ); Mon, 28 Sep 2020 16:09:38 -0400 Received: from mail-pg1-x543.google.com (mail-pg1-x543.google.com [IPv6:2607:f8b0:4864:20::543]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4BEB2C061755 for ; Mon, 28 Sep 2020 13:09:38 -0700 (PDT) Received: by mail-pg1-x543.google.com with SMTP id u24so1866318pgi.1 for ; Mon, 28 Sep 2020 13:09:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=S99N8rvF/t2so08QhL6pclkzbq8/CXYQ8U2vW/BH+ec=; b=At/lupLafCk7dwPh75O9pTw9C98MC2piMlqqdXjCzrWBQEXwERGK3FCRzSXAetk9zy wZhTjK+f3R0DZzkscP2AJNyOVoNpsfj0X+47zeF7OmSmo6FJKe1aSrrNF9LeOUO0Yt6M FhtmIbkzd0YQyxlBLICX1+SPytq0egZ0FJQn8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=S99N8rvF/t2so08QhL6pclkzbq8/CXYQ8U2vW/BH+ec=; b=Qxftf7FpXd+RueQvvZYPkoX+3R5ohwcA+XTqmxRpRfKhOvmLgl5Payc/nO1/LKWHF1 5Fk/Rsb9YaFbQN+AIB9Rv7sNQpoAqznhRZMjG1SsA3iOGchPJBjlPpJ5gnash+HWk/6S naIjNfcE1pK9jFN/sES8xj+F1VuICIXg9N6xlmcIGUc3xjuy+gG56GTCm1VVzdIZm7Px 7Bi2E/uDDgrAjNlNs4ViVPuPzhyzwWqfeKxQPXi1whIAn71gnexc+j7QChqwiGh2joLL 3NiiSk+kVx5ij2SoJbLRa3lVpwfQrgmmTRDnKN/9p2/gzJyJNNzPznkWOaa4Sg68ZJ35 1g+A== X-Gm-Message-State: AOAM530Hf0S/CVgDwC1ajGtZiWz6Ht6JVWisObeZpy0x0ONGp+fqf3Pm d/lRQGqQxWHA/Qv8KpXzCYKlRg== X-Google-Smtp-Source: ABdhPJxweUo6JrIl7VJ75Z4XsJc91vU6Ojb4p0GxGm9M1MwgskGNvzWJmdsuLPOU9Iac8TJrkoyTMA== X-Received: by 2002:a63:165c:: with SMTP id 28mr527069pgw.302.1601323777776; Mon, 28 Sep 2020 13:09:37 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id l14sm2165383pfc.170.2020.09.28.13.09.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Sep 2020 13:09:36 -0700 (PDT) Date: Mon, 28 Sep 2020 13:09:36 -0700 From: Kees Cook To: Hangbin Liu Cc: Shuah Khan , Naresh Kamboju , Jonathan Corbet , linux-doc@vger.kernel.org, Tim.Bird@sony.com, lkft-triage@lists.linaro.org, Anders Roxell , Justin Cook , Linux-Next Mailing List , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH 2/2] selftests/run_kselftest.sh: Make each test individually selectable Message-ID: <202009281306.CF94D1786@keescook> References: <20200925234527.1885234-1-keescook@chromium.org> <20200925234527.1885234-3-keescook@chromium.org> <20200927024840.GD2531@dhcp-12-153.nay.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200927024840.GD2531@dhcp-12-153.nay.redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org On Sun, Sep 27, 2020 at 10:48:40AM +0800, Hangbin Liu wrote: > On Fri, Sep 25, 2020 at 04:45:27PM -0700, Kees Cook wrote: > > Currently with run_kselftest.sh there is no way to choose which test > > we could run. All the tests listed in kselftest-list.txt are all run > > every time. This patch enhanced the run_kselftest.sh to make the test > > collections (or tests) individually selectable. e.g.: > > > > $ ./run_kselftest.sh -c seccomp -t timers:posix_timers -t timers:nanosleep > > > > Additionally adds a way to list all known tests with "-l", usage > > with "-h", and perform a dry run without running tests with "-n". > > This is better than my previous patch and we can modify run_kselftest.sh > easily. The Documentation/dev-tools/kselftest.rst should also be update. Thanks! I will send a v2. -- Kees Cook