From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A1FEC2D0A8 for ; Mon, 28 Sep 2020 17:04:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2BB0F2075A for ; Mon, 28 Sep 2020 17:04:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="qPZI9WAi" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726615AbgI1REV (ORCPT ); Mon, 28 Sep 2020 13:04:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35818 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726610AbgI1REQ (ORCPT ); Mon, 28 Sep 2020 13:04:16 -0400 Received: from mail-pf1-x443.google.com (mail-pf1-x443.google.com [IPv6:2607:f8b0:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CD853C0613CF for ; Mon, 28 Sep 2020 10:04:14 -0700 (PDT) Received: by mail-pf1-x443.google.com with SMTP id z19so1592145pfn.8 for ; Mon, 28 Sep 2020 10:04:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=zkAI/vKjtDEmKWN3VOw6cB9mPuv7jx0kBhXMQShGYaM=; b=qPZI9WAiVxtGA9QX4DXo94Y2FpDLQNsvDZ5wmdONMdINxVtpK4134lxn2iIYc9pFeZ EA9EldbM+JOnHHa1SUSWqlDOqNEgQboWDZYtUsVnmlM2ccReVu07QelvwQVFvMiGQxu6 xdzgITFsbhZVbyAbRq3U3i7n15SDmTBk8rHKD8KbvYesNB7Jydxh99npwvBazBzeVUU5 ERxCYVtOmd5KvhZJnVNgrvkTdJ6OE0QhoeaReEgVpScppVZfTfIj3FzGtej6YCvobQWS zgQJSoq1LyxRelh4HtE1bW+3o+SrzK8VA6IJm494fQpTrUJ1FaFJ30A2VpBLW1GdiRhu wCtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=zkAI/vKjtDEmKWN3VOw6cB9mPuv7jx0kBhXMQShGYaM=; b=Hh2zC+AHv5esRn2cHqjvbGadaytpOGwymo+N51pOIi8ovBQ1DBzbCQ2EEmIcbU/Es6 QnOhEK2AW8HVCWNQ/yf34DTXzYPaIMZZ/GX1c2hDwrqtoPyruOKuL1FyevhEAdDRv3bG MMgQ/5iw8dkoGOXsoTh27VRWjaUXU20agyo8WgsOzHV9FjQuyLxQSlBlKBk5IjgHmmVI NupO5YYWjzubBDGN+ZkPYExr5hvQPr3W+NobheMcckl9Z1RfJ3U3S4eY2ZIlBV2RpDet QC1ixnM4SvYX4BtBug1JmmVFNrPfAaalpdW8U4Yl7WDNNneYg6XXKRtuNNIN4G56YQDq 6bPQ== X-Gm-Message-State: AOAM532D1sgFKRZshWJ4P3k3Dw84Hu+fkww+bqJ9jgdfo0FGR46cZh1p hXwny84HLHH9xIb9uEPg4sR0 X-Google-Smtp-Source: ABdhPJwFbRwfEmfdI+ONZ4Q5Kad/Bhijk0P43s8UGk5JZFnswgqYNDQOg1G3IgPshT+GrCV6OqCjqQ== X-Received: by 2002:a62:242:0:b029:14f:8e68:e7c6 with SMTP id 63-20020a6202420000b029014f8e68e7c6mr352246pfc.54.1601312654047; Mon, 28 Sep 2020 10:04:14 -0700 (PDT) Received: from Mani-XPS-13-9360 ([103.59.133.81]) by smtp.gmail.com with ESMTPSA id n3sm2007275pgf.11.2020.09.28.10.04.09 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 28 Sep 2020 10:04:12 -0700 (PDT) Date: Mon, 28 Sep 2020 22:34:04 +0530 From: Manivannan Sadhasivam To: Kalle Valo Cc: Stephen Rothwell , Loic Poulain , Networking , Linux Kernel Mailing List , ath11k@lists.infradead.org, Linux Next Mailing List , Govind Singh , David Miller Subject: Re: linux-next: build failure after merge of the mhi tree Message-ID: <20200928170403.GA2222@Mani-XPS-13-9360> References: <20200928184230.2d973291@canb.auug.org.au> <20200928091035.GA11515@linux> <87eemmfdn3.fsf@codeaurora.org> <20200928094704.GB11515@linux> <87a6x9g89a.fsf@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87a6x9g89a.fsf@codeaurora.org> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org On Mon, Sep 28, 2020 at 07:45:37PM +0300, Kalle Valo wrote: > Manivannan Sadhasivam writes: > > > On Mon, Sep 28, 2020 at 12:34:40PM +0300, Kalle Valo wrote: > >> Manivannan Sadhasivam writes: > >> > >> > On Mon, Sep 28, 2020 at 06:42:30PM +1000, Stephen Rothwell wrote: > >> >> Hi all, > >> >> > >> >> After merging the mhi tree, today's linux-next build (x86_64 allmodconfig) > >> >> failed like this: > >> >> > >> >> drivers/net/wireless/ath/ath11k/mhi.c:27:4: error: 'struct > >> >> mhi_channel_config' has no member named 'auto_start' > >> >> 27 | .auto_start = false, > >> >> | ^~~~~~~~~~ > >> >> drivers/net/wireless/ath/ath11k/mhi.c:42:4: error: 'struct > >> >> mhi_channel_config' has no member named 'auto_start' > >> >> 42 | .auto_start = false, > >> >> | ^~~~~~~~~~ > >> >> drivers/net/wireless/ath/ath11k/mhi.c:57:4: error: 'struct > >> >> mhi_channel_config' has no member named 'auto_start' > >> >> 57 | .auto_start = true, > >> >> | ^~~~~~~~~~ > >> >> drivers/net/wireless/ath/ath11k/mhi.c:72:4: error: 'struct > >> >> mhi_channel_config' has no member named 'auto_start' > >> >> 72 | .auto_start = true, > >> >> | ^~~~~~~~~~ > >> >> > >> >> Caused by commit > >> >> > >> >> ed39d7816885 ("bus: mhi: Remove auto-start option") > >> >> > >> >> interacting with commit > >> >> > >> >> 1399fb87ea3e ("ath11k: register MHI controller device for QCA6390") > >> >> > >> >> from the net-next tree. > >> >> > >> >> I applied the following merge fix patch, but maybe more is required. > >> >> Even if so, this could be fixed now in the net-next tree. > >> >> > >> >> From: Stephen Rothwell > >> >> Date: Mon, 28 Sep 2020 18:39:41 +1000 > >> >> Subject: [PATCH] fix up for "ath11k: register MHI controller device for QCA6390" > >> >> > >> >> Signed-off-by: Stephen Rothwell > >> > > >> > Sorry, I forgot to submit a patch against net-next for fixing this while merging > >> > the MHI change. > >> > >> Try to notify the ath11k list (CCed) whenever changing MHI API so that > >> we (ath11k folks) can be prepared for any major changes. > >> > > > > Okay sure, will do! > > Thanks. It's important that ath11k is taken into account while making > changes to MHI, otherwise there can easily be regressions. > I completely agree. Actually I thought about holding that patch till next release and making the ath11k change together but somehow I applied that patch blindly, my bad :( > I was looking at commit ed39d7816885 ("bus: mhi: Remove auto-start > option") and noticed this in the commit log: > > This is really up to the MHI device(channel) driver to manage the state > of its channels. > > So does this mean we have to make changes in ath11k to accomodate this? Nope. The change is needed in the MHI client driver like qrtr which is already taken care: https://lkml.org/lkml/2020/9/28/30 Will make sure to include ath11k list for any future API changes. Thanks, Mani > I haven't tested linux-next yet. > > -- > https://patchwork.kernel.org/project/linux-wireless/list/ > > https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches