Re: linux-next: build warning after merge of the tip tree

Stephen Rothwell
2013-08-30T08:55:57Z

[-- Attachment #1: Type: text/plain, Size: 1119 bytes --]

Hi all,

On Tue, 20 Aug 2013 08:42:09 +0200 Ingo Molnar <mingo@kernel.org> wrote:
>
> * Andi Kleen <andi@firstfloor.org> wrote:
>
> > > > Introduced by commit 9a55fdbe941e ("x86, asmlinkage, paravirt: Add
> > > > __visible/asmlinkage to xen paravirt ops"). The 2 definitions used to be
> > > > identical ... maybe there should be only one.
> > >
> > > Andi, please send a fix for this build warning, against
> > > tip:x86/asmlinkage.
> >
> > I resent the patch. Thanks for the headsup.
>
> I suspect hpa missed it because the patch was opaque and
> non-descriptive: the title talks about a 'warning' that is
> supposedly fixed but the changelog does not explain what
> warning it is and why the change matters.
>
> Please use the customary changelog style we use in the
> kernel:
>
> " Current code does (A), this has a problem when (B).
> We can improve this doing (C), because (D)."
>
> I've seen this pattern of deficient changelogs a dozen
> times in your patches this year alone ...

Ping?

--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]