From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7D1DC433E7 for ; Thu, 15 Oct 2020 21:57:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 61F5F2076E for ; Thu, 15 Oct 2020 21:57:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="NryStx+0" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727893AbgJOV53 (ORCPT ); Thu, 15 Oct 2020 17:57:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41966 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727198AbgJOV53 (ORCPT ); Thu, 15 Oct 2020 17:57:29 -0400 Received: from mail-pg1-x541.google.com (mail-pg1-x541.google.com [IPv6:2607:f8b0:4864:20::541]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2EF8DC0613CF for ; Thu, 15 Oct 2020 14:57:29 -0700 (PDT) Received: by mail-pg1-x541.google.com with SMTP id o7so139890pgv.6 for ; Thu, 15 Oct 2020 14:57:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=+HirN9imkTNenxnF1fARCZ++oG/BPbJh5tZatzn08Pk=; b=NryStx+0D7n93j4bJ+39S+L/RJOrazFnYAsRRDiVE7ats47+CyDN/3kJNv+f9sea/O Z8oyFOqrLTFunDVsds0hgV3+nIDFIcdrfJOjZWTaww0wJnqZppeXwDX6IGcC5sZtBghw CukaZ4IKfMNGzJRKasMyR1cyCQ3ioP0G2omcw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=+HirN9imkTNenxnF1fARCZ++oG/BPbJh5tZatzn08Pk=; b=bwR+tmNUW935dJ0gOJGzlCKsmK42PvPNA9XKVNSTZWJtix2JHpV4Mcp83YGl4mQjV4 7PryAXm/bAC8Ht0cokWwzpNst7l3A9S9LpU0kDe8I0uTT2kpKG1QB0qkRFG4Y9SiH48H vO0wkLyF7WeiBLO60de1tx0SOvrI4IRlSBTndK8B3AzB2jCfOBW9QGtHLEjpu1jJLBBd hZIqZLgBf+utoqYW5pA6x0lEPA402JislIS+ULSAYxaJohd/kjtGYLTo/WHtS/SlhG36 1uNT7H1yq0HSc04vy8Rui+h6Irnyw5TezHE6vUtWVeTfhJ1TnDeUOqAl8hHpmKHylI7E +3mg== X-Gm-Message-State: AOAM531BIO5MkYelji4VHjhqeEGrWbqX5n/88hFZc7kw+l9Ftztjv4QK 8dksLBF8EUfKRHi3Yy2jsGmUSQ== X-Google-Smtp-Source: ABdhPJwAvPB5af0CfJASapqoGe3tufGFbINTyn4eNTbKiWpIy7TpGbula57cC6HG75GjKrqYOt0Dbw== X-Received: by 2002:aa7:9828:0:b029:152:192d:9237 with SMTP id q8-20020aa798280000b0290152192d9237mr624696pfl.80.1602799048599; Thu, 15 Oct 2020 14:57:28 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id bx22sm278682pjb.40.2020.10.15.14.57.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Oct 2020 14:57:27 -0700 (PDT) Date: Thu, 15 Oct 2020 14:57:26 -0700 From: Kees Cook To: Naresh Kamboju Cc: Shuah Khan , Hangbin Liu , Jonathan Corbet , linux-doc@vger.kernel.org, Tim.Bird@sony.com, lkft-triage@lists.linaro.org, Anders Roxell , Justin Cook , Linux-Next Mailing List , open list , "open list:KERNEL SELFTEST FRAMEWORK" Subject: Re: [PATCH v2 2/3] selftests/run_kselftest.sh: Make each test individually selectable Message-ID: <202010151336.3B30332@keescook> References: <20200928202650.2530280-1-keescook@chromium.org> <20200928202650.2530280-3-keescook@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org On Thu, Oct 15, 2020 at 02:57:34PM +0530, Naresh Kamboju wrote: > On Tue, 29 Sep 2020 at 01:56, Kees Cook wrote: > > > > Currently with run_kselftest.sh there is no way to choose which test > > we could run. All the tests listed in kselftest-list.txt are all run > > every time. This patch enhanced the run_kselftest.sh to make the test > > collections (or tests) individually selectable. e.g.: > > > > $ ./run_kselftest.sh -c seccomp -t timers:posix_timers -t timers:nanosleep > > > > Additionally adds a way to list all known tests with "-l", usage > > with "-h", and perform a dry run without running tests with "-n". > > > While testing this patch set on LAVA the skip test functionality is not working. > We may have to revisit test definitions kselftest skip logic > or else > may add one more option to skip a given test on run_kselftest.sh script. > > ref: > https://github.com/Linaro/test-definitions/blob/master/automated/linux/kselftest/kselftest.sh#L196 Yes, LAVA's hack to skip tests needs to be adjusted. Here's what it should probably look like: https://github.com/Linaro/test-definitions/pull/231 -- Kees Cook