linux-next: build warning after merge of the rdma-fixes tree

linux-next: build warning after merge of the rdma-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 368 bytes --]

Hi all,

After merging the rdma-fixes tree, today's linux-next build (htmldocs)
produced this warning:

drivers/infiniband/ulp/srpt/ib_srpt.c:630: warning: Function parameter or member 'port_cnt' not described in 'srpt_unregister_mad_agent'

Introduced by commit

  372a1786283e ("IB/srpt: Fix memory leak in srpt_add_one")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the rdma-fixes tree

[Jason Gunthorpe]

On Thu, Nov 05, 2020 at 08:54:58AM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the rdma-fixes tree, today's linux-next build (htmldocs)
> produced this warning:
> 
> drivers/infiniband/ulp/srpt/ib_srpt.c:630: warning: Function parameter or member 'port_cnt' not described in 'srpt_unregister_mad_agent'
> 
> Introduced by commit
> 
>   372a1786283e ("IB/srpt: Fix memory leak in srpt_add_one")

I patched it, thanks

Jason

From 21fcdeec09ff461b2f9a9ef4fcc3a136249e58a1 Mon Sep 17 00:00:00 2001
From: Jason Gunthorpe <jgg@nvidia.com>
Date: Thu, 5 Nov 2020 11:38:29 -0400
Subject: [PATCH] RDMA/srpt: Fix typo in srpt_unregister_mad_agent docstring

htmldocs fails with:

drivers/infiniband/ulp/srpt/ib_srpt.c:630: warning: Function parameter or member 'port_cnt' not described in 'srpt_unregister_mad_agent'

Fixes: 372a1786283e ("IB/srpt: Fix memory leak in srpt_add_one")
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
---
 drivers/infiniband/ulp/srpt/ib_srpt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/ulp/srpt/ib_srpt.c b/drivers/infiniband/ulp/srpt/ib_srpt.c
index 1b096305de1a45..53a8becac82761 100644
--- a/drivers/infiniband/ulp/srpt/ib_srpt.c
+++ b/drivers/infiniband/ulp/srpt/ib_srpt.c
@@ -622,7 +622,7 @@ static int srpt_refresh_port(struct srpt_port *sport)
 /**
  * srpt_unregister_mad_agent - unregister MAD callback functions
  * @sdev: SRPT HCA pointer.
- * #port_cnt: number of ports with registered MAD
+ * @port_cnt: number of ports with registered MAD
  *
  * Note: It is safe to call this function more than once for the same device.
  */
-- 
2.28.0

 

linux-next: build warning after merge of the rdma-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 412 bytes --]

Hi all,

After merging the rdma-fixes tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

WARNING: modpost: drivers/infiniband/core/ib_core.o: section mismatch in reference: .init_module (section: .init.text) -> .nldev_exit (section: .exit.text)

Introduced by commit

  ad9394a3da33 ("RDMA/core: Fix null-ptr-deref in ib_core_cleanup()")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the rdma-fixes tree

[Jason Gunthorpe]

On Fri, Oct 28, 2022 at 07:19:43AM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the rdma-fixes tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
> 
> WARNING: modpost: drivers/infiniband/core/ib_core.o: section mismatch in reference: .init_module (section: .init.text) -> .nldev_exit (section: .exit.text)
> 
> Introduced by commit
> 
>   ad9394a3da33 ("RDMA/core: Fix null-ptr-deref in ib_core_cleanup()")
> 

Fixed up thanks

Jason