From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C930EC2D0E4 for ; Tue, 24 Nov 2020 09:18:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 699562075A for ; Tue, 24 Nov 2020 09:18:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730944AbgKXJSI (ORCPT ); Tue, 24 Nov 2020 04:18:08 -0500 Received: from verein.lst.de ([213.95.11.211]:53534 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727222AbgKXJSI (ORCPT ); Tue, 24 Nov 2020 04:18:08 -0500 Received: by verein.lst.de (Postfix, from userid 2407) id 7D49167373; Tue, 24 Nov 2020 10:18:04 +0100 (CET) Date: Tue, 24 Nov 2020 10:18:04 +0100 From: Christoph Hellwig To: Stephen Rothwell Cc: Olof Johansson , Arnd Bergmann , ARM , Maxime Ripard , Christoph Hellwig , Linux Kernel Mailing List , Linux Next Mailing List Subject: Re: linux-next: build failure after merge of the arm-soc tree Message-ID: <20201124091804.GA11695@lst.de> References: <20201124093115.0f358046@canb.auug.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201124093115.0f358046@canb.auug.org.au> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org On Tue, Nov 24, 2020 at 09:31:15AM +1100, Stephen Rothwell wrote: > Hi all, > > After merging the arm-soc tree, today's linux-next build (arm > multi_v7_defconfig) failed like this: > > drivers/soc/sunxi/sunxi_mbus.c: In function 'sunxi_mbus_notifier': > drivers/soc/sunxi/sunxi_mbus.c:93:8: error: implicit declaration of function 'dma_direct_set_offset' [-Werror=implicit-function-declaration] > 93 | ret = dma_direct_set_offset(dev, PHYS_OFFSET, 0, SZ_4G); > | ^~~~~~~~~~~~~~~~~~~~~ > > Caused by commit > > b4bdc4fbf8d0 ("soc: sunxi: Deal with the MBUS DMA offsets in a central place") > > probably interacting with commit > > 16fee29b0735 ("dma-mapping: remove the dma_direct_set_offset export") > > which is also in the arm-soc tree ... drivers/soc/sunxi/sunxi_mbus.c now needs an include of .