From: Vinod Koul <vkoul@kernel.org>
To: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Cc: kishon@ti.com, sfr@canb.auug.org.au,
linux-kernel@vger.kernel.org, linux-next@vger.kernel.org
Subject: Re: [PATCH 1/3] phy: ralink: phy-mt7621-pci: add include search path in Makefile
Date: Tue, 1 Dec 2020 16:12:46 +0530 [thread overview]
Message-ID: <20201201104246.GA8403@vkoul-mobl> (raw)
In-Reply-To: <20201201101612.28458-2-sergio.paracuellos@gmail.com>
On 01-12-20, 11:16, Sergio Paracuellos wrote:
> This driver includes the following two files directly:
> - mt7621.h
> - ralink_regs.h
>
> Compilation for its related platform properly works because
> its real path is included in 'arch/mips/ralink/Platform' as
> cflags.
>
> This driver depends on RALINK but also is enabled for COMPILE_TEST
> where nothing about its platform is known and this directly
> included files are not found at all breaking compilation.
>
> Fix this problem adding include search path for ralink in
> ralink phy directory Makefile.
>
> Fixes: d87da32372a0 ("phy: ralink: Add PHY driver for MT7621 PCIe PHY")
Pls add reported-by sfr..
> Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
> ---
> drivers/phy/ralink/Makefile | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/phy/ralink/Makefile b/drivers/phy/ralink/Makefile
> index cda2a4a7ca5e..c8f9adba0d82 100644
> --- a/drivers/phy/ralink/Makefile
> +++ b/drivers/phy/ralink/Makefile
> @@ -1,3 +1,6 @@
> # SPDX-License-Identifier: GPL-2.0-only
> +
> +ccflags-y += -I$(srctree)/arch/mips/include/asm/mach-ralink
Can we include <asm/mips/...> instead of using this?
> +
> obj-$(CONFIG_PHY_MT7621_PCI) += phy-mt7621-pci.o
> obj-$(CONFIG_PHY_RALINK_USB) += phy-ralink-usb.o
> --
> 2.25.1
--
~Vinod
next prev parent reply other threads:[~2020-12-01 10:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-01 10:16 [PATCH 0/3] phy: ralink: phy-mt7621-pci: some fixes for COMPILE_TEST Sergio Paracuellos
2020-12-01 10:16 ` [PATCH 1/3] phy: ralink: phy-mt7621-pci: add include search path in Makefile Sergio Paracuellos
2020-12-01 10:42 ` Vinod Koul [this message]
2020-12-01 10:47 ` Sergio Paracuellos
2020-12-01 11:02 ` Vinod Koul
2020-12-01 11:04 ` Sergio Paracuellos
2020-12-01 10:16 ` [PATCH 2/3] phy: ralink: phy-mt7621-pci: avoid warning if COMPILE_TEST is enabled Sergio Paracuellos
2020-12-01 10:16 ` [PATCH 3/3] phy: ralink: phy-mt7621-pci: set correct name in MODULE_DEVICE_TABLE macro Sergio Paracuellos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201201104246.GA8403@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sergio.paracuellos@gmail.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox