From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4042C64E7B for ; Tue, 1 Dec 2020 10:43:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 32A662076C for ; Tue, 1 Dec 2020 10:43:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="O+1ofRAR" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725920AbgLAKnc (ORCPT ); Tue, 1 Dec 2020 05:43:32 -0500 Received: from mail.kernel.org ([198.145.29.99]:41928 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725899AbgLAKnc (ORCPT ); Tue, 1 Dec 2020 05:43:32 -0500 Received: from localhost (unknown [122.171.214.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 535A720809; Tue, 1 Dec 2020 10:42:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1606819371; bh=Zz2nhRfdKwkp/9D1FoCKHCB7GyTWLmDJ7RBVZaYIkpw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=O+1ofRARdpI/DXvQBQvKDREzQxITarBbaFCahcKVQYzr9NvFLJyr/pdMl6o8BYM68 HvwI4SMPaOT406eQLC01vsJyThKDXgUgbNNfgX9xrdV0SRGKBStZfuRm6BClsf6ZpD vnChpTsG/cAjVfLHHYuMN0+s47hmnJky2NWrnyqQ= Date: Tue, 1 Dec 2020 16:12:46 +0530 From: Vinod Koul To: Sergio Paracuellos Cc: kishon@ti.com, sfr@canb.auug.org.au, linux-kernel@vger.kernel.org, linux-next@vger.kernel.org Subject: Re: [PATCH 1/3] phy: ralink: phy-mt7621-pci: add include search path in Makefile Message-ID: <20201201104246.GA8403@vkoul-mobl> References: <20201201101612.28458-1-sergio.paracuellos@gmail.com> <20201201101612.28458-2-sergio.paracuellos@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201201101612.28458-2-sergio.paracuellos@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org On 01-12-20, 11:16, Sergio Paracuellos wrote: > This driver includes the following two files directly: > - mt7621.h > - ralink_regs.h > > Compilation for its related platform properly works because > its real path is included in 'arch/mips/ralink/Platform' as > cflags. > > This driver depends on RALINK but also is enabled for COMPILE_TEST > where nothing about its platform is known and this directly > included files are not found at all breaking compilation. > > Fix this problem adding include search path for ralink in > ralink phy directory Makefile. > > Fixes: d87da32372a0 ("phy: ralink: Add PHY driver for MT7621 PCIe PHY") Pls add reported-by sfr.. > Signed-off-by: Sergio Paracuellos > --- > drivers/phy/ralink/Makefile | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/phy/ralink/Makefile b/drivers/phy/ralink/Makefile > index cda2a4a7ca5e..c8f9adba0d82 100644 > --- a/drivers/phy/ralink/Makefile > +++ b/drivers/phy/ralink/Makefile > @@ -1,3 +1,6 @@ > # SPDX-License-Identifier: GPL-2.0-only > + > +ccflags-y += -I$(srctree)/arch/mips/include/asm/mach-ralink Can we include instead of using this? > + > obj-$(CONFIG_PHY_MT7621_PCI) += phy-mt7621-pci.o > obj-$(CONFIG_PHY_RALINK_USB) += phy-ralink-usb.o > -- > 2.25.1 -- ~Vinod