From: Steven Rostedt <rostedt@goodmis.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Jassi Brar <jaswinder.singh@linaro.org>,
Sami Tolvanen <samitolvanen@google.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: linux-next: Fixes tag needs some work in the mailbox tree
Date: Tue, 1 Dec 2020 21:43:15 -0500 [thread overview]
Message-ID: <20201201214315.523923a0@oasis.local.home> (raw)
In-Reply-To: <20201202123939.4a9e7549@canb.auug.org.au>
On Wed, 2 Dec 2020 12:39:39 +1100
Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi all,
>
> In commit
>
> 983df5f2699f ("samples/ftrace: Mark my_tramp[12]? global")
>
> Fixes tag
>
> Fixes: 9d907f1ae80b8 ("ftrace/samples: Add a sample module that implements modify_ftrace_direct()")
>
> has these problem(s):
>
> - Subject does not match target commit subject
>
> Maybe you meant
>
> Fixes: 9d907f1ae80b ("samples/ftrace: Fix asm function ELF annotations")
>
> or
>
> Fixes: ae0cc3b7e7f5 ("ftrace/samples: Add a sample module that implements modify_ftrace_direct()")
>
Bah! Too late, it already made it into Linus's tree.
I goofed. I was looking at both commits to see which one to apply it
for, and ended up mixing the two.
It was meant for:
Fixes: ae0cc3b7e7f5 ("ftrace/samples: Add a sample module that implements modify_ftrace_direct()")
I'll have to add a script to my tests that makes sure the Fixes tag
matches the description.
-- Steve
next prev parent reply other threads:[~2020-12-02 2:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-02 1:39 linux-next: Fixes tag needs some work in the mailbox tree Stephen Rothwell
2020-12-02 2:43 ` Steven Rostedt [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-10-17 21:11 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201201214315.523923a0@oasis.local.home \
--to=rostedt@goodmis.org \
--cc=jaswinder.singh@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=samitolvanen@google.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).