From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55ADAC64E8A for ; Wed, 2 Dec 2020 02:44:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E3FE8206A1 for ; Wed, 2 Dec 2020 02:44:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727099AbgLBCoA (ORCPT ); Tue, 1 Dec 2020 21:44:00 -0500 Received: from mail.kernel.org ([198.145.29.99]:56640 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726245AbgLBCoA (ORCPT ); Tue, 1 Dec 2020 21:44:00 -0500 Received: from oasis.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8F3C8206A1; Wed, 2 Dec 2020 02:43:18 +0000 (UTC) Date: Tue, 1 Dec 2020 21:43:15 -0500 From: Steven Rostedt To: Stephen Rothwell Cc: Jassi Brar , Sami Tolvanen , Linux Kernel Mailing List , Linux Next Mailing List Subject: Re: linux-next: Fixes tag needs some work in the mailbox tree Message-ID: <20201201214315.523923a0@oasis.local.home> In-Reply-To: <20201202123939.4a9e7549@canb.auug.org.au> References: <20201202123939.4a9e7549@canb.auug.org.au> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org On Wed, 2 Dec 2020 12:39:39 +1100 Stephen Rothwell wrote: > Hi all, > > In commit > > 983df5f2699f ("samples/ftrace: Mark my_tramp[12]? global") > > Fixes tag > > Fixes: 9d907f1ae80b8 ("ftrace/samples: Add a sample module that implements modify_ftrace_direct()") > > has these problem(s): > > - Subject does not match target commit subject > > Maybe you meant > > Fixes: 9d907f1ae80b ("samples/ftrace: Fix asm function ELF annotations") > > or > > Fixes: ae0cc3b7e7f5 ("ftrace/samples: Add a sample module that implements modify_ftrace_direct()") > Bah! Too late, it already made it into Linus's tree. I goofed. I was looking at both commits to see which one to apply it for, and ended up mixing the two. It was meant for: Fixes: ae0cc3b7e7f5 ("ftrace/samples: Add a sample module that implements modify_ftrace_direct()") I'll have to add a script to my tests that makes sure the Fixes tag matches the description. -- Steve