linux-next: Fixes tag needs some work in the nfs tree

linux-next: Fixes tag needs some work in the nfs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 423 bytes --]

Hi all,

In commit

  e8d70b321ecc ("SUNRPC: Fix another issue with MIC buffer space")

Fixes tag

  Fixes: 5f1bc39979d ("SUNRPC: Fix buffer handling of GSS MIC ... ")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the nfs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 414 bytes --]

Hi all,

In commit

  52381893a2be ("NFS: Beware when dereferencing the delegation cred")

Fixes tag

  Fixes: 5f4adff16fa2 ("NFSv4: nfs_update_inplace_delegation() should update delegation cred")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: 57f188e04773 ("NFSv4: nfs_update_inplace_delegation() should update delegation cred")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the nfs tree

[Trond Myklebust]

[-- Attachment #1: Type: text/plain, Size: 607 bytes --]

On Sat, 2020-04-04 at 08:55 +1100, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   52381893a2be ("NFS: Beware when dereferencing the delegation cred")
> 
> Fixes tag
> 
>   Fixes: 5f4adff16fa2 ("NFSv4: nfs_update_inplace_delegation() should
> update delegation cred")
> 
> has these problem(s):
> 
>   - Target SHA1 does not exist
> 
> Maybe you meant
> 
> Fixes: 57f188e04773 ("NFSv4: nfs_update_inplace_delegation() should
> update delegation cred")
> 

Doh! The price of juggling too many kernel branches and backports at
the same time. Thanks Stephen!

Cheers
  Trond

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

linux-next: Fixes tag needs some work in the nfs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 394 bytes --]

Hi all,

In commit

  115677dcbc45 ("SUNRPC: Remove unreachable error condition")

Fixes tag

  Fixes: 7f554890587c ("SUNRPC: Allow addition of new transports to a

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

Please do not split Fixes tags over more than one line.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the nfs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 385 bytes --]

Hi all,

In commit

  1ce8dbb6a593 ("NFSv3: fix rpc receive buffer size for MOUNT call")

Fixes tag

  Fixes: e3d3ab64dd66 ("SUNRPC: Use au_rslack when computing reply buffer size")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: 2c94b8eca1a2 ("SUNRPC: Use au_rslack when computing reply buffer size")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the nfs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 726 bytes --]

Hi all,

In commit

  8c8f8e3106bb ("nfs: nfs_file_write() should check for writeback errors")

Fixes tag

  Fixes: 6fbda89b257f ("NFS: Replace custom error reporting mechanism with

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

In commit

  67dd23f9e6fb ("nfs: ensure correct writeback errors are returned on close()")

Fixes tag

  Fixes: 6fbda89b257f ("NFS: Replace custom error reporting mechanism with

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

Pleas do not split Fixes tags over more than one line.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the nfs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 593 bytes --]

Hi all,

In commit

  526a842bec1d ("sunrpc: fix xs_read_xdr_buf for partial pages receive")

Fixes tag

  Fixes: 277e4ab7d53 ("SUNRPC: Simplify TCP receive code by switching to

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").
  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

Please do not split Fixes tags over more than one line.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the nfs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

Hi all,

In commit

  2cc8aca9d547 ("NFS: Adjust fs_context error logging")

Fixes tag

  Fixes: Fixes: ce8866f0913f ("NFS: Attach supplementary error information to fs_context.")

has these problem(s):

  - No SHA1 recognised

See duplicate "Fixes: " :-(

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the nfs tree

[Trond Myklebust]

Hi Stephen,

On Sun, 2021-01-10 at 13:14 +1100, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   2cc8aca9d547 ("NFS: Adjust fs_context error logging")
> 
> Fixes tag
> 
>   Fixes: Fixes: ce8866f0913f ("NFS: Attach supplementary error
> information to fs_context.")
> 
> has these problem(s):
> 
>   - No SHA1 recognised
> 
> See duplicate "Fixes: " :-(
> 

Sorry, that was my fault. I added the 'Fixes' tag when I applied the
patch. and failed to notice the copy-paste error.
I'll fix up the commit changelog.

-- 
Trond Myklebust
Linux NFS client maintainer, Hammerspace
trond.myklebust@hammerspace.com

linux-next: Fixes tag needs some work in the nfs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 546 bytes --]

Hi all,

In commit

  476bdb04c501 ("NFS: Fix use-after-free in nfs4_init_client()")

Fixes tag

  Fixes: 8dcbec6d20 ("NFSv41: Handle EXCHID4_FLAG_CONFIRMED_R during NFSv4.1 migration")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").
  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the nfs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 560 bytes --]

Hi all,

In commit

  405ab45b5afa ("SUNRPC: ensure the matching upcall is in-flight upon downcall")

Fixes tag

  Fixes: Commit 9130b8dbc6ac ("SUNRPC: allow for upcalls for the same uid

has these problem(s):

  - leading word 'Commit' unexpected
  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes
  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

Please do not split Fixes tags over more than one line.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the nfs tree

[Trond Myklebust]

> On Dec 14, 2022, at 19:54, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> 
> Hi all,
> 
> In commit
> 
>  405ab45b5afa ("SUNRPC: ensure the matching upcall is in-flight upon downcall")
> 
> Fixes tag
> 
>  Fixes: Commit 9130b8dbc6ac ("SUNRPC: allow for upcalls for the same uid
> 
> has these problem(s):
> 
>  - leading word 'Commit' unexpected
>  - Subject has leading but no trailing parentheses
>  - Subject has leading but no trailing quotes
>  - Subject does not match target commit subject
>    Just use
> git log -1 --format='Fixes: %h ("%s")'
> 
> Please do not split Fixes tags over more than one line.
> 
> -- 
> Cheers,
> Stephen Rothwell

Thanks Stephen! Sorry about missing that.
I’ve fixed up the offending line and pushed out a new linux-next branch.

_________________________________
Trond Myklebust
Linux NFS client maintainer, Hammerspace
trond.myklebust@hammerspace.com

linux-next: Fixes tag needs some work in the nfs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 427 bytes --]

Hi all,

In commit

  7b676e697cdc ("NFS: Fix nfs_netfs_issue_read() xarray locking for writeback interrupt")

Fixes tag

  Fixes: 000dbe0bec05 ("NFS: Convert buffered read paths to use netfs when

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

Please do not split Fixes tags over more than one line.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the nfs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 579 bytes --]

Hi all,

In commit

  9f9cfd0ebd6f ("pNFS/flexfiles: don't attempt pnfs on fatal DS errors")

Fixes tag

  Fixes: 260f32adb88 ("pNFS/flexfiles: Check the result of nfs4_pnfs_ds_connect")

has these problem(s):

  - SHA1 should be at least 12 digits long
    This can be fixed for the future by setting core.abbrev to 12 (or
    more) or (for git v2.11 or later) just making sure it is not set
    (or set to "auto").

Also, the Fixes tag line should be at the end of the commit message with
all the other commit message tags.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the nfs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 322 bytes --]

Hi all,

In commit

  dad2fe3c563d ("NFS: drop __exit from nfs_exit_keyring")

Fixes tag

  Fixes: 2c285621176c ("nfs: create a kernel keyring")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: 6a247819238d ("nfs: create a kernel keyring")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the nfs tree

[Trond Myklebust]

On Tue, 2025-07-15 at 07:57 +1000, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   dad2fe3c563d ("NFS: drop __exit from nfs_exit_keyring")
> 
> Fixes tag
> 
>   Fixes: 2c285621176c ("nfs: create a kernel keyring")
> 
> has these problem(s):
> 
>   - Target SHA1 does not exist
> 
> Maybe you meant
> 
> Fixes: 6a247819238d ("nfs: create a kernel keyring")

Thanks! Fixed, and ditto with the other one.

-- 
Trond Myklebust
Linux NFS client maintainer, Hammerspace
trondmy@kernel.org, trond.myklebust@hammerspace.com

linux-next: Fixes tag needs some work in the nfs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 440 bytes --]

Hi all,

In commit

  869b7402a7cb ("nfs/localio: fix regression due to out-of-order __put_cred")

Fixes tag

  Fixes: 86855311c117 ("nfs/localio: add refcounting for each iocb IO associated with NFS pgio header")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: f2060bdc21d7 ("nfs/localio: add refcounting for each iocb IO associated with NFS pgio header")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the nfs tree

[Trond Myklebust]

On Thu, 2025-12-04 at 18:36 +1100, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   869b7402a7cb ("nfs/localio: fix regression due to out-of-order
> __put_cred")
> 
> Fixes tag
> 
>   Fixes: 86855311c117 ("nfs/localio: add refcounting for each iocb IO
> associated with NFS pgio header")
> 
> has these problem(s):
> 
>   - Target SHA1 does not exist
> 
> Maybe you meant
> 
> Fixes: f2060bdc21d7 ("nfs/localio: add refcounting for each iocb IO
> associated with NFS pgio header")

Thanks Stephen! Fixed now...

-- 
Trond Myklebust
Linux NFS client maintainer, Hammerspace
trondmy@kernel.org, trond.myklebust@hammerspace.com