From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Daniel Scally <djrscally@gmail.com>
Cc: Randy Dunlap <rdunlap@infradead.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-media <linux-media@vger.kernel.org>,
Bingbu Cao <bingbu.cao@intel.com>, Yong Zhi <yong.zhi@intel.com>
Subject: Re: [PATCH 1/1] ipu3-cio2: Build bridge only if ACPI is enabled
Date: Wed, 3 Feb 2021 00:02:16 +0200 [thread overview]
Message-ID: <20210202220216.GY32460@paasikivi.fi.intel.com> (raw)
In-Reply-To: <2102444d-8a2b-cae7-9266-903eb14a7c21@gmail.com>
On Tue, Feb 02, 2021 at 09:37:47PM +0000, Daniel Scally wrote:
> On 02/02/2021 20:30, Sakari Ailus wrote:
> > On Tue, Feb 02, 2021 at 12:24:54PM -0800, Randy Dunlap wrote:
> >> On 2/2/21 12:14 PM, Sakari Ailus wrote:
> >>> ipu3-cio2-bridge uses several features of the ACPI framework that have no
> >>> meaningful replacement when ACPI is disabled. Instead of adding #ifdefs to
> >>> the affected places, only build the bridge code if CONFIG_ACPI is enabled.
> >>>
> >>> Fixes: 803abec64ef9 ("media: ipu3-cio2: Add cio2-bridge to ipu3-cio2 driver")
> >>> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> >> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> >> Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
> > Thanks! I'll include this in a pull request to Mauro shortly.
> >
> Ah - thank you both; sorry to have missed that.
No worries; this was missed in review, too. There are just combinations you
don't always end up testing before merging the patches.
--
Regards,
Sakari Ailus
prev parent reply other threads:[~2021-02-02 22:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-02 20:14 [PATCH 1/1] ipu3-cio2: Build bridge only if ACPI is enabled Sakari Ailus
2021-02-02 20:24 ` Randy Dunlap
2021-02-02 20:30 ` Sakari Ailus
2021-02-02 21:37 ` Daniel Scally
2021-02-02 22:02 ` Sakari Ailus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210202220216.GY32460@paasikivi.fi.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=bingbu.cao@intel.com \
--cc=djrscally@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=sfr@canb.auug.org.au \
--cc=yong.zhi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox