From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7ECD8C433DB for ; Wed, 24 Feb 2021 19:57:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 32EAD64F06 for ; Wed, 24 Feb 2021 19:57:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235402AbhBXT44 (ORCPT ); Wed, 24 Feb 2021 14:56:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40412 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235116AbhBXTyu (ORCPT ); Wed, 24 Feb 2021 14:54:50 -0500 Received: from mail-pg1-x533.google.com (mail-pg1-x533.google.com [IPv6:2607:f8b0:4864:20::533]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 518D6C061A2D for ; Wed, 24 Feb 2021 11:52:30 -0800 (PST) Received: by mail-pg1-x533.google.com with SMTP id e6so2193511pgk.5 for ; Wed, 24 Feb 2021 11:52:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=pW2C6NKjGyt6KQ8+k1qyLF2XZOuZgCEPgzOEOX+G/TU=; b=jII3h0LfcraMEzGpz++PaDMsso6tQ948UPu5IeTERMD+dQ9KYfarJLK1Y47zo5gHf/ C9/gwsZG5ztl1s+yJqEpa0utHhZqu0v3wuFHLH3BNlkCjOoRk4QwW4gjiLXUQB/NrgF4 QtI8hF+cuEhE+AGXx3ybbs7l2v0obeI0jV9x4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=pW2C6NKjGyt6KQ8+k1qyLF2XZOuZgCEPgzOEOX+G/TU=; b=fgG7VObWX3bXxdyZRoaB9C5d1sPiyTMDvIrL8uR2yZJvntRt9pAgTO3W5Z3CZg7rAw //QadaZ1beZ3ADjPOys3WRwBd2fTAyaEK+hSgRQqqrynVy8XPvpSlq2h3wtK1LpT0mAS HYnk6BtbOHPKKd+NvB2CIi83MlwhBEpy7sG67O9K9pc+NI+6YqjeKPMdkf+G8QWOww6E tFtn6GH03YKVIjqjQWEYhatTRq5ZV47sOmevqYHL5p9MbLsv6J0wOVBtfC5bv1qilDod hkM3F96Ziit/kMrnSScEINyBEDBPxnK1N+i3jCB5tsYiaPgVduMkTdqW1X6jrSujZk2w Xeqg== X-Gm-Message-State: AOAM532yBXJYMW7V1tcBM4peNREvnZEdRzE1119kEBRkTLMM+3Y6zuRY r8ef/lcH3aic/pVexVXgCCoZJQ== X-Google-Smtp-Source: ABdhPJyn1pvDuBlEZKKlKObpB9wbGJvJ+y8ZK/DYNUycR51QmY333M+rJ9PkRqFvrdw8YRitHAEC0g== X-Received: by 2002:a62:ea08:0:b029:1ec:a029:c04a with SMTP id t8-20020a62ea080000b02901eca029c04amr8908418pfh.40.1614196349914; Wed, 24 Feb 2021 11:52:29 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id v126sm3385435pfv.163.2021.02.24.11.52.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Feb 2021 11:52:29 -0800 (PST) Date: Wed, 24 Feb 2021 11:52:28 -0800 From: Kees Cook To: Stephen Rothwell Cc: Linus Torvalds , Linux Kernel Mailing List , Linux Next Mailing List Subject: Re: linux-next: Signed-off-by missing for commits in Linus' tree Message-ID: <202102241146.97ACF2F@keescook> References: <20210224113108.4c05915e@canb.auug.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210224113108.4c05915e@canb.auug.org.au> Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org On Wed, Feb 24, 2021 at 11:31:08AM +1100, Stephen Rothwell wrote: > Hi all, > > Commits > > b33fff07e3e3 ("x86, build: allow LTO to be selected") > d2dcd3e37475 ("x86, cpu: disable LTO for cpu.c") > e242db40be27 ("x86, vdso: disable LTO only for vDSO") > b1a1a1a09b46 ("kbuild: lto: postpone objtool") > 41425ebe2024 ("objtool: Split noinstr validation from --vmlinux") > 6dafca978033 ("x86, build: use objtool mcount") > 22c8542d7b22 ("tracing: add support for objtool mcount") > 0e731dbc1824 ("objtool: Don't autodetect vmlinux.o") > 18a14575ae31 ("objtool: Fix __mcount_loc generation with Clang's assembler") > 99d0021569c7 ("objtool: Add a pass for generating __mcount_loc") > > are missing a Signed-off-by from their committer. Ieeeee! Ugh, yes, my bad, entirely. I screwed up when rebuilding the LTO "part 2" series for the -rc1 window (missed the -s on the cherry-pick). Since we can't change git history, the best fix I can do is send it here to the list. Obviously, these should all be considered: Signed-off-by: Kees Cook Again, apologies. I, too, will add a commit hook to check for this. (Is there an existing script anyone else is already using?) -- Kees Cook