From: coverity-bot <keescook@chromium.org>
To: Kishon Vijay Abraham I <kishon@ti.com>
Cc: Swapnil Jakhade <sjakhade@cadence.com>,
Vinod Koul <vkoul@kernel.org>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
linux-next@vger.kernel.org
Subject: Coverity: cdns_torrent_derived_refclk_is_enabled(): Error handling issues
Date: Wed, 31 Mar 2021 14:58:33 -0700 [thread overview]
Message-ID: <202103311458.B02B4B13@keescook> (raw)
Hello!
This is an experimental semi-automated report about issues detected by
Coverity from a scan of next-20210331 as part of the linux-next scan project:
https://scan.coverity.com/projects/linux-next-weekly-scan
You're getting this email because you were associated with the identified
lines of code (noted below) that were touched by commits:
None
2cca0228f364 ("phy: cadence-torrent: Add support to drive refclk out")
Coverity reported the following:
*** CID 1503589: Error handling issues (CHECKED_RETURN)
/drivers/phy/cadence/phy-cadence-torrent.c: 1678 in cdns_torrent_derived_refclk_is_enabled()
1672
1673 static int cdns_torrent_derived_refclk_is_enabled(struct clk_hw *hw)
1674 {
1675 struct cdns_torrent_derived_refclk *derived_refclk = to_cdns_torrent_derived_refclk(hw);
1676 int val;
1677
vvv CID 1503589: Error handling issues (CHECKED_RETURN)
vvv Calling "regmap_field_read" without checking return value (as is done elsewhere 101 out of 117 times).
1678 regmap_field_read(derived_refclk->phy_pipe_cmn_ctrl1_0, &val);
1679
1680 return !!val;
1681 }
1682
1683 static const struct clk_ops cdns_torrent_derived_refclk_ops = {
If this is a false positive, please let us know so we can mark it as
such, or teach the Coverity rules to be smarter. If not, please make
sure fixes get into linux-next. :) For patches fixing this, please
include these lines (but double-check the "Fixes" first):
Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
Addresses-Coverity-ID: 1503589 ("Error handling issues")
Fixes: 2cca0228f364 ("phy: cadence-torrent: Add support to drive refclk out")
Thanks for your attention!
--
Coverity-bot
next reply other threads:[~2021-03-31 21:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-31 21:58 coverity-bot [this message]
2021-04-01 20:54 ` Coverity: cdns_torrent_derived_refclk_is_enabled(): Error handling issues Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202103311458.B02B4B13@keescook \
--to=keescook@chromium.org \
--cc=gustavo@embeddedor.com \
--cc=kishon@ti.com \
--cc=linux-next@vger.kernel.org \
--cc=sjakhade@cadence.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox