From: coverity-bot <keescook@chromium.org>
To: Huy Nguyen <huyn@mellanox.com>
Cc: Tariq Toukan <tariqt@mellanox.com>,
Saeed Mahameed <saeedm@mellanox.com>,
Boris Pismenny <borisp@mellanox.com>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
linux-next@vger.kernel.org
Subject: Coverity: rx_ft_put(): Error handling issues
Date: Wed, 31 Mar 2021 14:58:47 -0700 [thread overview]
Message-ID: <202103311458.E693CAAD@keescook> (raw)
Hello!
This is an experimental semi-automated report about issues detected by
Coverity from a scan of next-20210331 as part of the linux-next scan project:
https://scan.coverity.com/projects/linux-next-weekly-scan
You're getting this email because you were associated with the identified
lines of code (noted below) that were touched by commits:
None
5e466345291a ("net/mlx5e: IPsec: Add IPsec steering in local NIC RX")
Coverity reported the following:
*** CID 1503588: Error handling issues (CHECKED_RETURN)
/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec_fs.c: 323 in rx_ft_put()
317 fs_prot = &accel_esp->fs_prot[type];
318 mutex_lock(&fs_prot->prot_mutex);
319 if (--fs_prot->refcnt)
320 goto out;
321
322 /* disconnect */
vvv CID 1503588: Error handling issues (CHECKED_RETURN)
vvv Calling "mlx5e_ttc_fwd_default_dest" without checking return value (as is done elsewhere 4 out of 5 times).
323 mlx5e_ttc_fwd_default_dest(priv, fs_esp2tt(type));
324
325 /* remove FT */
326 rx_destroy(priv, type);
327
328 out:
If this is a false positive, please let us know so we can mark it as
such, or teach the Coverity rules to be smarter. If not, please make
sure fixes get into linux-next. :) For patches fixing this, please
include these lines (but double-check the "Fixes" first):
Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
Addresses-Coverity-ID: 1503588 ("Error handling issues")
Fixes: 5e466345291a ("net/mlx5e: IPsec: Add IPsec steering in local NIC RX")
Thanks for your attention!
--
Coverity-bot
reply other threads:[~2021-03-31 21:59 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202103311458.E693CAAD@keescook \
--to=keescook@chromium.org \
--cc=borisp@mellanox.com \
--cc=gustavo@embeddedor.com \
--cc=huyn@mellanox.com \
--cc=linux-next@vger.kernel.org \
--cc=saeedm@mellanox.com \
--cc=tariqt@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).