From: Kees Cook <keescook@chromium.org>
To: Gao Xiang <hsiangkao@redhat.com>
Cc: Chao Yu <yuchao0@huawei.com>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
linux-next@vger.kernel.org
Subject: Re: Coverity: z_erofs_handle_inplace_io(): Uninitialized variables
Date: Thu, 8 Apr 2021 20:02:55 -0700 [thread overview]
Message-ID: <202104082002.C0761A0FF@keescook> (raw)
In-Reply-To: <20210409010146.GA689534@xiangao.remote.csb>
On Fri, Apr 09, 2021 at 09:01:46AM +0800, Gao Xiang wrote:
> Hi,
>
> On Thu, Apr 08, 2021 at 05:09:14PM -0700, coverity-bot wrote:
> > Hello!
> >
> > This is an experimental semi-automated report about issues detected by
> > Coverity from a scan of next-20210408 as part of the linux-next scan project:
> > https://scan.coverity.com/projects/linux-next-weekly-scan
> >
> > You're getting this email because you were associated with the identified
> > lines of code (noted below) that were touched by commits:
> >
> > Wed Apr 7 13:17:55 2021 +0800
> > c660a3a86e7e ("erofs: support decompress big pcluster for lz4 backend")
> >
> > Coverity reported the following:
> >
> > *** CID 1503704: Uninitialized variables (UNINIT)
> > /fs/erofs/decompressor.c: 160 in z_erofs_handle_inplace_io()
> > 154 }
> > 155 kunmap_atomic(inpage);
> > 156 might_sleep();
> > 157 while (1) {
> > 158 src = vm_map_ram(rq->in, nrpages_in, -1);
> > 159 /* retry two more times (totally 3 times) */
> > vvv CID 1503704: Uninitialized variables (UNINIT)
> > vvv Using uninitialized value "i".
> > 160 if (src || ++i >= 3)
> > 161 break;
> > 162 vm_unmap_aliases();
> > 163 }
> > 164 *maptype = 1;
> > 165 return src;
>
> Thanks for the report!
>
> This bug was reported by Colin King before (next-20210407), and has already
> been fixed in (next-20210408), see:
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/fs/erofs/decompressor.c?h=next-20210408#n157
> and
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/fs/erofs/internal.h?h=next-20210408#n405
Ah-ha, thank you! Colin is fast. :)
--
Kees Cook
prev parent reply other threads:[~2021-04-09 3:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-09 0:09 Coverity: z_erofs_handle_inplace_io(): Uninitialized variables coverity-bot
2021-04-09 1:01 ` Gao Xiang
2021-04-09 3:02 ` Kees Cook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202104082002.C0761A0FF@keescook \
--to=keescook@chromium.org \
--cc=gustavo@embeddedor.com \
--cc=hsiangkao@redhat.com \
--cc=linux-next@vger.kernel.org \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).