From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D9CCC433B4 for ; Fri, 14 May 2021 21:40:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 573476145A for ; Fri, 14 May 2021 21:40:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230309AbhENVli (ORCPT ); Fri, 14 May 2021 17:41:38 -0400 Received: from mail.kernel.org ([198.145.29.99]:59180 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229889AbhENVlh (ORCPT ); Fri, 14 May 2021 17:41:37 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 2942F613C5; Fri, 14 May 2021 21:40:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1621028425; bh=C0ec2lfIbPBQ13yCQGnS5z2cME0lA0z5uIv9YCgayBU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=BFAquXp3lA88Qe0Ju8asJkbRhmzDZKSdYwghLg2G9D+BTRY9z759N2CaiNhqRQMC+ QgMuArxF7WcxRpzSvxYcAPU7TGVk0IAfwv0ayQxwfAsBB3Hz2vzVnKwD52XYPS3EEX cfpyUGuHZVn94x+oXcMO5o/2aDo7e9A6Cd2AxR7Q= Date: Fri, 14 May 2021 14:40:24 -0700 From: Andrew Morton To: Naresh Kamboju Cc: Randy Dunlap , Christophe Leroy , Mark Brown , linux-fsdevel@vger.kernel.org, open list , linux-mm , Linux-Next Mailing List , mhocko@suse.cz, mm-commits@vger.kernel.org, Stephen Rothwell , lkft-triage@lists.linaro.org, Linux ARM Subject: Re: mmotm 2021-05-12-21-46 uploaded (arch/x86/mm/pgtable.c) Message-Id: <20210514144024.ed67212e0577961d7ac2c16e@linux-foundation.org> In-Reply-To: References: <20210513044710.MCXhM_NwC%akpm@linux-foundation.org> <151ddd7f-1d3e-a6f7-daab-e32f785426e1@infradead.org> <54055e72-34b8-d43d-2ad3-87e8c8fa547b@csgroup.eu> <20210513134754.ab3f1a864b0156ef99248401@linux-foundation.org> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org On Fri, 14 May 2021 15:15:41 +0530 Naresh Kamboju wrote: > On Fri, 14 May 2021 at 02:38, Randy Dunlap wrote: > > > > On 5/13/21 1:47 PM, Andrew Morton wrote: > > > On Thu, 13 May 2021 19:09:23 +0200 Christophe Leroy wrote: > > > > > >> > > >> > > >>> on i386: > > >>> > > >>> ../arch/x86/mm/pgtable.c:703:5: error: redefinition of ‘pud_set_huge’ > > >>> int pud_set_huge(pud_t *pud, phys_addr_t addr, pgprot_t prot) > > >>> ^~~~~~~~~~~~ > > >>> In file included from ../include/linux/mm.h:33:0, > > >>> from ../arch/x86/mm/pgtable.c:2: > > >>> ../include/linux/pgtable.h:1387:19: note: previous definition of ‘pud_set_huge’ was here > > >>> static inline int pud_set_huge(pud_t *pud, phys_addr_t addr, pgprot_t prot) > > >>> ^~~~~~~~~~~~ > > >>> ../arch/x86/mm/pgtable.c:758:5: error: redefinition of ‘pud_clear_huge’ > > >>> int pud_clear_huge(pud_t *pud) > > >>> ^~~~~~~~~~~~~~ > > >>> In file included from ../include/linux/mm.h:33:0, > > >>> from ../arch/x86/mm/pgtable.c:2: > > >>> ../include/linux/pgtable.h:1391:19: note: previous definition of ‘pud_clear_huge’ was here > > >>> static inline int pud_clear_huge(pud_t *pud) > > These errors are noticed on linux next 20210514 tag on arm64. > Regressions found on arm64 for the following configs. > > - build/gcc-9-defconfig-904271f2 > - build/gcc-9-tinyconfig > - build/gcc-8-allnoconfig > - build/gcc-10-allnoconfig > - build/clang-11-allnoconfig > - build/clang-10-allnoconfig > - build/clang-12-tinyconfig > - build/gcc-10-tinyconfig > - build/clang-10-tinyconfig > - build/clang-11-tinyconfig > - build/clang-12-allnoconfig > - build/gcc-8-tinyconfig > - build/gcc-9-allnoconfig I can't get arm64 to compile at all ;(. 5.13-rc1 base with gcc-9.3.0, tinyconfig: In file included from ././include/linux/compiler_types.h:65, from : ./include/linux/smp.h:34:26: error: requested alignment '20' is not a positive power of 2 34 | __aligned(sizeof(struct __call_single_data)); | ^~~~~~~~~~~~~~~~~~ ./include/linux/compiler_attributes.h:52:68: note: in definition of macro '__aligned' 52 | #define __aligned(x) __attribute__((__aligned__(x))) | ^ In file included from ./arch/arm64/include/asm/thread_info.h:17, from ./include/linux/thread_info.h:59, from ./arch/arm64/include/asm/preempt.h:5, from ./include/linux/preempt.h:78, from ./include/linux/smp.h:110, from ./include/linux/lockdep.h:14, from ./include/linux/mutex.h:17, from ./include/linux/kernfs.h:12, from ./include/linux/sysfs.h:16, from ./include/linux/kobject.h:20, from ./include/linux/of.h:17, from ./include/linux/irqdomain.h:35, from ./include/linux/acpi.h:13, from ./include/acpi/apei.h:9, from ./include/acpi/ghes.h:5, from ./include/linux/arm_sdei.h:8, from arch/arm64/kernel/asm-offsets.c:10: ./arch/arm64/include/asm/memory.h: In function 'kaslr_offset': ./arch/arm64/include/asm/memory.h:65:33: warning: left shift count >= width of type [-Wshift-count-overflow] 65 | #define _PAGE_END(va) (-(UL(1) << ((va) - 1))) | ^~ ./arch/arm64/include/asm/memory.h:47:31: note: in expansion of macro '_PAGE_END' 47 | #define BPF_JIT_REGION_START (_PAGE_END(VA_BITS_MIN)) | ^~~~~~~~~ ./arch/arm64/include/asm/memory.h:49:29: note: in expansion of macro 'BPF_JIT_REGION_START' 49 | #define BPF_JIT_REGION_END (BPF_JIT_REGION_START + BPF_JIT_REGION_SIZE) | ^~~~~~~~~~~~~~~~~~~~ ./arch/arm64/include/asm/memory.h:51:25: note: in expansion of macro 'BPF_JIT_REGION_END' 51 | #define MODULES_VADDR (BPF_JIT_REGION_END) | ^~~~~~~~~~~~~~~~~~ ./arch/arm64/include/asm/memory.h:50:23: note: in expansion of macro 'MODULES_VADDR' 50 | #define MODULES_END (MODULES_VADDR + MODULES_VSIZE) | ^~~~~~~~~~~~~ ./arch/arm64/include/asm/memory.h:46:24: note: in expansion of macro 'MODULES_END' 46 | #define KIMAGE_VADDR (MODULES_END) | ^~~~~~~~~~~ ./arch/arm64/include/asm/memory.h:196:24: note: in expansion of macro 'KIMAGE_VADDR' 196 | return kimage_vaddr - KIMAGE_VADDR; | ^~~~~~~~~~~~ In file included from ./arch/arm64/include/asm/thread_info.h:17, from ./include/linux/thread_info.h:59, from ./arch/arm64/include/asm/preempt.h:5, from ./include/linux/preempt.h:78, from ./include/linux/smp.h:110, from ./include/linux/lockdep.h:14, from ./include/linux/mutex.h:17, from ./include/linux/kernfs.h:12, from ./include/linux/sysfs.h:16, from ./include/linux/kobject.h:20, from ./include/linux/of.h:17, from ./include/linux/irqdomain.h:35, from ./include/linux/acpi.h:13, from ./include/acpi/apei.h:9, from ./include/acpi/ghes.h:5, from ./include/linux/arm_sdei.h:8, from arch/arm64/kernel/asm-offsets.c:10: and lots of other errors beside that.