From: Kees Cook <keescook@chromium.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Shakeel Butt <shakeelb@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: Coverity: do_migrate_range(): Error handling issues
Date: Tue, 8 Jun 2021 16:12:46 -0700 [thread overview]
Message-ID: <202106081612.0C76BE7B@keescook> (raw)
In-Reply-To: <CAHk-=wihqdYzXc4kd8CZAD2Kaf5Wy_q3Bz7fVsskG=MFBtw69A@mail.gmail.com>
On Tue, Jun 08, 2021 at 12:35:34PM -0700, Linus Torvalds wrote:
> But when I actually grep for it, I see 4 call-sites that don't check
> the return value, and 5 that do. So it's more like 55% of callers that
> do check.
>
> Anyway, this is a false positive. You don't have to check the return
> value. The main example of doing so is the page-out code in
> mm/vmscan.c, and it does so just to keep track of success/fail
> statistics.
Okay, cool; thanks for taking a closer look at it.
--
Kees Cook
prev parent reply other threads:[~2021-06-08 23:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-08 18:05 Coverity: do_migrate_range(): Error handling issues coverity-bot
2021-06-08 19:35 ` Linus Torvalds
2021-06-08 20:21 ` Shakeel Butt
2021-06-08 23:12 ` Kees Cook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202106081612.0C76BE7B@keescook \
--to=keescook@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=gustavo@embeddedor.com \
--cc=hannes@cmpxchg.org \
--cc=linux-next@vger.kernel.org \
--cc=shakeelb@google.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox