Notable build failures in next-20210823

Notable build failures in next-20210823

[Guenter Roeck]

Seen in next-20210823:

Building x86_64:allyesconfig ... failed

drivers/gpu/drm/i915/i915_module.c:50:11: error:
	positional initialization of field in 'struct' declared with 'designated_init' attribute

This only happens with CONFIG_GCC_PLUGIN_RANDSTRUCT=y.

---
Building arm64:defconfig ... failed

drivers/gpu/drm/mediatek/mtk_disp_aal.c: In function 'mtk_aal_config':
drivers/gpu/drm/mediatek/mtk_disp_aal.c:60:47: error: 'priv' undeclared


I don't usually report those, but thought it is worthwhile because the first error
isn't seen with stock gcc on Ubuntu (it doesn't enable gcc plugins), and the second
error was introduced by commit e2b44fa97cb8f ("Merge remote-tracking branch
'drm/drm-next"), suggesting a bad merge resolution (?).

Guenter

Re: Notable build failures in next-20210823

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 946 bytes --]

Hi allr,

On Mon, 23 Aug 2021 08:47:38 -0700 Guenter Roeck <linux@roeck-us.net> wrote:
>
> Seen in next-20210823:
> 
> Building x86_64:allyesconfig ... failed
> 
> drivers/gpu/drm/i915/i915_module.c:50:11: error:
> 	positional initialization of field in 'struct' declared with 'designated_init' attribute
> 
> This only happens with CONFIG_GCC_PLUGIN_RANDSTRUCT=y.

Caused by commit

  a04ea6ae7c67 ("drm/i915: Use a table for i915_init/exit (v2)")

and then moved to this file by

  708b7df3480a ("drm/i915: Extract i915_module.c")

from the drm tree.

CONFIG_GCC_PLUGIN_RANDSTRUCT help says

	  If you say Y here, the layouts of structures that are entirely
          function pointers (and have not been manually annotated with
          __no_randomize_layout), or structures that have been explicitly
          marked with __randomize_layout, will be randomized at compile-time.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: Notable build failures in next-20210823

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 601 bytes --]

Hi Guenter,

On Mon, 23 Aug 2021 08:47:38 -0700 Guenter Roeck <linux@roeck-us.net> wrote:
>
> Seen in next-20210823:
> 
> Building arm64:defconfig ... failed
> 
> drivers/gpu/drm/mediatek/mtk_disp_aal.c: In function 'mtk_aal_config':
> drivers/gpu/drm/mediatek/mtk_disp_aal.c:60:47: error: 'priv' undeclared
> 
> and the second
> error was introduced by commit e2b44fa97cb8f ("Merge remote-tracking branch
> 'drm/drm-next"), suggesting a bad merge resolution (?).

Yeah, bad merge resolution on my part.  Fixed for today.

Thanks for pointing it out.
-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]