linux-next: build warning after merge of the origin tree

linux-next: build warning after merge of the origin tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 626 bytes --]

Hi all,

After merging the origin tree, today's linux-next build (powerpc
allnoconfig) produced this warning:

kernel/sysctl.c:125:12: warning: 'one_thousand' defined but not used [-Wunused-variable]
  125 | static int one_thousand = 1000;
      |            ^~~~~~~~~~~~

Introduced by commit

  39c65a94cd96 ("mm/pagealloc: sysctl: change watermark_scale_factor max limit to 30%")

It seems to only be used when CONFIG_PERF_EVENTS is set.

I didn't see it in linux-next because there is a patch later in the
akpm series (not yet in Linus' tree) that removes this variable.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the origin tree

[Suren Baghdasaryan]

On Sun, Jan 16, 2022 at 4:45 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> After merging the origin tree, today's linux-next build (powerpc
> allnoconfig) produced this warning:
>
> kernel/sysctl.c:125:12: warning: 'one_thousand' defined but not used [-Wunused-variable]
>   125 | static int one_thousand = 1000;
>       |            ^~~~~~~~~~~~
>
> Introduced by commit
>
>   39c65a94cd96 ("mm/pagealloc: sysctl: change watermark_scale_factor max limit to 30%")
>
> It seems to only be used when CONFIG_PERF_EVENTS is set.
>
> I didn't see it in linux-next because there is a patch later in the
> akpm series (not yet in Linus' tree) that removes this variable.

Sorry, I saw the warning before when backporting this patch but I
didn't realize that the followup patches refactoring this code would
not be merged.
Posted a fix at:
https://lore.kernel.org/all/20220117012317.21168-1-surenb@google.com/
Thanks!

>
> --
> Cheers,
> Stephen Rothwell

Re: linux-next: build warning after merge of the origin tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 342 bytes --]

Hi Suren,

On Sun, 16 Jan 2022 17:27:34 -0800 Suren Baghdasaryan <surenb@google.com> wrote:
>
> Sorry, I saw the warning before when backporting this patch but I
> didn't realize that the followup patches refactoring this code would
> not be merged.

Hopefully they will be merged shortly.  Andrew?

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the origin tree

[Andrew Morton]

On Mon, 17 Jan 2022 13:24:34 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> Hi Suren,
> 
> On Sun, 16 Jan 2022 17:27:34 -0800 Suren Baghdasaryan <surenb@google.com> wrote:
> >
> > Sorry, I saw the warning before when backporting this patch but I
> > didn't realize that the followup patches refactoring this code would
> > not be merged.
> 
> Hopefully they will be merged shortly.  Andrew?
> 

Sorry didn't see this on x86_64.
sysctl-move-some-boundary-constants-from-sysctlc-to-sysctl_vals.patch
fixes this.  Shall be sending upstream in a few days.

linux-next: build warning after merge of the origin tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 524 bytes --]

Hi all,

Today's linux-next build (htmldocs) produced this warning:

Documentation/power/video.rst:213: WARNING: Footnote [#] is not referenced. [ref.footnote]

This warning has presumably been there for a long time.

I don't know what causes it - maybe it needs a space before the opening
bracket?

Introduced by commit

  151f4e2bdc7a ("docs: power: convert docs to ReST and rename to *.rst")

from v5.3-rc1

I am just going over left over warnings in he documentation.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the origin tree

[Akira Yokosawa]

[+CC: linux-doc]

Stephen Rothwell wrote:
> Hi all,
> 
> Today's linux-next build (htmldocs) produced this warning:
> 
> Documentation/power/video.rst:213: WARNING: Footnote [#] is not referenced. [ref.footnote]
> 
> This warning has presumably been there for a long time.
> 
> I don't know what causes it - maybe it needs a space before the opening
> bracket?

Stephen, fhve you upgraded your Sphinx recently?

In "Bugs Fixed" section of Sphinx 8.1.0 changelog [1], there is an item which
reads:

    - #12730: The UnreferencedFootnotesDetector transform has been improved
      to more consistently detect unreferenced footnotes. Note, the priority
      of the transform has been changed from 200 to 622, so that it now runs
      after the docutils Footnotes resolution transform. Patch by Chris Sewell.

So the above warning is real and prior versions of Sphinx just can't flag it.

To silence it, you need to get rid of the unreferenced footnote, I guess.

[1]: https://www.sphinx-doc.org/en/master/changes/8.1.html#id3

        HTH, Akira

> 
> Introduced by commit
> 
>   151f4e2bdc7a ("docs: power: convert docs to ReST and rename to *.rst")
> 
> from v5.3-rc1
> 
> I am just going over left over warnings in he documentation.
> 
> -- 
> Cheers,
> Stephen Rothwell

Re: linux-next: build warning after merge of the origin tree

[Bagas Sanjaya]

[-- Attachment #1: Type: text/plain, Size: 1439 bytes --]

On Wed, Jan 22, 2025 at 07:00:43PM +0900, Akira Yokosawa wrote:
> [+CC: linux-doc]
> 
> Stephen Rothwell wrote:
> > Hi all,
> > 
> > Today's linux-next build (htmldocs) produced this warning:
> > 
> > Documentation/power/video.rst:213: WARNING: Footnote [#] is not referenced. [ref.footnote]
> > 
> > This warning has presumably been there for a long time.
> > 
> > I don't know what causes it - maybe it needs a space before the opening
> > bracket?
> 
> Stephen, fhve you upgraded your Sphinx recently?
> 
> In "Bugs Fixed" section of Sphinx 8.1.0 changelog [1], there is an item which
> reads:
> 
>     - #12730: The UnreferencedFootnotesDetector transform has been improved
>       to more consistently detect unreferenced footnotes. Note, the priority
>       of the transform has been changed from 200 to 622, so that it now runs
>       after the docutils Footnotes resolution transform. Patch by Chris Sewell.
> 
> So the above warning is real and prior versions of Sphinx just can't flag it.
> 
> To silence it, you need to get rid of the unreferenced footnote, I guess.

Hi Akira,

I think the culprit [#f3] footnote (that triggers the warning) refers to
Toshiba Satellite P10-554 notebook, where s3_bios and s3_resume work only on
uniprocessor kernel. The proper fix will be probably adding a space before
the footnote.

Thanks.

-- 
An old man doll... just what I always wanted! - Clara

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: linux-next: build warning after merge of the origin tree

[Akira Yokosawa]

Bagas Sanjaya wrote:
> On Wed, Jan 22, 2025 at 07:00:43PM +0900, Akira Yokosawa wrote:
>> [+CC: linux-doc]
>>
>> Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> Today's linux-next build (htmldocs) produced this warning:
>>>
>>> Documentation/power/video.rst:213: WARNING: Footnote [#] is not referenced. [ref.footnote]
>>>
>>> This warning has presumably been there for a long time.
>>>
>>> I don't know what causes it - maybe it needs a space before the opening
>>> bracket?
>>
>> Stephen, fhve you upgraded your Sphinx recently?
>>
>> In "Bugs Fixed" section of Sphinx 8.1.0 changelog [1], there is an item which
>> reads:
>>
>>     - #12730: The UnreferencedFootnotesDetector transform has been improved
>>       to more consistently detect unreferenced footnotes. Note, the priority
>>       of the transform has been changed from 200 to 622, so that it now runs
>>       after the docutils Footnotes resolution transform. Patch by Chris Sewell.
>>
>> So the above warning is real and prior versions of Sphinx just can't flag it.
>>
>> To silence it, you need to get rid of the unreferenced footnote, I guess.
> 
> Hi Akira,
> 
> I think the culprit [#f3] footnote (that triggers the warning) refers to
> Toshiba Satellite P10-554 notebook, where s3_bios and s3_resume work only on
> uniprocessor kernel. The proper fix will be probably adding a space before
> the footnote.
> 

Ahh, you mean the referencing side of the footnote in that table.

Yes, you are right. I was lazy and didn't look closely at that jumbo change.
Point taken!

Thank you.

        Akira

Re: linux-next: build warning after merge of the origin tree

[Bagas Sanjaya]

[-- Attachment #1: Type: text/plain, Size: 1822 bytes --]

On Wed, Jan 22, 2025 at 11:46:46PM +0900, Akira Yokosawa wrote:
> Bagas Sanjaya wrote:
> > On Wed, Jan 22, 2025 at 07:00:43PM +0900, Akira Yokosawa wrote:
> >> [+CC: linux-doc]
> >>
> >> Stephen Rothwell wrote:
> >>> Hi all,
> >>>
> >>> Today's linux-next build (htmldocs) produced this warning:
> >>>
> >>> Documentation/power/video.rst:213: WARNING: Footnote [#] is not referenced. [ref.footnote]
> >>>
> >>> This warning has presumably been there for a long time.
> >>>
> >>> I don't know what causes it - maybe it needs a space before the opening
> >>> bracket?
> >>
> >> Stephen, fhve you upgraded your Sphinx recently?
> >>
> >> In "Bugs Fixed" section of Sphinx 8.1.0 changelog [1], there is an item which
> >> reads:
> >>
> >>     - #12730: The UnreferencedFootnotesDetector transform has been improved
> >>       to more consistently detect unreferenced footnotes. Note, the priority
> >>       of the transform has been changed from 200 to 622, so that it now runs
> >>       after the docutils Footnotes resolution transform. Patch by Chris Sewell.
> >>
> >> So the above warning is real and prior versions of Sphinx just can't flag it.
> >>
> >> To silence it, you need to get rid of the unreferenced footnote, I guess.
> > 
> > Hi Akira,
> > 
> > I think the culprit [#f3] footnote (that triggers the warning) refers to
> > Toshiba Satellite P10-554 notebook, where s3_bios and s3_resume work only on
> > uniprocessor kernel. The proper fix will be probably adding a space before
> > the footnote.
> > 
> 
> Ahh, you mean the referencing side of the footnote in that table.
> 
> Yes, you are right. I was lazy and didn't look closely at that jumbo change.
> Point taken!
> 
> Thank you.

OK, thanks!

-- 
An old man doll... just what I always wanted! - Clara

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: linux-next: build warning after merge of the origin tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 354 bytes --]

Hi Akira,

On Wed, 22 Jan 2025 19:00:43 +0900 Akira Yokosawa <akiyks@gmail.com> wrote:
>
> Stephen, fhve you upgraded your Sphinx recently?

Yes, I did.  So that explains this report, I guess.  I also have some
left over warnings that appeared before I started reporting them (and
while I have taken vacation).

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the origin tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 423 bytes --]

Hi all,

Building Linus' tree, today's linux-next build (htmldocs) produced
this warning:

Documentation/arch/x86/resctrl.rst:577: WARNING: Title underline too short.

Memory bandwidth Allocation specified in MiBps
---------------------------------------------

Introduced by commit

  a8ed59a3a8de ("Documentation/x86: Document that resctrl bandwidth control units are MiB")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the origin tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 364 bytes --]

Hi all,

Building Linus' tree, today's linux-next build (htmldocs) produced
this warning:

include/net/mac80211.h:4200: warning: Function parameter or member 'set_sar_specs' not described in 'ieee80211_ops'

Introduced by commit

  c534e093d865 ("mac80211: add ieee80211_set_sar_specs")

Sorry, I missed this earlier.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the origin tree

[Johannes Berg]

Hi Stephen,

On Thu, 2021-01-07 at 09:05 +1100, Stephen Rothwell wrote:
> Hi all,
> 
> Building Linus' tree, today's linux-next build (htmldocs) produced
> this warning:
> 
> include/net/mac80211.h:4200: warning: Function parameter or member 'set_sar_specs' not described in 'ieee80211_ops'
> 
> Introduced by commit
> 
>   c534e093d865 ("mac80211: add ieee80211_set_sar_specs")
> 
> Sorry, I missed this earlier.

Right, thanks. I believe I also fixed it in the patch I sent a few days
ago that fixed the other documentation warning related to SAR that you
reported.

Thanks,
johannes

Re: linux-next: build warning after merge of the origin tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1004 bytes --]

Hi Johannes,

On Wed, 06 Jan 2021 23:23:42 +0100 Johannes Berg <johannes@sipsolutions.net> wrote:
>
> On Thu, 2021-01-07 at 09:05 +1100, Stephen Rothwell wrote:
> > Hi all,
> > 
> > Building Linus' tree, today's linux-next build (htmldocs) produced
> > this warning:
> > 
> > include/net/mac80211.h:4200: warning: Function parameter or member 'set_sar_specs' not described in 'ieee80211_ops'
> > 
> > Introduced by commit
> > 
> >   c534e093d865 ("mac80211: add ieee80211_set_sar_specs")
> > 
> > Sorry, I missed this earlier.  
> 
> Right, thanks. I believe I also fixed it in the patch I sent a few days
> ago that fixed the other documentation warning related to SAR that you
> reported.

I don't think so :-(  I did a htmldocs build with your patch ([PATCH
v2] cfg80211/mac80211: fix kernel-doc for SAR APIs) on top of Linus'
tree and still got this warning.  That patch did not touch
include/net/mac80211.h ...

Or is there another patch?
-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the origin tree

[Johannes Berg]

Hi Stephen,

> > Right, thanks. I believe I also fixed it in the patch I sent a few days
> > ago that fixed the other documentation warning related to SAR that you
> > reported.
> 
> I don't think so :-(  I did a htmldocs build with your patch ([PATCH
> v2] cfg80211/mac80211: fix kernel-doc for SAR APIs) on top of Linus'
> tree and still got this warning.  That patch did not touch
> include/net/mac80211.h ...

Umm, I don't know what to say. I even added "cfg80211/mac80211" to the
subject, but somehow lost the change to mac80211.h. Sorry about that :(

I'll get a v3 out.

johannes

Re: linux-next: build warning after merge of the origin tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 767 bytes --]

Hi Johannes,

On Wed, 06 Jan 2021 23:46:45 +0100 Johannes Berg <johannes@sipsolutions.net> wrote:
>
> > > Right, thanks. I believe I also fixed it in the patch I sent a few days
> > > ago that fixed the other documentation warning related to SAR that you
> > > reported.  
> > 
> > I don't think so :-(  I did a htmldocs build with your patch ([PATCH
> > v2] cfg80211/mac80211: fix kernel-doc for SAR APIs) on top of Linus'
> > tree and still got this warning.  That patch did not touch
> > include/net/mac80211.h ...  
> 
> Umm, I don't know what to say. I even added "cfg80211/mac80211" to the
> subject, but somehow lost the change to mac80211.h. Sorry about that :(

No worries.

> I'll get a v3 out.

Thanks.
-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the origin tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 459 bytes --]

Hi all,

After merging the origin tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

WARNING: modpost: missing MODULE_LICENSE() in drivers/pinctrl/pinctrl-equilibrium.o
see include/linux/module.h for more information

Introduced by commit

  1948d5c51dba ("pinctrl: Add pinmux & GPIO controller driver for a new SoC")

This commit was not in linux-next before being merged by Linus :-(

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the origin tree

[Linus Walleij]

On Wed, Nov 27, 2019 at 9:59 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> After merging the origin tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> WARNING: modpost: missing MODULE_LICENSE() in drivers/pinctrl/pinctrl-equilibrium.o
> see include/linux/module.h for more information
>
> Introduced by commit
>
>   1948d5c51dba ("pinctrl: Add pinmux & GPIO controller driver for a new SoC")
>
> This commit was not in linux-next before being merged by Linus :-(

Sorry about that, I pushed it to the 0day testers and for some reason
that did not complain about this, then I thought I had also merged it
down for -next ... :/

I'll try to be more careful.

Thanks,
Linus Walleij

linux-next: build warning after merge of the origin tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 912 bytes --]

Hi Dave,

Buildinf Linus' tree, today's linux-next build (powerpc ppc64_defconfig)
produced these warnings:

drivers/net/bonding/bond_main.c: In function 'bond_handle_frame':
drivers/net/bonding/bond_main.c:1463:13: warning: assignment from incompatible pointer type [enabled by default]
drivers/net/bonding/bond_main.c: In function 'bond_open':
drivers/net/bonding/bond_main.c:3441:21: warning: assignment from incompatible pointer type [enabled by default]
drivers/net/bonding/bond_main.c:3448:20: warning: assignment from incompatible pointer type [enabled by default]

Introduced by commit 13a8e0c8cdb4 ("bonding: don't increase rx_dropped
after processing LACPDUs"). recv-probe in struct bonding is a function
returning void, but the local variable it assigned to/from has been
changed to a function returning int ...

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build warning after merge of the origin tree

[David Miller]

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 14 May 2012 10:44:52 +1000

> Introduced by commit 13a8e0c8cdb4 ("bonding: don't increase rx_dropped
> after processing LACPDUs"). recv-probe in struct bonding is a function
> returning void, but the local variable it assigned to/from has been
> changed to a function returning int ...

http://marc.info/?l=linux-netdev&m=133693883404392&w=2