From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72CEAC433EF for ; Tue, 25 Jan 2022 15:39:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244674AbiAYPjS (ORCPT ); Tue, 25 Jan 2022 10:39:18 -0500 Received: from dfw.source.kernel.org ([139.178.84.217]:46462 "EHLO dfw.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1378931AbiAYPgT (ORCPT ); Tue, 25 Jan 2022 10:36:19 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 67268616ED; Tue, 25 Jan 2022 15:36:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 259B7C340E0; Tue, 25 Jan 2022 15:36:09 +0000 (UTC) Date: Tue, 25 Jan 2022 10:36:07 -0500 From: Steven Rostedt To: Stephen Rothwell Cc: Chuck Lever , Linux Kernel Mailing List , Linux Next Mailing List , Anna Schumaker , Trond Myklebust , NFS Mailing List Subject: Re: linux-next: runtime warning in next-20220125 Message-ID: <20220125103607.2dc307e2@gandalf.local.home> In-Reply-To: <20220125100138.0d19c8ca@gandalf.local.home> References: <20220125160505.068dbb52@canb.auug.org.au> <20220125162146.13872bdb@canb.auug.org.au> <20220125100138.0d19c8ca@gandalf.local.home> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org On Tue, 25 Jan 2022 10:01:38 -0500 Steven Rostedt wrote: > On Tue, 25 Jan 2022 16:21:46 +1100 > Stephen Rothwell wrote: > > > Hi all, > > > > On Tue, 25 Jan 2022 16:05:05 +1100 Stephen Rothwell wrote: > > > > > > My qemu boot test of a powerpc pseries_le_defconfig kernel produces the > > > following trace: > > > > > > ------------[ cut here ]------------ > > > WARNING: CPU: 0 PID: 0 at kernel/trace/trace_events.c:417 trace_event_raw_init+0x194/0x730 > > > Modules linked in: > > > CPU: 0 PID: 0 Comm: swapper/0 Not tainted 5.17.0-rc1 #2 > > > NIP: c0000000002bdbb4 LR: c0000000002bdcb0 CTR: c0000000002bdb70 > > > > > > I have no idea what has caused this :-( Maybe commit > > > > > > 5544d5318802 ("SUNRPC: Same as SVC_RQST_ENDPOINT, but without the xid") > > > > Actually, reverting commits > > > > 6ff851d98af8 ("SUNRPC: Improve sockaddr handling in the svc_xprt_create_error trace point") > > 5544d5318802 ("SUNRPC: Same as SVC_RQST_ENDPOINT, but without the xid") > > e2d3613db12a ("SUNRPC: Record endpoint information in trace log") > > > > makes the warning go away. > > > > We added a new way to save items on the ring buffer, but did not update the > safety checks to know about them. I'll fix this shortly. > This should fix it: I'll make it a real patch and start running it through my tests. -- Steve diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c index 3147614c1812..f527ae807e77 100644 --- a/kernel/trace/trace_events.c +++ b/kernel/trace/trace_events.c @@ -384,6 +384,12 @@ static void test_event_printk(struct trace_event_call *call) if (!(dereference_flags & (1ULL << arg))) goto next_arg; + /* Check for __get_sockaddr */; + if (str_has_prefix(fmt + i, "__get_sockaddr(")) { + dereference_flags &= ~(1ULL << arg); + goto next_arg; + } + /* Find the REC-> in the argument */ c = strchr(fmt + i, ','); r = strstr(fmt + i, "REC->");