linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: linux-next: build failure after merge of the mhi tree
Date: Wed, 2 Mar 2022 12:18:44 +0530	[thread overview]
Message-ID: <20220302064844.GF12451@workstation> (raw)
In-Reply-To: <20220302173714.78c9f43c@canb.auug.org.au>

Hi Stephen,

On Wed, Mar 02, 2022 at 05:37:14PM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the mhi tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
> 
> drivers/bus/mhi/ep/main.c: In function 'mhi_ep_register_controller':
> drivers/bus/mhi/ep/main.c:1426:9: error: implicit declaration of function 'irq_set_status_flags' [-Werror=implicit-function-declaration]
>  1426 |         irq_set_status_flags(mhi_cntrl->irq, IRQ_NOAUTOEN);
>       |         ^~~~~~~~~~~~~~~~~~~~
> drivers/bus/mhi/ep/main.c:1426:46: error: 'IRQ_NOAUTOEN' undeclared (first use in this function); did you mean 'IRQF_NO_AUTOEN'?
>  1426 |         irq_set_status_flags(mhi_cntrl->irq, IRQ_NOAUTOEN);
>       |                                              ^~~~~~~~~~~~
>       |                                              IRQF_NO_AUTOEN
> drivers/bus/mhi/ep/main.c:1426:46: note: each undeclared identifier is reported only once for each function it appears in
> 
> Caused by commit
> 
>   6cb3bc57b0c5 ("bus: mhi: ep: Add support for processing MHI endpoint interrupts")
> 
> Presumably a missing include.
> 

Yes, it seems I was missing "#include <linux/irq.h>" for irq APIs. Fixed
now!

But somehow this header got included in ARM cross compilation and I
failed to catch it.

Thanks,
Mani

> I have used the mhi tree from next-20220301 for today.
> 
> -- 
> Cheers,
> Stephen Rothwell



  reply	other threads:[~2022-03-02  6:48 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-02  6:37 linux-next: build failure after merge of the mhi tree Stephen Rothwell
2022-03-02  6:48 ` Manivannan Sadhasivam [this message]
  -- strict thread matches above, loose matches on Subject: below --
2022-11-09  4:16 Stephen Rothwell
2022-11-09  7:42 ` Manivannan Sadhasivam
2021-08-09  9:38 Stephen Rothwell
2021-08-09  9:55 ` Manivannan Sadhasivam
2020-11-17  4:12 Stephen Rothwell
2020-11-17  4:23 ` Manivannan Sadhasivam
2020-11-17  4:28   ` Manivannan Sadhasivam
2020-11-17  9:15     ` Kalle Valo
2020-11-18  4:39   ` Stephen Rothwell
2020-11-18  4:45     ` Stephen Rothwell
2020-11-18  4:51       ` Stephen Rothwell
2020-11-18  5:06         ` Manivannan Sadhasivam
2020-11-18  9:39           ` Manivannan Sadhasivam
2020-11-18 10:41             ` Stephen Rothwell
2020-09-28  8:42 Stephen Rothwell
2020-09-28  9:10 ` Manivannan Sadhasivam
2020-09-28  9:28   ` Stephen Rothwell
2020-09-28  9:34   ` Kalle Valo
2020-09-28  9:47     ` Manivannan Sadhasivam
2020-09-28 16:45       ` Kalle Valo
2020-09-28 17:04         ` Manivannan Sadhasivam
2020-09-29  6:18           ` Kalle Valo
2020-09-29 15:35 ` Manivannan Sadhasivam
2020-08-19  3:48 Stephen Rothwell
2020-08-19  3:49 ` Stephen Rothwell
2020-08-19  4:04 ` Manivannan Sadhasivam
2020-08-19  5:14   ` Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220302064844.GF12451@workstation \
    --to=manivannan.sadhasivam@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).