From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A0C9C433EF for ; Thu, 7 Apr 2022 14:55:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344330AbiDGO5I (ORCPT ); Thu, 7 Apr 2022 10:57:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56106 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344324AbiDGO5H (ORCPT ); Thu, 7 Apr 2022 10:57:07 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A54D61EF5C0; Thu, 7 Apr 2022 07:55:04 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0E22061CBF; Thu, 7 Apr 2022 14:54:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C0F97C385A0; Thu, 7 Apr 2022 14:54:48 +0000 (UTC) Date: Thu, 7 Apr 2022 10:54:46 -0400 From: Steven Rostedt To: Chuck Lever III Cc: Stephen Rothwell , Linux Kernel Mailing List , Linux Next Mailing List Subject: Re: linux-next: runtime warning after merge of the cel-fixes tree Message-ID: <20220407105446.186114c3@gandalf.local.home> In-Reply-To: References: <20220407144524.2a592ed6@canb.auug.org.au> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org On Thu, 7 Apr 2022 13:48:54 +0000 Chuck Lever III wrote: > > event svc_defer_recv has unsafe dereference of argument 1 > > print_fmt: "addr=%pISpc dr=%p xid=0x%08x", (struct sockaddr *)__get_dynamic_array(addr), REC->dr, REC->xid > > event svc_defer_queue has unsafe dereference of argument 1 > > print_fmt: "addr=%pISpc dr=%p xid=0x%08x", (struct sockaddr *)__get_dynamic_array(addr), REC->dr, REC->xid > > event svc_defer_drop has unsafe dereference of argument 1 > > print_fmt: "addr=%pISpc dr=%p xid=0x%08x", (struct sockaddr *)__get_dynamic_array(addr), REC->dr, REC->xid > > NR_IRQS: 512, nr_irqs: 512, preallocated irqs: 16 > > rcu: srcu_init: Setting srcu_struct sizes based on contention. > > > > Introduced by commit > > > > e2e917f8677d ("SUNRPC: Fix the svc_deferred_event trace class") > > > > At least reverting that commit makes the warning go away. > > > > I have left that commit reverted for today. > > Thank you, Stephen. The NFS community has already discussed a > fix for this issue. I'll push it out as soon as I can. Hmm, I know we added code to handle "__get_sockaddr()" but I guess this should also be fine for "__get_dynamic_array()" as well. I could write a patch to cover those too. -- Steve