From: Christoph Hellwig <hch@lst.de>
To: Conor.Dooley@microchip.com
Cc: hch@lst.de, sfr@canb.auug.org.au, linux-next@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org
Subject: Re: linux-next: Tree for May 3
Date: Wed, 11 May 2022 08:48:32 +0200 [thread overview]
Message-ID: <20220511064832.GA761@lst.de> (raw)
In-Reply-To: <102578f2-5c10-e9c2-c1ef-e76ba90d011e@microchip.com>
On Wed, May 11, 2022 at 06:44:22AM +0000, Conor.Dooley@microchip.com wrote:
> On 11/05/2022 07:22, Christoph Hellwig wrote:
> > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> >
> > Can you try this patch?
>
> Hey Christoph, gave it a try but nfortunately, no joy!
Yes, while it is a real fix, the problem it fixes can only happen
with Xen, which is not relevant to riscv. The only other thing I
can think off is that the allocations were always failing on your
board, and the patch makes that failure fatal. For that try the
patch below. I'd also be really curious by now about the kernel
logs from a successful boot.
diff --git a/kernel/dma/swiotlb.c b/kernel/dma/swiotlb.c
index e2ef0864eb1e5..3e992a308c8a1 100644
--- a/kernel/dma/swiotlb.c
+++ b/kernel/dma/swiotlb.c
@@ -254,8 +254,10 @@ void __init swiotlb_init_remap(bool addressing_limit, unsigned int flags,
tlb = memblock_alloc(bytes, PAGE_SIZE);
else
tlb = memblock_alloc_low(bytes, PAGE_SIZE);
- if (!tlb)
- panic("%s: failed to allocate tlb structure\n", __func__);
+ if (!tlb) {
+ pr_warn("%s: failed to allocate tlb structure\n", __func__);
+ return;
+ }
if (remap && remap(tlb, nslabs) < 0) {
memblock_free(tlb, PAGE_ALIGN(bytes));
next prev parent reply other threads:[~2022-05-11 6:48 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-03 7:29 linux-next: Tree for May 3 Stephen Rothwell
2022-05-04 8:32 ` Conor.Dooley
2022-05-09 13:33 ` Conor.Dooley
2022-05-09 14:11 ` Christoph Hellwig
2022-05-09 14:39 ` Conor.Dooley
2022-05-10 11:20 ` Conor.Dooley
2022-05-11 6:22 ` Christoph Hellwig
2022-05-11 6:44 ` Conor.Dooley
2022-05-11 6:48 ` Christoph Hellwig [this message]
2022-05-11 10:10 ` Conor.Dooley
2022-05-11 12:37 ` Christoph Hellwig
2022-05-11 14:08 ` Mike Rapoport
2022-05-11 14:10 ` Christoph Hellwig
2022-05-11 14:37 ` Mike Rapoport
2022-05-11 14:40 ` Christoph Hellwig
2022-05-13 7:55 ` Conor.Dooley
2022-05-14 12:18 ` Geert Uytterhoeven
2022-05-16 9:47 ` Conor.Dooley
-- strict thread matches above, loose matches on Subject: below --
2024-05-03 7:17 Stephen Rothwell
2021-05-03 2:59 Stephen Rothwell
2019-05-03 10:00 Stephen Rothwell
2018-05-03 5:13 Stephen Rothwell
2017-05-03 5:54 Stephen Rothwell
2016-05-03 9:37 Stephen Rothwell
2013-05-03 4:10 Stephen Rothwell
2012-05-03 6:38 Stephen Rothwell
2011-05-03 5:47 Stephen Rothwell
2010-05-03 5:16 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220511064832.GA761@lst.de \
--to=hch@lst.de \
--cc=Conor.Dooley@microchip.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).