public inbox for linux-next@vger.kernel.org
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Dan Williams <dan.j.williams@intel.com>
Cc: Jane Chu <jane.chu@oracle.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: linux-next: build failure after merge of the nvdimm tree
Date: Mon, 16 May 2022 19:10:05 +1000	[thread overview]
Message-ID: <20220516191005.27cee43c@canb.auug.org.au> (raw)

[-- Attachment #1: Type: text/plain, Size: 2353 bytes --]

Hi all,

After merging the nvdimm tree, today's linux-next build (i386 defconfig)
failed like this:

In file included from include/linux/bits.h:6,
                 from include/linux/bitops.h:6,
                 from include/linux/kernel.h:22,
                 from arch/x86/include/asm/percpu.h:27,
                 from arch/x86/include/asm/preempt.h:6,
                 from include/linux/preempt.h:78,
                 from include/linux/spinlock.h:55,
                 from include/linux/wait.h:9,
                 from include/linux/wait_bit.h:8,
                 from include/linux/fs.h:6,
                 from include/linux/highmem.h:5,
                 from arch/x86/mm/pat/set_memory.c:6:
arch/x86/mm/pat/set_memory.c: In function 'set_mce_nospec':
include/vdso/bits.h:7:40: error: left shift count >= width of type [-Werror=shift-count-overflow]
    7 | #define BIT(nr)                 (UL(1) << (nr))
      |                                        ^~
arch/x86/mm/pat/set_memory.c:1941:59: note: in expansion of macro 'BIT'
 1941 |         decoy_addr = (pfn << PAGE_SHIFT) + (PAGE_OFFSET ^ BIT(63));
      |                                                           ^~~

Caused by commit

  39702cf7885c ("x86/mce: relocate set{clear}_mce_nospec() functions")

I applied the following patch for today.

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 16 May 2022 19:00:54 +1000
Subject: [PATCH] fix up for "x86/mce: relocate set{clear}_mce_nospec() functions"

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 arch/x86/mm/pat/set_memory.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/x86/mm/pat/set_memory.c b/arch/x86/mm/pat/set_memory.c
index 59d9efb4257c..9200e619d8b7 100644
--- a/arch/x86/mm/pat/set_memory.c
+++ b/arch/x86/mm/pat/set_memory.c
@@ -1914,6 +1914,7 @@ int set_memory_wb(unsigned long addr, int numpages)
 }
 EXPORT_SYMBOL(set_memory_wb);
 
+#ifdef CONFIG_X86_64
 /* Prevent speculative access to a page by marking it not-present */
 int set_mce_nospec(unsigned long pfn)
 {
@@ -1959,6 +1960,7 @@ int clear_mce_nospec(unsigned long pfn)
 	return set_memory_present(&addr, 1);
 }
 EXPORT_SYMBOL_GPL(clear_mce_nospec);
+#endif
 
 int set_memory_x(unsigned long addr, int numpages)
 {
-- 
2.35.1

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

             reply	other threads:[~2022-05-16  9:10 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-16  9:10 Stephen Rothwell [this message]
2022-05-16 18:05 ` linux-next: build failure after merge of the nvdimm tree Dan Williams
  -- strict thread matches above, loose matches on Subject: below --
2021-08-30  7:09 Stephen Rothwell
2021-08-30  7:10 ` Christoph Hellwig
2021-08-30  7:15   ` Gao Xiang
2019-07-05  7:20 Stephen Rothwell
2019-07-05  8:45 ` Pankaj Gupta
2019-07-05 11:09   ` Stephen Rothwell
2019-07-05 11:14     ` Pankaj Gupta
2019-07-05 22:32 ` Dan Williams
2019-07-05 23:48   ` Stephen Rothwell
2019-06-20  9:29 Stephen Rothwell
2019-06-20 10:30 ` Pankaj Gupta
2018-04-09  3:16 Stephen Rothwell
2018-04-09  3:38 ` Oliver
2018-04-09  7:34   ` Oliver
2018-04-09 17:11     ` Dan Williams
2018-04-09 18:14       ` Dan Williams
2017-11-03  7:19 Stephen Rothwell
2017-11-03 16:04 ` Dan Williams
2017-09-04  7:34 Stephen Rothwell
2017-09-04 18:34 ` Dan Williams
2017-04-24  6:11 Stephen Rothwell
2017-04-24  8:39 ` Al Viro
2017-04-24 23:29   ` Dan Williams
2017-04-25 22:22   ` Dan Williams
2016-07-22  6:13 Stephen Rothwell
2016-07-23  1:04 ` Dan Williams
2016-07-23  3:54   ` Dan Williams
2016-07-21  6:13 Stephen Rothwell
2016-07-21 21:33 ` Dan Williams
2016-03-27  9:50 Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220516191005.27cee43c@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=dan.j.williams@intel.com \
    --cc=jane.chu@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox