From: Steven Rostedt <rostedt@goodmis.org>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Arun Easi <aeasi@marvell.com>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
James Bottomley <jejb@linux.ibm.com>,
<linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-next@vger.kernel.org>,
<GR-QLogic-Storage-Upstream@marvell.com>
Subject: Re: [PATCH v3 1/1] tracing: Fix compile error in trace_array calls when TRACING is disabled
Date: Thu, 22 Sep 2022 17:02:04 -0400 [thread overview]
Message-ID: <20220922170204.08f91a68@gandalf.local.home> (raw)
In-Reply-To: <yq15yho3y0s.fsf@ca-mkp.ca.oracle.com>
On Thu, 15 Sep 2022 21:32:59 -0400
"Martin K. Petersen" <martin.petersen@oracle.com> wrote:
> Steven,
>
> Can you please review Arun's patch?
Sorry, was busy running a conference ;-)
>
> > Fix this compilation error seen when CONFIG_TRACING is not enabled:
> >
> > drivers/scsi/qla2xxx/qla_os.c: In function 'qla_trace_init':
> > drivers/scsi/qla2xxx/qla_os.c:2854:25: error: implicit declaration of function
> > 'trace_array_get_by_name'; did you mean 'trace_array_set_clr_event'?
> > [-Werror=implicit-function-declaration]
> > 2854 | qla_trc_array = trace_array_get_by_name("qla2xxx");
> > | ^~~~~~~~~~~~~~~~~~~~~~~
> > | trace_array_set_clr_event
> >
> > drivers/scsi/qla2xxx/qla_os.c: In function 'qla_trace_uninit':
> > drivers/scsi/qla2xxx/qla_os.c:2869:9: error: implicit declaration of function
> > 'trace_array_put' [-Werror=implicit-function-declaration]
> > 2869 | trace_array_put(qla_trc_array);
> > | ^~~~~~~~~~~~~~~
> >
>
The patch looks good to me.
Reviewed-by: Steven Rostedt (Google) <rostedt@goodmis.org>
-- Steve
next prev parent reply other threads:[~2022-09-22 21:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-07 23:33 [PATCH v3 0/1] Tracing: Compile error with qla2xxx Arun Easi
2022-09-07 23:33 ` [PATCH v3 1/1] tracing: Fix compile error in trace_array calls when TRACING is disabled Arun Easi
2022-09-08 16:55 ` Bart Van Assche
2022-09-08 19:12 ` [EXT] " Arun Easi
2022-09-16 1:32 ` Martin K. Petersen
2022-09-16 21:22 ` [EXT] " Arun Easi
2022-09-22 21:02 ` Steven Rostedt [this message]
2022-09-22 22:34 ` Arun Easi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220922170204.08f91a68@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=GR-QLogic-Storage-Upstream@marvell.com \
--cc=aeasi@marvell.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox