From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A8B3C433FE for ; Wed, 5 Oct 2022 03:14:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229550AbiJEDOH (ORCPT ); Tue, 4 Oct 2022 23:14:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42976 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229518AbiJEDOG (ORCPT ); Tue, 4 Oct 2022 23:14:06 -0400 Received: from 1wt.eu (wtarreau.pck.nerim.net [62.212.114.60]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id C4165696D7; Tue, 4 Oct 2022 20:14:02 -0700 (PDT) Received: (from willy@localhost) by pcw.home.local (8.15.2/8.15.2/Submit) id 2953DaIv003171; Wed, 5 Oct 2022 05:13:36 +0200 Date: Wed, 5 Oct 2022 05:13:36 +0200 From: Willy Tarreau To: "Darrick J. Wong" Cc: Stephen Zhang , Dave Chinner , Stephen Rothwell , linux-xfs@vger.kernel.org, Shida Zhang , Linux Kernel Mailing List , Linux Next Mailing List Subject: Re: linux-next: Signed-off-by missing for commit in the xfs tree Message-ID: <20221005031336.GA3161@1wt.eu> References: <20221004072302.345bfd4a@canb.auug.org.au> <20221003222103.GM3600936@dread.disaster.area> <20221004225012.501e11ed@canb.auug.org.au> <20221004210400.GO3600936@dread.disaster.area> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org On Tue, Oct 04, 2022 at 08:01:26PM -0700, Darrick J. Wong wrote: > I think Dave means something like this patch of mine: > https://lore.kernel.org/linux-xfs/166473478893.1083155.2555785331844801316.stgit@magnolia/T/#u > > From: "Darrick J. Wong" > To: djwong@kernel.org > Cc: linux-xfs@vger.kernel.org > Date: Sun, 02 Oct 2022 11:19:48 -0700 > Subject: [PATCH 3/4] xfs: set the buffer type after holding the AG[IF] across trans_roll > > From: Darrick J. Wong > > Currently, the only way to lock an allocation group is to hold the AGI > and AGF buffers. If repair needs to roll the transaction while > repairing some AG metadata, it maintains that lock by holding the two > buffers across the transaction roll and joins them afterwards. > > However, repair is not the same as the other parts of XFS that employ > this bhold/bjoin sequence, because it's possible that the AGI or AGF > buffers are not actually dirty before the roll. In this case, the > buffer log item can detach from the buffer, which means that we have to > re-set the buffer type in the bli after joining the buffer to the new > transaction so that log recovery will know what to do if the fs fails. > > Signed-off-by: Darrick J. Wong > --- > > Notice how after the Subject: there is a blank line (which terminates > the headers) followed by a new From: line in the body? And the > name/email in that second From: line matches the SOB later on? Or maybe we could have a new option to git-am to always use the first SOB as the From when there's no other explicit From in the message, so that we never care about the From used to send the e-mail ? That would also implicitly perform a requirement that an SOB necessarily exists. Willy