linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* linux-next: Fixes tag needs some work in the iio-fixes tree
@ 2022-10-30 20:40 Stephen Rothwell
  2022-10-31  9:55 ` Jonathan Cameron
  0 siblings, 1 reply; 6+ messages in thread
From: Stephen Rothwell @ 2022-10-30 20:40 UTC (permalink / raw)
  To: Jonathan Cameron
  Cc: Saravanan Sekar, Linux Kernel Mailing List,
	Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 466 bytes --]

Hi all,

In commit

  a589ef35fc62 ("iio: adc: mp2629: fix potential array out of bound access")

Fixes tag

  Fixes: 7abd9fb6468 ("iio: adc: mp2629: Add support for mp2629 ADC driver")

has these problem(s):

  - SHA1 should be at least 12 digits long
    This can be fixed for the future by setting core.abbrev to 12 (or
    more) or (for git v2.11 or later) just making sure it is not set
    (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: linux-next: Fixes tag needs some work in the iio-fixes tree
  2022-10-30 20:40 linux-next: Fixes tag needs some work in the iio-fixes tree Stephen Rothwell
@ 2022-10-31  9:55 ` Jonathan Cameron
  0 siblings, 0 replies; 6+ messages in thread
From: Jonathan Cameron @ 2022-10-31  9:55 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Saravanan Sekar, Linux Kernel Mailing List,
	Linux Next Mailing List

On Mon, 31 Oct 2022 07:40:06 +1100
Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> Hi all,
> 
> In commit
> 
>   a589ef35fc62 ("iio: adc: mp2629: fix potential array out of bound
> access")
> 
> Fixes tag
> 
>   Fixes: 7abd9fb6468 ("iio: adc: mp2629: Add support for mp2629 ADC
> driver")
> 
> has these problem(s):
> 
>   - SHA1 should be at least 12 digits long
>     This can be fixed for the future by setting core.abbrev to 12 (or
>     more) or (for git v2.11 or later) just making sure it is not set
>     (or set to "auto").
> 

Doh, I clearly failed to run my local checks.  Will fix within next day
or so.

Thanks,

Jonathan

^ permalink raw reply	[flat|nested] 6+ messages in thread

* linux-next: Fixes tag needs some work in the iio-fixes tree
@ 2024-04-29 22:26 Stephen Rothwell
  2024-04-30 10:23 ` Jonathan Cameron
  0 siblings, 1 reply; 6+ messages in thread
From: Stephen Rothwell @ 2024-04-29 22:26 UTC (permalink / raw)
  To: Jonathan Cameron
  Cc: Marius Cristea, Linux Kernel Mailing List,
	Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 351 bytes --]

Hi all,

In commit

  40297eee0f39 ("iio: adc: PAC1934: fix accessing out of bounds array index")

Fixes tag

  Fixes: 0fb528c8255b: "iio: adc: adding support for PAC193x"

has these problem(s):

  - The subject is not in the expected format
    Just use
        git log -1 --format='Fixes: %h ("%s")'

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: linux-next: Fixes tag needs some work in the iio-fixes tree
  2024-04-29 22:26 Stephen Rothwell
@ 2024-04-30 10:23 ` Jonathan Cameron
  0 siblings, 0 replies; 6+ messages in thread
From: Jonathan Cameron @ 2024-04-30 10:23 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Marius Cristea, Linux Kernel Mailing List,
	Linux Next Mailing List

On Tue, 30 Apr 2024 08:26:45 +1000
Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> Hi all,
> 
> In commit
> 
>   40297eee0f39 ("iio: adc: PAC1934: fix accessing out of bounds array index")
> 
> Fixes tag
> 
>   Fixes: 0fb528c8255b: "iio: adc: adding support for PAC193x"
> 
> has these problem(s):
> 
>   - The subject is not in the expected format
>     Just use
>         git log -1 --format='Fixes: %h ("%s")'
> 

Thanks. I must have fumbled my local checks to miss this.

Sorry for the noise!

Jonathan

^ permalink raw reply	[flat|nested] 6+ messages in thread

* linux-next: Fixes tag needs some work in the iio-fixes tree
@ 2024-06-02 22:44 Stephen Rothwell
  2024-06-03  8:27 ` Jonathan Cameron
  0 siblings, 1 reply; 6+ messages in thread
From: Stephen Rothwell @ 2024-06-02 22:44 UTC (permalink / raw)
  To: Jonathan Cameron
  Cc: Dumitru Ceclan, Linux Kernel Mailing List,
	Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 409 bytes --]

Hi all,

In commits

  0c9b60531f77 ("iio: adc: ad7173: Fix sampling frequency setting")
  8d0184667b32 ("iio: adc: ad7173: Clear append status bit")

Fixes tag

  Fixes: 8eb903272f75 ("iio: adc: ad7173: add AD7173 driver")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: 76a1e6a42802 ("iio: adc: ad7173: add AD7173 driver")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: linux-next: Fixes tag needs some work in the iio-fixes tree
  2024-06-02 22:44 Stephen Rothwell
@ 2024-06-03  8:27 ` Jonathan Cameron
  0 siblings, 0 replies; 6+ messages in thread
From: Jonathan Cameron @ 2024-06-03  8:27 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Dumitru Ceclan, Linux Kernel Mailing List,
	Linux Next Mailing List, jic23

On Mon, 3 Jun 2024 08:44:48 +1000
Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> Hi all,
> 
> In commits
> 
>   0c9b60531f77 ("iio: adc: ad7173: Fix sampling frequency setting")
>   8d0184667b32 ("iio: adc: ad7173: Clear append status bit")
> 
> Fixes tag
> 
>   Fixes: 8eb903272f75 ("iio: adc: ad7173: add AD7173 driver")
> 
> has these problem(s):
> 
>   - Target SHA1 does not exist
> 
> Maybe you meant
> 
> Fixes: 76a1e6a42802 ("iio: adc: ad7173: add AD7173 driver")
> 
Thanks. I'll fix.  I'm clearly getting sloppy with running a
test on that. :(

Sorry for the noise.

Jonathan


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2024-06-03  8:27 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-30 20:40 linux-next: Fixes tag needs some work in the iio-fixes tree Stephen Rothwell
2022-10-31  9:55 ` Jonathan Cameron
  -- strict thread matches above, loose matches on Subject: below --
2024-04-29 22:26 Stephen Rothwell
2024-04-30 10:23 ` Jonathan Cameron
2024-06-02 22:44 Stephen Rothwell
2024-06-03  8:27 ` Jonathan Cameron

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).