From: coverity-bot <keescook@chromium.org>
To: Benjamin Mugnier <benjamin.mugnier@foss.st.com>
Cc: linux-kernel@vger.kernel.org,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>,
Shawn Tu <shawnx.tu@intel.com>,
linux-media@vger.kernel.org,
Sylvain Petinot <sylvain.petinot@foss.st.com>,
Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
Hans Verkuil <hverkuil@xs4all.nl>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
linux-next@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Coverity: vgxy61_configure(): Control flow issues
Date: Thu, 10 Nov 2022 08:29:49 -0800 [thread overview]
Message-ID: <202211100829.0E15D0E@keescook> (raw)
Hello!
This is an experimental semi-automated report about issues detected by
Coverity from a scan of next-20221110 as part of the linux-next scan project:
https://scan.coverity.com/projects/linux-next-weekly-scan
You're getting this email because you were associated with the identified
lines of code (noted below) that were touched by commits:
Thu Oct 27 14:37:38 2022 +0300
153e4ad44d60 ("media: i2c: Add driver for ST VGXY61 camera sensor")
Coverity reported the following:
*** CID 1527253: Control flow issues (NO_EFFECT)
drivers/media/i2c/st-vgxy61.c:1579 in vgxy61_configure()
1573 /* Frequency to data rate is 1:1 ratio for MIPI */
1574 sensor->data_rate_in_mbps = sensor_freq;
1575 /* Video timing ISP path (pixel clock) requires 804/5 mhz = 160 mhz */
1576 sensor->pclk = sensor_freq / 5;
1577
1578 line_length = vgxy61_read_reg(sensor, VGXY61_REG_LINE_LENGTH);
vvv CID 1527253: Control flow issues (NO_EFFECT)
vvv This less-than-zero comparison of an unsigned value is never true. "line_length < 0".
1579 if (line_length < 0)
1580 return line_length;
1581 sensor->line_length = line_length;
1582 vgxy61_write_reg(sensor, VGXY61_REG_EXT_CLOCK, sensor->clk_freq, &ret);
1583 vgxy61_write_reg(sensor, VGXY61_REG_CLK_PLL_PREDIV, prediv, &ret);
1584 vgxy61_write_reg(sensor, VGXY61_REG_CLK_SYS_PLL_MULT, mult, &ret);
If this is a false positive, please let us know so we can mark it as
such, or teach the Coverity rules to be smarter. If not, please make
sure fixes get into linux-next. :) For patches fixing this, please
include these lines (but double-check the "Fixes" first):
Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
Addresses-Coverity-ID: 1527253 ("Control flow issues")
Fixes: 153e4ad44d60 ("media: i2c: Add driver for ST VGXY61 camera sensor")
Thanks for your attention!
--
Coverity-bot
reply other threads:[~2022-11-10 16:29 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202211100829.0E15D0E@keescook \
--to=keescook@chromium.org \
--cc=benjamin.mugnier@foss.st.com \
--cc=gustavo@embeddedor.com \
--cc=hverkuil@xs4all.nl \
--cc=jeanmichel.hautbois@ideasonboard.com \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=shawnx.tu@intel.com \
--cc=sylvain.petinot@foss.st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox