From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C333C4332F for ; Thu, 17 Nov 2022 22:07:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234714AbiKQWHt (ORCPT ); Thu, 17 Nov 2022 17:07:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43144 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241409AbiKQWHQ (ORCPT ); Thu, 17 Nov 2022 17:07:16 -0500 Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7E8047AF67; Thu, 17 Nov 2022 14:07:04 -0800 (PST) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4NCvCQ0h9qz4x1T; Fri, 18 Nov 2022 09:06:58 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canb.auug.org.au; s=201702; t=1668722819; bh=ubzMaTeqc2N8hOGbp/joqdOXRMohY2fnfb5NRDEwpwU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=LtczShpY+5xR9TzvTUkamSbhgrVOkMH9PDdezEssYPItKv0chL/QXpZEVSVRv7gEC qL0IRFVLh19U2k2fUMGbnlbG59TuTpNKQtn08E+lofuxAHsvL37LA1weNGMTK2IMgd P+sovcBv9hFj94JsqHlfgQ0Y4Gwh/2NllrEBeE0iFIeS4uAveNEoLlSTfcHazO11tL QbAiKPNgj3MaVD7ekp0RVNW9H7yMrxOVrKG8J83LYnpkiWJ3gA1Z+R8x5fwCd5ouKn Rdwxdgw6xfXzB38r5Mpj72/sDgsCWVYLOmnTWYIn5r1ZsxiWltwRdz320vmCidLjc8 LYRsw7qwGjHow== Date: Fri, 18 Nov 2022 09:06:36 +1100 From: Stephen Rothwell To: Nathan Chancellor Cc: Daniel Vetter , Intel Graphics , DRI , =?UTF-8?B?Sm9zw6kgRXhww7NzaXRv?= , Linux Kernel Mailing List , Linux Next Mailing List , Maxime Ripard , llvm@lists.linux.dev Subject: Re: linux-next: manual merge of the drm-misc tree with the origin tree Message-ID: <20221118090636.00bfc293@canb.auug.org.au> In-Reply-To: References: <20221116105702.746ce3cf@canb.auug.org.au> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/cORwCokXw/BRPsMTVykVrdV"; protocol="application/pgp-signature"; micalg=pgp-sha256 Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org --Sig_/cORwCokXw/BRPsMTVykVrdV Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi Nathan, On Thu, 17 Nov 2022 10:29:33 -0700 Nathan Chancellor wr= ote: > > This resolution is not quite right, as pointed out by clang: >=20 > drivers/gpu/drm/vc4/vc4_hdmi.c:351:14: error: variable 'vc4_hdmi' is = uninitialized when used here [-Werror,-Wuninitialized] > mutex_lock(&vc4_hdmi->mutex); > ^~~~~~~~ > ./include/linux/mutex.h:187:44: note: expanded from macro 'mutex_lock' > #define mutex_lock(lock) mutex_lock_nested(lock, 0) > ^~~~ > drivers/gpu/drm/vc4/vc4_hdmi.c:322:27: note: initialize the variable = 'vc4_hdmi' to silence this warning > struct vc4_hdmi *vc4_hdmi; > ^ > =3D NULL > 1 error generated. >=20 > Obviously, the assignment of vc4_hdmi should be before mutex_lock(). Thanks for pointing that out (silly me :-) ). I have fixed up the resolution for today. --=20 Cheers, Stephen Rothwell --Sig_/cORwCokXw/BRPsMTVykVrdV Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAmN2sGwACgkQAVBC80lX 0GwqVgf7BKhwAejB2647+YTzGJFG5ESClma/Q+FqHOzAU5APyVxww5lrT7m+1h+w l+jNOiRIU9g4WG7zOHY7MW/cOYUSCDv1XmuK4JBhI+JnMffY7vt8FxnDYYFvDiE9 VHgYmM/uzu6VgWBjp4pV+bHmqbE0zkMSVeUd9fI8qmkuzydCSWu1wiYx3ihXaTLw 1gWzctWRm+7eQMVgPI09oV2ev1VbDXh5xkzjh11Fuj02he89O0eVUt9XVJkUB0SZ 4MGRrU0SKUx5SulxF7G2ELKYI/fJVz0tTbkPxLVUfY2MGMxQWbgZVHqJwDtZNs2c y3B3jrqzs40nAcfF7CQ/7qTj18mr6g== =qG1K -----END PGP SIGNATURE----- --Sig_/cORwCokXw/BRPsMTVykVrdV--