From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Shuah Khan <skhan@linuxfoundation.org>,
Brendan Higgins <brendanhiggins@google.com>,
John Johansen <john.johansen@canonical.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Rae Moar <rmoar@google.com>
Subject: linux-next: manual merge of the kunit-next tree with the apparmor tree
Date: Thu, 8 Dec 2022 12:46:53 +1100 [thread overview]
Message-ID: <20221208124653.71ba9491@canb.auug.org.au> (raw)
[-- Attachment #1: Type: text/plain, Size: 2575 bytes --]
Hi all,
Today's linux-next merge of the kunit-next tree got a conflict in:
security/apparmor/policy_unpack_test.c
between commits:
371e50a0b19f ("apparmor: make unpack_array return a trianary value")
32490541682b ("apparmor: Fix kunit test for out of bounds array")
from the apparmor tree and commit:
2c92044683f5 ("apparmor: test: make static symbols visible during kunit testing")
from the kunit-next tree.
I fixed it up (see below) and can carry the fix as necessary. This
is now fixed as far as linux-next is concerned, but any non trivial
conflicts should be mentioned to your upstream maintainer when your tree
is submitted for merging. You may also want to consider cooperating
with the maintainer of the conflicting tree to minimise any particularly
complex conflicts.
--
Cheers,
Stephen Rothwell
diff --cc security/apparmor/policy_unpack_test.c
index 7465da42492d,f25cf2a023d5..000000000000
--- a/security/apparmor/policy_unpack_test.c
+++ b/security/apparmor/policy_unpack_test.c
@@@ -144,8 -147,8 +147,8 @@@ static void policy_unpack_test_unpack_a
puf->e->pos += TEST_ARRAY_BUF_OFFSET;
- KUNIT_EXPECT_EQ(test, unpack_array(puf->e, NULL, &array_size),
- array_size = aa_unpack_array(puf->e, NULL);
-
++ KUNIT_EXPECT_EQ(test, aa_unpack_array(puf->e, NULL, &array_size),
+ TRI_TRUE);
KUNIT_EXPECT_EQ(test, array_size, (u16)TEST_ARRAY_SIZE);
KUNIT_EXPECT_PTR_EQ(test, puf->e->pos,
puf->e->start + TEST_ARRAY_BUF_OFFSET + sizeof(u16) + 1);
@@@ -159,8 -162,8 +162,8 @@@ static void policy_unpack_test_unpack_a
puf->e->pos += TEST_NAMED_ARRAY_BUF_OFFSET;
- KUNIT_EXPECT_EQ(test, unpack_array(puf->e, name, &array_size),
- array_size = aa_unpack_array(puf->e, name);
-
++ KUNIT_EXPECT_EQ(test, aa_unpack_array(puf->e, name, &array_size),
+ TRI_TRUE);
KUNIT_EXPECT_EQ(test, array_size, (u16)TEST_ARRAY_SIZE);
KUNIT_EXPECT_PTR_EQ(test, puf->e->pos,
puf->e->start + TEST_ARRAY_BUF_OFFSET + sizeof(u16) + 1);
@@@ -175,8 -178,9 +178,8 @@@ static void policy_unpack_test_unpack_a
puf->e->pos += TEST_NAMED_ARRAY_BUF_OFFSET;
puf->e->end = puf->e->start + TEST_ARRAY_BUF_OFFSET + sizeof(u16);
- KUNIT_EXPECT_EQ(test, unpack_array(puf->e, name, &array_size),
- array_size = aa_unpack_array(puf->e, name);
-
- KUNIT_EXPECT_EQ(test, array_size, 0);
++ KUNIT_EXPECT_EQ(test, aa_unpack_array(puf->e, name, &array_size),
+ TRI_FALSE);
KUNIT_EXPECT_PTR_EQ(test, puf->e->pos,
puf->e->start + TEST_NAMED_ARRAY_BUF_OFFSET);
}
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next reply other threads:[~2022-12-08 1:47 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-08 1:46 Stephen Rothwell [this message]
2022-12-13 23:58 ` linux-next: manual merge of the kunit-next tree with the apparmor tree Stephen Rothwell
2022-12-14 18:38 ` John Johansen
-- strict thread matches above, loose matches on Subject: below --
2022-12-08 2:53 Stephen Rothwell
2022-12-08 20:10 ` John Johansen
2022-12-12 17:52 ` Shuah Khan
2022-12-12 18:03 ` Shuah Khan
2022-12-12 19:20 ` John Johansen
2022-12-12 19:48 ` Shuah Khan
2022-12-12 19:53 ` John Johansen
2022-12-12 23:19 ` Shuah Khan
2022-12-12 23:56 ` David Gow
2022-12-13 3:22 ` Stephen Rothwell
2022-12-14 0:00 ` Stephen Rothwell
2022-12-14 0:55 ` John Johansen
2022-12-14 18:38 ` John Johansen
2022-04-05 2:55 Stephen Rothwell
2022-07-04 23:13 ` Stephen Rothwell
2022-07-05 8:57 ` David Gow
2022-07-05 18:22 ` John Johansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221208124653.71ba9491@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=brendanhiggins@google.com \
--cc=john.johansen@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=rmoar@google.com \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox