From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70DBFC4332F for ; Tue, 13 Dec 2022 01:11:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233773AbiLMBLy (ORCPT ); Mon, 12 Dec 2022 20:11:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41568 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231334AbiLMBLx (ORCPT ); Mon, 12 Dec 2022 20:11:53 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 822D41BE9A; Mon, 12 Dec 2022 17:11:52 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 2C161B81037; Tue, 13 Dec 2022 01:11:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 54BF9C433D2; Tue, 13 Dec 2022 01:11:49 +0000 (UTC) Date: Mon, 12 Dec 2022 20:11:46 -0500 From: Steven Rostedt To: Stephen Rothwell Cc: Masami Hiramatsu , Linux Kernel Mailing List , Linux Next Mailing List Subject: Re: linux-next: Signed-off-by missing for commit in the ftrace tree Message-ID: <20221212201146.08c32b28@gandalf.local.home> In-Reply-To: <20221213114249.1bac79ce@canb.auug.org.au> References: <20221213085200.772ddd94@canb.auug.org.au> <20221212175642.77cba577@gandalf.local.home> <20221213114249.1bac79ce@canb.auug.org.au> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org On Tue, 13 Dec 2022 11:42:49 +1100 Stephen Rothwell wrote: > Hi Steven, > > On Mon, 12 Dec 2022 17:56:42 -0500 Steven Rostedt wrote: > > > > Bah, not sure how this happened. I thought I pulled these patches directly > > from Masami. Does a rebase change the committer tags? As I probably rebased > > them on top of my branch. > > From "git help rebase" > > --signoff > Add a Signed-off-by trailer to all the rebased commits. Note that > if --interactive is given then only commits marked to be picked, > edited or reworded will have the trailer added. > > So this is not done by default. Yet another reason to avoid rebasing > others work unless absolutely necessary. > Yeah, this is temporary, as Masami is still setting up his test environment, he just asked me to pull his changes on top of mine so that I can run them. Now I know what not to do ;-) -- Steve