From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40FFDC61DB3 for ; Thu, 12 Jan 2023 22:27:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240622AbjALW1x (ORCPT ); Thu, 12 Jan 2023 17:27:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41764 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240516AbjALW1J (ORCPT ); Thu, 12 Jan 2023 17:27:09 -0500 Received: from mail-pg1-x535.google.com (mail-pg1-x535.google.com [IPv6:2607:f8b0:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A68F959F9B for ; Thu, 12 Jan 2023 14:24:36 -0800 (PST) Received: by mail-pg1-x535.google.com with SMTP id q9so13766942pgq.5 for ; Thu, 12 Jan 2023 14:24:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=content-disposition:mime-version:message-id:subject:cc:to:date:from :from:to:cc:subject:date:message-id:reply-to; bh=MIHU3yvE0AEyf97Few65TN6W0VeSVha7m422Ft94+7A=; b=CbA4pTm2SHhAMNA1b6IXOEtNp1xFz0u0mzMKo9bqUTONN3HQbnPTKBKrLsogLpNjSa 0ZNtxD3nvVpAux+j70KuFPBNjUf8wylSfZANYsIlgMlRAIbmw5JG17Tr947Su/sT89cO hWADWSOoopeu4L7R3sXZpD7hVv4uFgRkcQ0m8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-disposition:mime-version:message-id:subject:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MIHU3yvE0AEyf97Few65TN6W0VeSVha7m422Ft94+7A=; b=5YPZwcxYAF1jPao1DaVOLIMwMxDe20nzbET/qvimf5ajuTFtnfcxBqwuOANQfK6Cqs OHduEcpWmLSbbepZswetelIRDf+Wq0N3gywN/OlX7q9L0H8XYox7Oru9rF7z60/9dXV1 kVM1fKjRq6hXGjV3NDJnkV39Z4IBd6jwVa1WQPL95VAJfGF6ugB2hjgBlFCdd4veXyIx 0R7UvuJI83IOZeTdVjAaXQHneXkKlPGtuto/wFH2Iot7j/h1oPhXfoGexyuCmz6weCXx e+VCj+b3ru6uTAo7x43DHq7GakbOVzNmgnypKlTpFZdDUM8uo8ODJ4PWMBTqCZtJTdHn ouBQ== X-Gm-Message-State: AFqh2kpGO4CVaK7k3CTCW5DT4uNz2Ob9ISiyvz1TgmdmFBi39csTZpSB mAdEiDKgG4jqHcWVVlKv2dP/iA== X-Google-Smtp-Source: AMrXdXuKAy66qRsaguoO7dg6xnQ3vgZ5z1AK7rX4p+jat7ZwYy/A+VHwQzvqc14DEcs75u/ulmALZA== X-Received: by 2002:a05:6a00:3311:b0:582:6732:ee03 with SMTP id cq17-20020a056a00331100b005826732ee03mr8164704pfb.9.1673562275935; Thu, 12 Jan 2023 14:24:35 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id q20-20020aa79834000000b0058134d2df41sm11375879pfl.146.2023.01.12.14.24.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Jan 2023 14:24:35 -0800 (PST) From: coverity-bot X-Google-Original-From: coverity-bot Date: Thu, 12 Jan 2023 14:24:34 -0800 To: Mario Limonciello Cc: Lijo Lazar , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, "Jiadong.Zhu" , Hawking Zhang , Alex Deucher , Daniel Vetter , David Airlie , Likun Gao , dri-devel@lists.freedesktop.org, Tao Zhou , Christian =?iso-8859-1?Q?K=F6nig?= , "Pan, Xinhui" , yipechai , "Gustavo A. R. Silva" , linux-next@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Coverity: gfx_v9_0_init_cp_compute_microcode(): Control flow issues Message-ID: <202301121424.5FA0483AB@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org Hello! This is an experimental semi-automated report about issues detected by Coverity from a scan of next-20230111 as part of the linux-next scan project: https://scan.coverity.com/projects/linux-next-weekly-scan You're getting this email because you were associated with the identified lines of code (noted below) that were touched by commits: Mon Jan 9 17:02:18 2023 -0500 ec787deb2ddf ("drm/amd: Use `amdgpu_ucode_*` helpers for GFX9") Coverity reported the following: *** CID 1530548: Control flow issues (DEADCODE) drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c:1374 in gfx_v9_0_init_cp_compute_microcode() 1368 adev->gfx.mec2_feature_version = adev->gfx.mec_feature_version; 1369 } 1370 1371 gfx_v9_0_check_if_need_gfxoff(adev); 1372 gfx_v9_0_check_fw_write_wait(adev); 1373 if (err) { vvv CID 1530548: Control flow issues (DEADCODE) vvv Execution cannot reach this statement: "amdgpu_ucode_release(&adev-...". 1374 amdgpu_ucode_release(&adev->gfx.mec_fw); 1375 amdgpu_ucode_release(&adev->gfx.mec2_fw); 1376 } 1377 return err; 1378 } 1379 If this is a false positive, please let us know so we can mark it as such, or teach the Coverity rules to be smarter. If not, please make sure fixes get into linux-next. :) For patches fixing this, please include these lines (but double-check the "Fixes" first): Reported-by: coverity-bot Addresses-Coverity-ID: 1530548 ("Control flow issues") Fixes: ec787deb2ddf ("drm/amd: Use `amdgpu_ucode_*` helpers for GFX9") Thanks for your attention! -- Coverity-bot