From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A188C3DA78 for ; Fri, 13 Jan 2023 23:41:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230476AbjAMXlx (ORCPT ); Fri, 13 Jan 2023 18:41:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44356 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230363AbjAMXlw (ORCPT ); Fri, 13 Jan 2023 18:41:52 -0500 Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [IPv6:2607:f8b0:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0ADB68CBFB for ; Fri, 13 Jan 2023 15:41:51 -0800 (PST) Received: by mail-pl1-x632.google.com with SMTP id d15so24961290pls.6 for ; Fri, 13 Jan 2023 15:41:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=content-disposition:mime-version:message-id:subject:cc:to:date:from :from:to:cc:subject:date:message-id:reply-to; bh=q6MHYbwLCd4MXDktCkUEHbUjwJCPzByBEFcKICE41Wc=; b=oTZuy2QPWn8Ttcvpqg8Wf+v1IVfqF7e+evU+pjT9cDt2BTwDYJE0G5bkNpMF6ezT3g +SEvjpRmiSNsLRYN9qdquMxFrzldCiMPoVdF6prKORkPqeIap777PZoxpIHMOGBqf/A2 umpAryvMGRtP/6LszPqvra+mLhvn9hhxyqa3s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-disposition:mime-version:message-id:subject:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=q6MHYbwLCd4MXDktCkUEHbUjwJCPzByBEFcKICE41Wc=; b=G4wCXNsQ5Ch90gL1ULcTpx7lmUK/C8oPfQyS0KObK+ZqQt/NWSwe3/GpY2pd1IZslA b42dDvv4ySqQlpPETegsBk7qH/o7SWt8qlc2p/vOp02crMEE6tk3nrjjHPt+lO0eVuFd gQYpydgPY4Dnj4CD2y/FrQkztTKl6pzRXKTEDXB7/z3Hy4b7/S8SPiZAQxCsczmeTM8O Qb4f/Vn/ovw59aI5UNJa9dC0/MWdXzIvnMrn5yHS2+Z0R4w5mS8IYlg7tLoKbR5LQnOV UXAhextgNVrkuUhhM1uEnl/J0H9ICfXXtMuC7KecZOjFQbmTnpuzlQGdWWAewZevhe8p WoAA== X-Gm-Message-State: AFqh2koFARGlMzk+9tdYm4qkZ7kLvxCNKm0fXPCAOV2y7gGMzL7ueXDL wIMAk6q+pAHFzT/wrs53zAzcbA== X-Google-Smtp-Source: AMrXdXuZ+U95h1w+2Ck1r1tekdH9Z21e+CKOPUB5dzyfgK6c9cASSF6xg9nIODJAgNZMvedmhtP+eA== X-Received: by 2002:a05:6a20:c906:b0:b4:f66a:99a9 with SMTP id gx6-20020a056a20c90600b000b4f66a99a9mr43708881pzb.60.1673653310583; Fri, 13 Jan 2023 15:41:50 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id v14-20020a17090a4ece00b002194319662asm14592813pjl.42.2023.01.13.15.41.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Jan 2023 15:41:50 -0800 (PST) From: coverity-bot X-Google-Original-From: coverity-bot Date: Fri, 13 Jan 2023 15:41:49 -0800 To: Piergiorgio Beruto Cc: Paolo Abeni , Russell King , "David S. Miller" , linux-kernel@vger.kernel.org, Jakub Kicinski , netdev@vger.kernel.org, Heiner Kallweit , Eric Dumazet , Andrew Lunn , "Gustavo A. R. Silva" , linux-next@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Coverity: genphy_c45_plca_set_cfg(): UNINIT Message-ID: <202301131541.741EBE0@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org Hello! This is an experimental semi-automated report about issues detected by Coverity from a scan of next-20230113 as part of the linux-next scan project: https://scan.coverity.com/projects/linux-next-weekly-scan You're getting this email because you were associated with the identified lines of code (noted below) that were touched by commits: Wed Jan 11 08:35:02 2023 +0000 493323416fed ("drivers/net/phy: add helpers to get/set PLCA configuration") Coverity reported the following: *** CID 1530573: (UNINIT) drivers/net/phy/phy-c45.c:1036 in genphy_c45_plca_set_cfg() 1030 return ret; 1031 1032 val = ret; 1033 } 1034 1035 if (plca_cfg->node_cnt >= 0) vvv CID 1530573: (UNINIT) vvv Using uninitialized value "val". 1036 val = (val & ~MDIO_OATC14_PLCA_NCNT) | 1037 (plca_cfg->node_cnt << 8); 1038 1039 if (plca_cfg->node_id >= 0) 1040 val = (val & ~MDIO_OATC14_PLCA_ID) | 1041 (plca_cfg->node_id); drivers/net/phy/phy-c45.c:1076 in genphy_c45_plca_set_cfg() 1070 return ret; 1071 1072 val = ret; 1073 } 1074 1075 if (plca_cfg->burst_cnt >= 0) vvv CID 1530573: (UNINIT) vvv Using uninitialized value "val". 1076 val = (val & ~MDIO_OATC14_PLCA_MAXBC) | 1077 (plca_cfg->burst_cnt << 8); 1078 1079 if (plca_cfg->burst_tmr >= 0) 1080 val = (val & ~MDIO_OATC14_PLCA_BTMR) | 1081 (plca_cfg->burst_tmr); If this is a false positive, please let us know so we can mark it as such, or teach the Coverity rules to be smarter. If not, please make sure fixes get into linux-next. :) For patches fixing this, please include these lines (but double-check the "Fixes" first): Reported-by: coverity-bot Addresses-Coverity-ID: 1530573 ("UNINIT") Fixes: 493323416fed ("drivers/net/phy: add helpers to get/set PLCA configuration") Thanks for your attention! -- Coverity-bot