linux-next: Fixes tag needs some work in the pci tree

linux-next: Fixes tag needs some work in the pci tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 411 bytes --]

Hi all,

In commit

  593425276b94 ("PCI: endpoint: functions: Use memcpy_fromio()/memcpy_toio()")

Fixes tag

  Fixes: 349e7a85b25f ("PCI: endpoint: functions: Add an EP function to

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

Please do not split Fixes tags over more than 1 line.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the pci tree

[Lorenzo Pieralisi]

On Wed, Feb 13, 2019 at 10:03:09AM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   593425276b94 ("PCI: endpoint: functions: Use memcpy_fromio()/memcpy_toio()")
> 
> Fixes tag
> 
>   Fixes: 349e7a85b25f ("PCI: endpoint: functions: Add an EP function to
> 
> has these problem(s):
> 
>   - Subject has leading but no trailing parentheses
>   - Subject has leading but no trailing quotes
> 
> Please do not split Fixes tags over more than 1 line.

It is my mistake, apologies, I will fix the commit log up.

Thanks,
Lorenzo

Re: linux-next: Fixes tag needs some work in the pci tree

[Bjorn Helgaas]

On Tue, Feb 12, 2019 at 5:03 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> In commit
>
>   593425276b94 ("PCI: endpoint: functions: Use memcpy_fromio()/memcpy_toio()")
>
> Fixes tag
>
>   Fixes: 349e7a85b25f ("PCI: endpoint: functions: Add an EP function to
>
> has these problem(s):
>
>   - Subject has leading but no trailing parentheses
>   - Subject has leading but no trailing quotes
>
> Please do not split Fixes tags over more than 1 line.

Hi Stephen,

Are these and similar warnings generated by commit hooks or similar
scripts?  If so, do you publish them somewhere?  I'd like to be able
to set up commit hooks to catch things like this before they get to
you.

Bjorn

Re: linux-next: Fixes tag needs some work in the pci tree

[Stephen Rothwell]

[-- Attachment #1.1: Type: text/plain, Size: 427 bytes --]

Hi Bjorn,

On Wed, 13 Feb 2019 08:31:46 -0600 Bjorn Helgaas <bhelgaas@google.com> wrote:
>
> Are these and similar warnings generated by commit hooks or similar
> scripts?  If so, do you publish them somewhere?  I'd like to be able
> to set up commit hooks to catch things like this before they get to
> you.

I run the attached script over the new commits in each tree each day ...

-- 
Cheers,
Stephen Rothwell

[-- Attachment #1.2: check_fixes --]
[-- Type: application/x-shellscript, Size: 4195 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the pci tree

[Bjorn Helgaas]

On Wed, Feb 13, 2019 at 2:10 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi Bjorn,
>
> On Wed, 13 Feb 2019 08:31:46 -0600 Bjorn Helgaas <bhelgaas@google.com> wrote:
> >
> > Are these and similar warnings generated by commit hooks or similar
> > scripts?  If so, do you publish them somewhere?  I'd like to be able
> > to set up commit hooks to catch things like this before they get to
> > you.
>
> I run the attached script over the new commits in each tree each day ...

Thanks, I guess now I have no more excuse :)

Is the "missing a Signed-off-by from their committer" thing that I
regularly trip over a manual check?

Bjorn

Re: linux-next: Fixes tag needs some work in the pci tree

[Stephen Rothwell]

[-- Attachment #1.1: Type: text/plain, Size: 366 bytes --]

Hi Bjorn,

On Wed, 13 Feb 2019 14:19:32 -0600 Bjorn Helgaas <bhelgaas@google.com> wrote:
>
> Thanks, I guess now I have no more excuse :)

:-)

> Is the "missing a Signed-off-by from their committer" thing that I
> regularly trip over a manual check?

Ah, attached is the other script I run (maybe I should combine them).
-- 
Cheers,
Stephen Rothwell

[-- Attachment #1.2: check_commits --]
[-- Type: application/x-shellscript, Size: 1213 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the pci tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 404 bytes --]

Hi all,

In commit

  46c1bfcfcd87 ("PCI: xilinx-nwl: Fix Multi MSI data programming")

Fixes tag

  Fixes: ab597d35ef11 ("PCI: xilinx-nwl: Add support for Xilinx NWL PCIe

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

Please do not split Fixes tags across more than one line.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the pci tree

[Lorenzo Pieralisi]

On Sat, Jun 22, 2019 at 11:40:29PM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   46c1bfcfcd87 ("PCI: xilinx-nwl: Fix Multi MSI data programming")
> 
> Fixes tag
> 
>   Fixes: ab597d35ef11 ("PCI: xilinx-nwl: Add support for Xilinx NWL PCIe
> 
> has these problem(s):
> 
>   - Subject has leading but no trailing parentheses
>   - Subject has leading but no trailing quotes
> 
> Please do not split Fixes tags across more than one line.

Sorry, I do not know how I managed not to run your script on this
commit log. Log updated on my pci/xilinx branch, Bjorn please pull
it when you have time.

Thanks,
Lorenzo

RE: linux-next: Fixes tag needs some work in the pci tree

[Bharat Kumar Gogada]

> On Sat, Jun 22, 2019 at 11:40:29PM +1000, Stephen Rothwell wrote:
> > Hi all,
> >
> > In commit
> >
> >   46c1bfcfcd87 ("PCI: xilinx-nwl: Fix Multi MSI data programming")
> >
> > Fixes tag
> >
> >   Fixes: ab597d35ef11 ("PCI: xilinx-nwl: Add support for Xilinx NWL
> > PCIe
> >
> > has these problem(s):
> >
> >   - Subject has leading but no trailing parentheses
> >   - Subject has leading but no trailing quotes
> >
> > Please do not split Fixes tags across more than one line.
> 
> Sorry, I do not know how I managed not to run your script on this commit
> log. Log updated on my pci/xilinx branch, Bjorn please pull it when you
> have time.
> 
Thanks Lorenzo and Stephen for your time.

Regards,
Bharat

linux-next: Fixes tag needs some work in the pci tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 535 bytes --]

Hi all,

In commit

  fb3ffadca55a ("PCI: pciehp: Fix indefinite wait on sysfs requests")

Fixes tag

  Fixes: 54ecb8f7028c ("PCI: pciehp: Avoid returning prematurely from sysfs requests")

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

Did you mean

(probably not :-))
Fixes: 54ecb8f7028c ("Linux 5.4-rc1")

or

Fixes: 157c1062fcd8 ("PCI: pciehp: Avoid returning prematurely from sysfs requests")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the pci tree

[Bjorn Helgaas]

On Mon, Mar 30, 2020 at 3:39 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> In commit
>
>   fb3ffadca55a ("PCI: pciehp: Fix indefinite wait on sysfs requests")
>
> Fixes tag
>
>   Fixes: 54ecb8f7028c ("PCI: pciehp: Avoid returning prematurely from sysfs requests")
>
> has these problem(s):
>
>   - Subject does not match target commit subject
>     Just use
>         git log -1 --format='Fixes: %h ("%s")'
>
> Did you mean
>
> (probably not :-))
> Fixes: 54ecb8f7028c ("Linux 5.4-rc1")
>
> or
>
> Fixes: 157c1062fcd8 ("PCI: pciehp: Avoid returning prematurely from sysfs requests")

Fixed, thanks!

Re: linux-next: Fixes tag needs some work in the pci tree

[Lukas Wunner]

On Mon, Mar 30, 2020 at 03:53:29PM -0500, Bjorn Helgaas wrote:
> On Mon, Mar 30, 2020 at 3:39 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote> > In commit
> >
> >   fb3ffadca55a ("PCI: pciehp: Fix indefinite wait on sysfs requests")
> >
> > Fixes tag
> >
> >   Fixes: 54ecb8f7028c ("PCI: pciehp: Avoid returning prematurely from sysfs requests")
> >
> > has these problem(s):
> >
> >   - Subject does not match target commit subject
> >     Just use
> >         git log -1 --format='Fixes: %h ("%s")'
> >
> > Did you mean
> >
> > (probably not :-))
> > Fixes: 54ecb8f7028c ("Linux 5.4-rc1")
> >
> > or
> >
> > Fixes: 157c1062fcd8 ("PCI: pciehp: Avoid returning prematurely from sysfs requests")
> 
> Fixed, thanks!

Ugh, sorry about that.

In case you're not aware, it's only fixed on your next branch,
not on the pci/hotplug branch.

Thanks,

Lukas

Re: linux-next: Fixes tag needs some work in the pci tree

[Lukas Wunner]

On Tue, Mar 31, 2020 at 05:14:58AM +0200, Lukas Wunner wrote:
> On Mon, Mar 30, 2020 at 03:53:29PM -0500, Bjorn Helgaas wrote:
> > On Mon, Mar 30, 2020 at 3:39 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote> > In commit
> > >
> > >   fb3ffadca55a ("PCI: pciehp: Fix indefinite wait on sysfs requests")
> > >
> > > Fixes tag
> > >
> > >   Fixes: 54ecb8f7028c ("PCI: pciehp: Avoid returning prematurely from sysfs requests")
> > >
> > > has these problem(s):
> > >
> > >   - Subject does not match target commit subject
> > >     Just use
> > >         git log -1 --format='Fixes: %h ("%s")'
> > >
> > > Did you mean
> > >
> > > (probably not :-))
> > > Fixes: 54ecb8f7028c ("Linux 5.4-rc1")
> > >
> > > or
> > >
> > > Fixes: 157c1062fcd8 ("PCI: pciehp: Avoid returning prematurely from sysfs requests")
> > 
> > Fixed, thanks!
> 
> Ugh, sorry about that.
> 
> In case you're not aware, it's only fixed on your next branch,
> not on the pci/hotplug branch.

Also, the incorrect commit hash is repeated further up in the commit
message:  "This flag, which was introduced by commit 54ecb8f7028c"

Again, sorry, I don't really understand how this happened.

Thanks,

Lukas

Re: linux-next: Fixes tag needs some work in the pci tree

[Bjorn Helgaas]

On Mon, Mar 30, 2020 at 10:32 PM Lukas Wunner <lukas@wunner.de> wrote:
> On Tue, Mar 31, 2020 at 05:14:58AM +0200, Lukas Wunner wrote:
> > On Mon, Mar 30, 2020 at 03:53:29PM -0500, Bjorn Helgaas wrote:
> > > On Mon, Mar 30, 2020 at 3:39 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote> > In commit
> > > >
> > > >   fb3ffadca55a ("PCI: pciehp: Fix indefinite wait on sysfs requests")
> > > >
> > > > Fixes tag
> > > >
> > > >   Fixes: 54ecb8f7028c ("PCI: pciehp: Avoid returning prematurely from sysfs requests")
> > > >
> > > > has these problem(s):
> > > >
> > > >   - Subject does not match target commit subject
> > > >     Just use
> > > >         git log -1 --format='Fixes: %h ("%s")'
> > > >
> > > > Did you mean
> > > >
> > > > (probably not :-))
> > > > Fixes: 54ecb8f7028c ("Linux 5.4-rc1")
> > > >
> > > > or
> > > >
> > > > Fixes: 157c1062fcd8 ("PCI: pciehp: Avoid returning prematurely from sysfs requests")
> > >
> > > Fixed, thanks!
> >
> > Ugh, sorry about that.
> >
> > In case you're not aware, it's only fixed on your next branch,
> > not on the pci/hotplug branch.
>
> Also, the incorrect commit hash is repeated further up in the commit
> message:  "This flag, which was introduced by commit 54ecb8f7028c"

Thanks, I fixed that, too, and pushed my -next branch.  It's fixed on
my local pci/hotplug branch, but I didn't bother pushing that branch
because it doesn't need to be build-tested and it doesn't matter for
any future hotplug patches.

Bjorn

linux-next: Fixes tag needs some work in the pci tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 499 bytes --]

Hi all,

In commit

  769785cebe0f ("PCI: rcar: Fix runtime PM imbalance on error")

Fixes tag

  Fixes: 0df6150e7ceb ("PCI: rcar: Use runtime PM to control controller

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

Please do not split Fixes tags over more than one line.  Loooks like the
lines also were rearranged - the end of the fixes line is 2 lines above
the rest.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the pci tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 416 bytes --]

Hi all,

In commit

  466d79c1a470 ("PCI: Fix overflow in command-line resource alignment requests")

Fixes tag

  Fixes: 32a9a682bef2 ("PCI: allow assignment of memory resources with a

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

Please do not split Fixes tags over more than one line.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the pci tree

[Bjorn Helgaas]

On Sun, Nov 22, 2020 at 08:55:25PM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   466d79c1a470 ("PCI: Fix overflow in command-line resource alignment requests")
> 
> Fixes tag
> 
>   Fixes: 32a9a682bef2 ("PCI: allow assignment of memory resources with a
> 
> has these problem(s):
> 
>   - Subject has leading but no trailing parentheses
>   - Subject has leading but no trailing quotes
> 
> Please do not split Fixes tags over more than one line.

Fixed, thanks!  I probably won't rebuild the "next" branch containing
this until Monday.

linux-next: Fixes tag needs some work in the pci tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 445 bytes --]

Hi all,

In commit

  58d4c63d0a27 ("PCI/IOV: Enlarge virtfn sysfs name buffer")

Fixes tag

  Fixes: dd7cc44d0 ("PCI: add SR-IOV API for Physical Function driver")

has these problem(s):

  - SHA1 should be at least 12 digits long
    This can be fixed for the future by setting core.abbrev to 12 (or
    more) or (for git v2.11 or later) just making sure it is not set
    (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the pci tree

[Alexey V. Vissarionov]

[-- Attachment #1: Type: text/plain, Size: 559 bytes --]

On 2023-01-16 08:14:25 +1100, Stephen Rothwell wrote:
 > In commit
 > 58d4c63d0a27 ("PCI/IOV: Enlarge virtfn sysfs name buffer")
 > Fixes tag
 > Fixes: dd7cc44d0 ("PCI: add SR-IOV API for Physical Function driver")
 > has these problem(s):
 > - SHA1 should be at least 12 digits long

Full SHA1 is dd7cc44d0bcec5e9c42fe52e88dc254ae62eac8d
First 12 digits would obviously be dd7cc44d0bce


-- 
Alexey V. Vissarionov
gremlin ПРИ altlinux ТЧК org; +vii-cmiii-ccxxix-lxxix-xlii
GPG: 0D92F19E1C0DC36E27F61A29CD17E2B43D879005 @ hkp://keys.gnupg.net

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

Re: linux-next: Fixes tag needs some work in the pci tree

[Bjorn Helgaas]

On Mon, Jan 16, 2023 at 06:23:55AM +0300, Alexey V. Vissarionov wrote:
> On 2023-01-16 08:14:25 +1100, Stephen Rothwell wrote:
>  > In commit
>  > 58d4c63d0a27 ("PCI/IOV: Enlarge virtfn sysfs name buffer")
>  > Fixes tag
>  > Fixes: dd7cc44d0 ("PCI: add SR-IOV API for Physical Function driver")
>  > has these problem(s):
>  > - SHA1 should be at least 12 digits long
> 
> Full SHA1 is dd7cc44d0bcec5e9c42fe52e88dc254ae62eac8d
> First 12 digits would obviously be dd7cc44d0bce

I fixed it locally for you, so no need to repost for this.

Bjorn

linux-next: Fixes tag needs some work in the pci tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 388 bytes --]

Hi all,

In commit

  aaf840725904 ("PCI: dw-rockchip: Depend on PCI_ENDPOINT if building endpoint mode support")

Fixes tag

  Fixes: 9b2ba393b3a6 ("PCI: dw-rockchip: Add endpoint mode support")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: 728538f5e806 ("PCI: dw-rockchip: Add endpoint mode support")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the pci tree

[Niklas Cassel]

On Mon, Jul 01, 2024 at 09:13:20AM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   aaf840725904 ("PCI: dw-rockchip: Depend on PCI_ENDPOINT if building endpoint mode support")
> 
> Fixes tag
> 
>   Fixes: 9b2ba393b3a6 ("PCI: dw-rockchip: Add endpoint mode support")
> 
> has these problem(s):
> 
>   - Target SHA1 does not exist
> 
> Maybe you meant
> 
> Fixes: 728538f5e806 ("PCI: dw-rockchip: Add endpoint mode support")


Hello Stephen,

yes, that is correct.
The branch was rebased so the SHA1 changed.

Perhaps the maintainers could update the Fixes tag.

(Personally, I would just squash the small fix with the commit that it fixes.)


Kind regards,
Niklas

Re: linux-next: Fixes tag needs some work in the pci tree

[Krzysztof Wilczyński]

Hello,

> > In commit
> > 
> >   aaf840725904 ("PCI: dw-rockchip: Depend on PCI_ENDPOINT if building endpoint mode support")
> > 
> > Fixes tag
> > 
> >   Fixes: 9b2ba393b3a6 ("PCI: dw-rockchip: Add endpoint mode support")
> > 
> > has these problem(s):
> > 
> >   - Target SHA1 does not exist
> > 
> > Maybe you meant
> > 
> > Fixes: 728538f5e806 ("PCI: dw-rockchip: Add endpoint mode support")
[...]
> The branch was rebased so the SHA1 changed.
> 
> Perhaps the maintainers could update the Fixes tag.
> 
> (Personally, I would just squash the small fix with the commit that it fixes.)

I will squash the patch that adds PCI_ENDPOINT dependency with the rest of
the series, and then drop the Fixes: tag afterwards, since it would not
longer be needed.

	Krzysztof

linux-next: Fixes tag needs some work in the pci tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 420 bytes --]

Hi all,

In commit

  7027b415ff1a ("cpufreq/amd-pstate-ut: Add fix for min freq unit test")

Fixes tag

  Fixes: 642aff3964b0f ("cpufreq/amd-pstate: Set the initial min_freq to lowest_nonlinear_freq")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: f2542c904294 ("cpufreq/amd-pstate: Set the initial min_freq to lowest_nonlinear_freq")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the pci tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 604 bytes --]

Hi all,

Sorry, this should have referred to the pm tree not he pci tree.

On Fri, 25 Oct 2024 08:08:00 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> In commit
> 
>   7027b415ff1a ("cpufreq/amd-pstate-ut: Add fix for min freq unit test")
> 
> Fixes tag
> 
>   Fixes: 642aff3964b0f ("cpufreq/amd-pstate: Set the initial min_freq to lowest_nonlinear_freq")
> 
> has these problem(s):
> 
>   - Target SHA1 does not exist
> 
> Maybe you meant
> 
> Fixes: f2542c904294 ("cpufreq/amd-pstate: Set the initial min_freq to lowest_nonlinear_freq")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the pci tree

[Mario Limonciello]

On 10/24/2024 16:10, Stephen Rothwell wrote:
> Hi all,
> 
> Sorry, this should have referred to the pm tree not he pci tree.
> 
> On Fri, 25 Oct 2024 08:08:00 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>>
>> In commit
>>
>>    7027b415ff1a ("cpufreq/amd-pstate-ut: Add fix for min freq unit test")
>>
>> Fixes tag
>>
>>    Fixes: 642aff3964b0f ("cpufreq/amd-pstate: Set the initial min_freq to lowest_nonlinear_freq")
>>
>> has these problem(s):
>>
>>    - Target SHA1 does not exist
>>
>> Maybe you meant
>>
>> Fixes: f2542c904294 ("cpufreq/amd-pstate: Set the initial min_freq to lowest_nonlinear_freq")
> 

Ah, this happened because we did a rebase to drop out some patches 
pulled in prematurely the commit IDs changed for stuff on top. Both 
commits are coming in 6.13-rc1 so there is no impact to stable trees, I 
guess it's OK if the commit log has a mistake.