linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: linux-next: build warnings after merge of the nvmem tree
Date: Wed, 15 Mar 2023 10:30:48 +0100	[thread overview]
Message-ID: <20230315103048.2af51629@xps-13> (raw)
In-Reply-To: <20230315124612.6cb48c72@canb.auug.org.au>

Hi Srinivas,

sfr@canb.auug.org.au wrote on Wed, 15 Mar 2023 12:46:12 +1100:

> Hi all,
> 
> After merging the nvmem tree, today's linux-next build (htmldocs)
> produced these warnings:
> 
> drivers/of/base.c:1228: warning: Function parameter or member 'alias' not described in 'of_alias_from_compatible'
> drivers/of/base.c:1228: warning: Excess function parameter 'modalias' description in 'of_alias_from_compatible'
> 
> Introduced by commit
> 
>   c077ed868e50 ("of: Rename of_modalias_node()")

I failed to update all occurrences of "modalias" in this function. Here
is a diff that you can squash directly with the above mentioned commit.
I can submit it through the mailing list as well, but I believe it's
best to squash that based on the previous conversations (and it does
not matter since you re-send the patches to Greg in the end).

Thanks,
Miquèl

---

From f1378f89b9964fea759eabf5a54beee2782890c7 Mon Sep 17 00:00:00 2001
From: Miquel Raynal <miquel.raynal@bootlin.com>
Date: Wed, 15 Mar 2023 10:25:28 +0100
Subject: [PATCH] fixup! of: Rename of_modalias_node()

---
 drivers/of/base.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/of/base.c b/drivers/of/base.c
index 3c1badab287f..161fe3192c46 100644
--- a/drivers/of/base.c
+++ b/drivers/of/base.c
@@ -1211,7 +1211,7 @@ EXPORT_SYMBOL(of_find_matching_node_and_match);
  * of_alias_from_compatible - Lookup appropriate alias for a device node
  *			      depending on compatible
  * @node:	pointer to a device tree node
- * @modalias:	Pointer to buffer that alias value will be copied into
+ * @alias:	Pointer to buffer that alias value will be copied into
  * @len:	Length of alias value
  *
  * Based on the value of the compatible property, this routine will attempt
-- 
2.34.1


      reply	other threads:[~2023-03-15  9:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-15  1:46 linux-next: build warnings after merge of the nvmem tree Stephen Rothwell
2023-03-15  9:30 ` Miquel Raynal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230315103048.2af51629@xps-13 \
    --to=miquel.raynal@bootlin.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    --cc=srinivas.kandagatla@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).