From: Heiko Carstens <hca@linux.ibm.com>
To: Sven Schnelle <svens@linux.ibm.com>
Cc: Vasily Gorbik <gor@linux.ibm.com>,
Alexander Gordeev <agordeev@linux.ibm.com>,
linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org,
linux-next@vger.kernel.org,
Anastasia Eskova <anastasia.eskova@ibm.com>,
Randy Dunlap <rdunlap@infradead.org>
Subject: Re: [PATCH] s390/certstore: select CRYPTO_LIB_SHA256
Date: Sat, 29 Jul 2023 15:48:31 +0200 [thread overview]
Message-ID: <20230729134831.6882-C-hca@linux.ibm.com> (raw)
In-Reply-To: <20230728100430.1567328-1-svens@linux.ibm.com>
On Fri, Jul 28, 2023 at 12:04:30PM +0200, Sven Schnelle wrote:
> A build failure was reported when sha256() is not present:
>
> gcc-13.1.0-nolibc/s390-linux/bin/s390-linux-ld: arch/s390/kernel/cert_store.o: in function `check_certificate_hash':
> arch/s390/kernel/cert_store.c:267: undefined reference to `sha256'
>
> Therefore make CONFIG_CERT_STORE select CRYPTO_LIB_SHA256.
>
> Fixes: 8cf57d7217c3 ("s390: add support for user-defined certificates")
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Closes: https://lore.kernel.org/all/8ecb57fb-4560-bdfc-9e55-63e3b0937132@infradead.org/
> Signed-off-by: Sven Schnelle <svens@linux.ibm.com>
> ---
> arch/s390/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
Applied, thanks!
next prev parent reply other threads:[~2023-07-29 13:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-28 10:04 [PATCH] s390/certstore: select CRYPTO_LIB_SHA256 Sven Schnelle
2023-07-29 13:48 ` Heiko Carstens [this message]
2023-08-01 2:16 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230729134831.6882-C-hca@linux.ibm.com \
--to=hca@linux.ibm.com \
--cc=agordeev@linux.ibm.com \
--cc=anastasia.eskova@ibm.com \
--cc=gor@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=svens@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).