* [PATCH] s390/certstore: select CRYPTO_LIB_SHA256
@ 2023-07-28 10:04 Sven Schnelle
2023-07-29 13:48 ` Heiko Carstens
2023-08-01 2:16 ` Randy Dunlap
0 siblings, 2 replies; 3+ messages in thread
From: Sven Schnelle @ 2023-07-28 10:04 UTC (permalink / raw)
To: Heiko Carstens, Vasily Gorbik, Alexander Gordeev
Cc: linux-kernel, linux-s390, linux-next, Anastasia Eskova,
Randy Dunlap
A build failure was reported when sha256() is not present:
gcc-13.1.0-nolibc/s390-linux/bin/s390-linux-ld: arch/s390/kernel/cert_store.o: in function `check_certificate_hash':
arch/s390/kernel/cert_store.c:267: undefined reference to `sha256'
Therefore make CONFIG_CERT_STORE select CRYPTO_LIB_SHA256.
Fixes: 8cf57d7217c3 ("s390: add support for user-defined certificates")
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Closes: https://lore.kernel.org/all/8ecb57fb-4560-bdfc-9e55-63e3b0937132@infradead.org/
Signed-off-by: Sven Schnelle <svens@linux.ibm.com>
---
arch/s390/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/s390/Kconfig b/arch/s390/Kconfig
index d9d50a7a2016..18bf754e1fad 100644
--- a/arch/s390/Kconfig
+++ b/arch/s390/Kconfig
@@ -516,6 +516,7 @@ config KEXEC_SIG
config CERT_STORE
bool "Get user certificates via DIAG320"
depends on KEYS
+ select CRYPTO_LIB_SHA256
help
Enable this option if you want to access user-provided secure boot
certificates via DIAG 0x320.
--
2.39.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] s390/certstore: select CRYPTO_LIB_SHA256
2023-07-28 10:04 [PATCH] s390/certstore: select CRYPTO_LIB_SHA256 Sven Schnelle
@ 2023-07-29 13:48 ` Heiko Carstens
2023-08-01 2:16 ` Randy Dunlap
1 sibling, 0 replies; 3+ messages in thread
From: Heiko Carstens @ 2023-07-29 13:48 UTC (permalink / raw)
To: Sven Schnelle
Cc: Vasily Gorbik, Alexander Gordeev, linux-kernel, linux-s390,
linux-next, Anastasia Eskova, Randy Dunlap
On Fri, Jul 28, 2023 at 12:04:30PM +0200, Sven Schnelle wrote:
> A build failure was reported when sha256() is not present:
>
> gcc-13.1.0-nolibc/s390-linux/bin/s390-linux-ld: arch/s390/kernel/cert_store.o: in function `check_certificate_hash':
> arch/s390/kernel/cert_store.c:267: undefined reference to `sha256'
>
> Therefore make CONFIG_CERT_STORE select CRYPTO_LIB_SHA256.
>
> Fixes: 8cf57d7217c3 ("s390: add support for user-defined certificates")
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Closes: https://lore.kernel.org/all/8ecb57fb-4560-bdfc-9e55-63e3b0937132@infradead.org/
> Signed-off-by: Sven Schnelle <svens@linux.ibm.com>
> ---
> arch/s390/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
Applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] s390/certstore: select CRYPTO_LIB_SHA256
2023-07-28 10:04 [PATCH] s390/certstore: select CRYPTO_LIB_SHA256 Sven Schnelle
2023-07-29 13:48 ` Heiko Carstens
@ 2023-08-01 2:16 ` Randy Dunlap
1 sibling, 0 replies; 3+ messages in thread
From: Randy Dunlap @ 2023-08-01 2:16 UTC (permalink / raw)
To: Sven Schnelle, Heiko Carstens, Vasily Gorbik, Alexander Gordeev
Cc: linux-kernel, linux-s390, linux-next, Anastasia Eskova
On 7/28/23 03:04, Sven Schnelle wrote:
> A build failure was reported when sha256() is not present:
>
> gcc-13.1.0-nolibc/s390-linux/bin/s390-linux-ld: arch/s390/kernel/cert_store.o: in function `check_certificate_hash':
> arch/s390/kernel/cert_store.c:267: undefined reference to `sha256'
>
> Therefore make CONFIG_CERT_STORE select CRYPTO_LIB_SHA256.
>
> Fixes: 8cf57d7217c3 ("s390: add support for user-defined certificates")
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Closes: https://lore.kernel.org/all/8ecb57fb-4560-bdfc-9e55-63e3b0937132@infradead.org/
> Signed-off-by: Sven Schnelle <svens@linux.ibm.com>
Sorry for the delay.
Tested-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.
> ---
> arch/s390/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/s390/Kconfig b/arch/s390/Kconfig
> index d9d50a7a2016..18bf754e1fad 100644
> --- a/arch/s390/Kconfig
> +++ b/arch/s390/Kconfig
> @@ -516,6 +516,7 @@ config KEXEC_SIG
> config CERT_STORE
> bool "Get user certificates via DIAG320"
> depends on KEYS
> + select CRYPTO_LIB_SHA256
> help
> Enable this option if you want to access user-provided secure boot
> certificates via DIAG 0x320.
--
~Randy
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-08-01 2:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-28 10:04 [PATCH] s390/certstore: select CRYPTO_LIB_SHA256 Sven Schnelle
2023-07-29 13:48 ` Heiko Carstens
2023-08-01 2:16 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).