* [PATCH v2 1/1] media: v4l: usb: Use correct dependency for camera sensor drivers
@ 2023-08-18 9:51 Sakari Ailus
2023-08-18 11:09 ` Sakari Ailus
2023-08-19 1:53 ` Randy Dunlap
0 siblings, 2 replies; 4+ messages in thread
From: Sakari Ailus @ 2023-08-18 9:51 UTC (permalink / raw)
To: linux-media, Randy Dunlap
Cc: hverkuil, Stephen Rothwell, Linux Kernel Mailing List, linux-next,
Wentong Wu, Zhifeng Wang, Mauro Carvalho Chehab
The Kconfig option that enables compiling camera sensor drivers is
VIDEO_CAMERA_SENSOR rather than MEDIA_CAMERA_SUPPORT as it was previously.
Fix this.
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Fixes: 7d3c7d2a2914 ("media: i2c: Add a camera sensor top level menu")
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
---
since v1:
- Also include MMP camera Kconfig fix.
drivers/media/platform/marvell/Kconfig | 4 ++--
drivers/media/usb/em28xx/Kconfig | 4 ++--
drivers/media/usb/go7007/Kconfig | 2 +-
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/media/platform/marvell/Kconfig b/drivers/media/platform/marvell/Kconfig
index ec1a16734a28..d6499ffe30e8 100644
--- a/drivers/media/platform/marvell/Kconfig
+++ b/drivers/media/platform/marvell/Kconfig
@@ -7,7 +7,7 @@ config VIDEO_CAFE_CCIC
depends on V4L_PLATFORM_DRIVERS
depends on PCI && I2C && VIDEO_DEV
depends on COMMON_CLK
- select VIDEO_OV7670
+ select VIDEO_OV7670 if MEDIA_SUBDRV_AUTOSELECT && VIDEO_CAMERA_SENSOR
select VIDEOBUF2_VMALLOC
select VIDEOBUF2_DMA_CONTIG
select VIDEOBUF2_DMA_SG
@@ -22,7 +22,7 @@ config VIDEO_MMP_CAMERA
depends on I2C && VIDEO_DEV
depends on ARCH_MMP || COMPILE_TEST
depends on COMMON_CLK
- select VIDEO_OV7670
+ select VIDEO_OV7670 if MEDIA_SUBDRV_AUTOSELECT && VIDEO_CAMERA_SENSOR
select I2C_GPIO
select VIDEOBUF2_VMALLOC
select VIDEOBUF2_DMA_CONTIG
diff --git a/drivers/media/usb/em28xx/Kconfig b/drivers/media/usb/em28xx/Kconfig
index b3c472b8c5a9..cb61fd6cc6c6 100644
--- a/drivers/media/usb/em28xx/Kconfig
+++ b/drivers/media/usb/em28xx/Kconfig
@@ -12,8 +12,8 @@ config VIDEO_EM28XX_V4L2
select VIDEO_SAA711X if MEDIA_SUBDRV_AUTOSELECT
select VIDEO_TVP5150 if MEDIA_SUBDRV_AUTOSELECT
select VIDEO_MSP3400 if MEDIA_SUBDRV_AUTOSELECT
- select VIDEO_MT9V011 if MEDIA_SUBDRV_AUTOSELECT && MEDIA_CAMERA_SUPPORT
- select VIDEO_OV2640 if MEDIA_SUBDRV_AUTOSELECT && MEDIA_CAMERA_SUPPORT
+ select VIDEO_MT9V011 if MEDIA_SUBDRV_AUTOSELECT && VIDEO_CAMERA_SENSOR
+ select VIDEO_OV2640 if MEDIA_SUBDRV_AUTOSELECT && VIDEO_CAMERA_SENSOR
help
This is a video4linux driver for Empia 28xx based TV cards.
diff --git a/drivers/media/usb/go7007/Kconfig b/drivers/media/usb/go7007/Kconfig
index 4ff79940ad8d..b2a15d9fb1f3 100644
--- a/drivers/media/usb/go7007/Kconfig
+++ b/drivers/media/usb/go7007/Kconfig
@@ -12,8 +12,8 @@ config VIDEO_GO7007
select VIDEO_TW2804 if MEDIA_SUBDRV_AUTOSELECT
select VIDEO_TW9903 if MEDIA_SUBDRV_AUTOSELECT
select VIDEO_TW9906 if MEDIA_SUBDRV_AUTOSELECT
- select VIDEO_OV7640 if MEDIA_SUBDRV_AUTOSELECT && MEDIA_CAMERA_SUPPORT
select VIDEO_UDA1342 if MEDIA_SUBDRV_AUTOSELECT
+ select VIDEO_OV7640 if MEDIA_SUBDRV_AUTOSELECT && VIDEO_CAMERA_SENSOR
help
This is a video4linux driver for the WIS GO7007 MPEG
encoder chip.
--
2.39.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v2 1/1] media: v4l: usb: Use correct dependency for camera sensor drivers
2023-08-18 9:51 [PATCH v2 1/1] media: v4l: usb: Use correct dependency for camera sensor drivers Sakari Ailus
@ 2023-08-18 11:09 ` Sakari Ailus
2023-08-19 1:53 ` Randy Dunlap
1 sibling, 0 replies; 4+ messages in thread
From: Sakari Ailus @ 2023-08-18 11:09 UTC (permalink / raw)
To: Sakari Ailus
Cc: linux-media, Randy Dunlap, hverkuil, Stephen Rothwell,
Linux Kernel Mailing List, linux-next, Wentong Wu, Zhifeng Wang,
Mauro Carvalho Chehab
On Fri, Aug 18, 2023 at 12:51:49PM +0300, Sakari Ailus wrote:
> The Kconfig option that enables compiling camera sensor drivers is
> VIDEO_CAMERA_SENSOR rather than MEDIA_CAMERA_SUPPORT as it was previously.
> Fix this.
Due to marvell changes it should be added:
Also select VIDEO_OV7670 for marvell platform drivers only if
MEDIA_SUBDRV_AUTOSELECT and VIDEO_CAMERA_SENSOR are enabled.
"usb: " should thus also be dropped from subject.
--
Sakari Ailus
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2 1/1] media: v4l: usb: Use correct dependency for camera sensor drivers
2023-08-18 9:51 [PATCH v2 1/1] media: v4l: usb: Use correct dependency for camera sensor drivers Sakari Ailus
2023-08-18 11:09 ` Sakari Ailus
@ 2023-08-19 1:53 ` Randy Dunlap
2023-08-21 11:09 ` Sakari Ailus
1 sibling, 1 reply; 4+ messages in thread
From: Randy Dunlap @ 2023-08-19 1:53 UTC (permalink / raw)
To: Sakari Ailus, linux-media
Cc: hverkuil, Stephen Rothwell, Linux Kernel Mailing List, linux-next,
Wentong Wu, Zhifeng Wang, Mauro Carvalho Chehab
Hi Sakari,
On 8/18/23 02:51, Sakari Ailus wrote:
> The Kconfig option that enables compiling camera sensor drivers is
> VIDEO_CAMERA_SENSOR rather than MEDIA_CAMERA_SUPPORT as it was previously.
> Fix this.
>
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Fixes: 7d3c7d2a2914 ("media: i2c: Add a camera sensor top level menu")
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> ---
> since v1:
>
> - Also include MMP camera Kconfig fix.
>
> drivers/media/platform/marvell/Kconfig | 4 ++--
> drivers/media/usb/em28xx/Kconfig | 4 ++--
> drivers/media/usb/go7007/Kconfig | 2 +-
> 3 files changed, 5 insertions(+), 5 deletions(-)
>
This v2 patch fixes a few more issues but there is still one nagging problem
(2 versions of it, one with VIDEO_VIA_CAMERA=y and one with VIDEO_VIA_CAMERA=m):
(1)
WARNING: unmet direct dependencies detected for VIDEO_OV7670
Depends on [n]: MEDIA_SUPPORT [=y] && VIDEO_DEV [=y] && VIDEO_CAMERA_SENSOR [=n]
Selected by [y]:
- VIDEO_VIA_CAMERA [=y] && MEDIA_SUPPORT [=y] && MEDIA_PLATFORM_SUPPORT [=y] && MEDIA_PLATFORM_DRIVERS [=y] && V4L_PLATFORM_DRIVERS [=y] && FB_VIA [=y] && VIDEO_DEV [=y]
WARNING: unmet direct dependencies detected for VIDEO_OV7670
Depends on [n]: MEDIA_SUPPORT [=y] && VIDEO_DEV [=y] && VIDEO_CAMERA_SENSOR [=n]
Selected by [y]:
- VIDEO_VIA_CAMERA [=y] && MEDIA_SUPPORT [=y] && MEDIA_PLATFORM_SUPPORT [=y] && MEDIA_PLATFORM_DRIVERS [=y] && V4L_PLATFORM_DRIVERS [=y] && FB_VIA [=y] && VIDEO_DEV [=y]
(2)
WARNING: unmet direct dependencies detected for VIDEO_OV7670
Depends on [n]: MEDIA_SUPPORT [=y] && VIDEO_DEV [=m] && VIDEO_CAMERA_SENSOR [=n]
Selected by [m]:
- VIDEO_VIA_CAMERA [=m] && MEDIA_SUPPORT [=y] && MEDIA_PLATFORM_SUPPORT [=y] && MEDIA_PLATFORM_DRIVERS [=y] && V4L_PLATFORM_DRIVERS [=y] && FB_VIA [=m] && VIDEO_DEV [=m]
WARNING: unmet direct dependencies detected for VIDEO_OV7670
Depends on [n]: MEDIA_SUPPORT [=y] && VIDEO_DEV [=m] && VIDEO_CAMERA_SENSOR [=n]
Selected by [m]:
- VIDEO_VIA_CAMERA [=m] && MEDIA_SUPPORT [=y] && MEDIA_PLATFORM_SUPPORT [=y] && MEDIA_PLATFORM_DRIVERS [=y] && V4L_PLATFORM_DRIVERS [=y] && FB_VIA [=m] && VIDEO_DEV [=m]
Let me know if you need full randconfig files for any of these.
Thanks.
--
~Randy
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2 1/1] media: v4l: usb: Use correct dependency for camera sensor drivers
2023-08-19 1:53 ` Randy Dunlap
@ 2023-08-21 11:09 ` Sakari Ailus
0 siblings, 0 replies; 4+ messages in thread
From: Sakari Ailus @ 2023-08-21 11:09 UTC (permalink / raw)
To: Randy Dunlap
Cc: linux-media, hverkuil, Stephen Rothwell,
Linux Kernel Mailing List, linux-next, Wentong Wu, Zhifeng Wang,
Mauro Carvalho Chehab
Hi Randy,
On Fri, Aug 18, 2023 at 06:53:19PM -0700, Randy Dunlap wrote:
> Hi Sakari,
>
> On 8/18/23 02:51, Sakari Ailus wrote:
> > The Kconfig option that enables compiling camera sensor drivers is
> > VIDEO_CAMERA_SENSOR rather than MEDIA_CAMERA_SUPPORT as it was previously.
> > Fix this.
> >
> > Reported-by: Randy Dunlap <rdunlap@infradead.org>
> > Fixes: 7d3c7d2a2914 ("media: i2c: Add a camera sensor top level menu")
> > Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> > ---
> > since v1:
> >
> > - Also include MMP camera Kconfig fix.
> >
> > drivers/media/platform/marvell/Kconfig | 4 ++--
> > drivers/media/usb/em28xx/Kconfig | 4 ++--
> > drivers/media/usb/go7007/Kconfig | 2 +-
> > 3 files changed, 5 insertions(+), 5 deletions(-)
> >
>
> This v2 patch fixes a few more issues but there is still one nagging problem
> (2 versions of it, one with VIDEO_VIA_CAMERA=y and one with VIDEO_VIA_CAMERA=m):
>
> (1)
> WARNING: unmet direct dependencies detected for VIDEO_OV7670
> Depends on [n]: MEDIA_SUPPORT [=y] && VIDEO_DEV [=y] && VIDEO_CAMERA_SENSOR [=n]
> Selected by [y]:
> - VIDEO_VIA_CAMERA [=y] && MEDIA_SUPPORT [=y] && MEDIA_PLATFORM_SUPPORT [=y] && MEDIA_PLATFORM_DRIVERS [=y] && V4L_PLATFORM_DRIVERS [=y] && FB_VIA [=y] && VIDEO_DEV [=y]
>
> WARNING: unmet direct dependencies detected for VIDEO_OV7670
> Depends on [n]: MEDIA_SUPPORT [=y] && VIDEO_DEV [=y] && VIDEO_CAMERA_SENSOR [=n]
> Selected by [y]:
> - VIDEO_VIA_CAMERA [=y] && MEDIA_SUPPORT [=y] && MEDIA_PLATFORM_SUPPORT [=y] && MEDIA_PLATFORM_DRIVERS [=y] && V4L_PLATFORM_DRIVERS [=y] && FB_VIA [=y] && VIDEO_DEV [=y]
>
> (2)
> WARNING: unmet direct dependencies detected for VIDEO_OV7670
> Depends on [n]: MEDIA_SUPPORT [=y] && VIDEO_DEV [=m] && VIDEO_CAMERA_SENSOR [=n]
> Selected by [m]:
> - VIDEO_VIA_CAMERA [=m] && MEDIA_SUPPORT [=y] && MEDIA_PLATFORM_SUPPORT [=y] && MEDIA_PLATFORM_DRIVERS [=y] && V4L_PLATFORM_DRIVERS [=y] && FB_VIA [=m] && VIDEO_DEV [=m]
>
> WARNING: unmet direct dependencies detected for VIDEO_OV7670
> Depends on [n]: MEDIA_SUPPORT [=y] && VIDEO_DEV [=m] && VIDEO_CAMERA_SENSOR [=n]
> Selected by [m]:
> - VIDEO_VIA_CAMERA [=m] && MEDIA_SUPPORT [=y] && MEDIA_PLATFORM_SUPPORT [=y] && MEDIA_PLATFORM_DRIVERS [=y] && V4L_PLATFORM_DRIVERS [=y] && FB_VIA [=m] && VIDEO_DEV [=m]
>
> Let me know if you need full randconfig files for any of these.
> Thanks.
Thanks. These were indeed missing from the previous patch. I'll post a fix
to address these as well. I've grepped the Kconfigs and I couldn't find
more --- this one didn't have MEDIA_CAMERA_SUPPORT dependency as most of
the others did.
--
Sakari Ailus
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-08-21 11:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-18 9:51 [PATCH v2 1/1] media: v4l: usb: Use correct dependency for camera sensor drivers Sakari Ailus
2023-08-18 11:09 ` Sakari Ailus
2023-08-19 1:53 ` Randy Dunlap
2023-08-21 11:09 ` Sakari Ailus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox