linux-next: Fixes tag needs some work in the vfs-brauner tree

linux-next: Fixes tag needs some work in the vfs-brauner tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 327 bytes --]

Hi all,

In commit

  4b4fb74b1aa1 ("vfs, security: Fix automount superblock LSM init problem, preventing NFS sb sharing")

Fixes tag

  Fixes: 779df6a5480f ("NFS: Ensure security label is set for root inode)

has these problem(s):

  - Subject has leading but no trailing quotes

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the vfs-brauner tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 319 bytes --]

Hi all,

In commit

  03630940f622 ("fs: handle freezing from multiple devices")

Fixes tag

  Fixes: [1]: 288d8706abfc ("bdev: implement freeze and thaw holder operations") # no backport needed

has these problem(s):

  - No SHA1 recognised

The "[1]: " is unexpected.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the vfs-brauner tree

[Christian Brauner]

On Wed, Nov 08, 2023 at 08:02:41AM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   03630940f622 ("fs: handle freezing from multiple devices")
> 
> Fixes tag
> 
>   Fixes: [1]: 288d8706abfc ("bdev: implement freeze and thaw holder operations") # no backport needed
> 
> has these problem(s):
> 
>   - No SHA1 recognised
> 
> The "[1]: " is unexpected.

Fixed, thanks!

linux-next: Fixes tag needs some work in the vfs-brauner tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 333 bytes --]

Hi all,

In commit

  785de7deb1e5 ("9p: Fix missing set of NETFS_SREQ_HIT_EOF")

Fixes tag

  Fixes: 7e23bc911449 ("netfs: Speed up buffered reading")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: 0fda1f8c6bf8 ("netfs: Speed up buffered reading")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the vfs-brauner tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 723 bytes --]

Hi all,

In commit

  51ceeb1a8142 ("efs: fix the efs new mount api implementation")

Fixes tag

  Fixes: 39a6c668e4 efs: convert efs to use the new mount api.

has these problem(s):

  - SHA1 should be at least 12 digits long
    This can be fixed for the future by setting core.abbrev to 12 (or
    more) or (for git v2.11 or later) just making sure it is not set
    (or set to "auto").
  - Subject does not match target commit subject
    Just use
        git log -1 --format='Fixes: %h ("%s")'

Also, please keep all the commit message tags together at the end fo
the commit message.

Thus:

Fixes: 39a6c668e4e7 ("efs: convert efs to use the new mount api")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]