From: Andrew Morton <akpm@linux-foundation.org>
To: "Arnd Bergmann" <arnd@arndb.de>
Cc: "Stephen Rothwell" <sfr@rothwell.id.au>,
linux-next <linux-next@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Thomas Bogendoerfer" <tsbogend@alpha.franken.de>,
"David S. Miller" <davem@davemloft.net>,
sparclinux@vger.kernel.org, linux-mips@vger.kernel.org
Subject: Re: linux-next: lots of errors/warnings from the -Werror=missing-prototypes addition
Date: Wed, 29 Nov 2023 15:10:30 -0800 [thread overview]
Message-ID: <20231129151030.24b807f1d2b43be301a533b7@linux-foundation.org> (raw)
In-Reply-To: <ebb5b1a2-ed27-4a77-b62b-1d3f19bddd85@app.fastmail.com>
On Wed, 29 Nov 2023 23:51:04 +0100 "Arnd Bergmann" <arnd@arndb.de> wrote:
> I did all my testing with CONFIG_WERROR force-enabled, so
> the bit I missed here is that at least three architectures
> that are missing fixes also set -Werror: mips, sparc and alpha.
>
> How about adding a patch to no longer force -Werror for
> these?
These architectures are doing it wrong, aren't they? They should be
using the CONFIG_WERROR infrastructure rather than hard-coding it? If
so then sure, a standalone patch to clean that up sounds sounds
appropriate. I guess it should precede "Makefile.extrawarn: turn on
missing-prototypes globally".
next prev parent reply other threads:[~2023-11-29 23:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-29 20:58 linux-next: lots of errors/warnings from the -Werror=missing-prototypes addition Stephen Rothwell
2023-11-29 21:10 ` Andrew Morton
2023-11-29 22:51 ` Arnd Bergmann
2023-11-29 23:10 ` Andrew Morton [this message]
2023-11-30 8:07 ` Arnd Bergmann
2023-11-30 16:19 ` Andrew Morton
2023-11-30 21:36 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231129151030.24b807f1d2b43be301a533b7@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@rothwell.id.au \
--cc=sparclinux@vger.kernel.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox