linux-next: build warning after merge of the pci-current tree

linux-next: build warning after merge of the pci-current tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 940 bytes --]

Hi Bjorn,

After merging the pci-current tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/acpi/pci_bind.c: In function 'acpi_pci_unbind':
drivers/acpi/pci_bind.c:48:2: warning: passing argument 1 of 'acpi_power_resource_unregister_device' from incompatible pointer type [enabled by default]
include/acpi/acpi_bus.h:346:6: note: expected 'struct device *' but argument is of type 'struct pci_dev *'
drivers/acpi/pci_bind.c: In function 'acpi_pci_bind':
drivers/acpi/pci_bind.c:75:2: warning: passing argument 1 of 'acpi_power_resource_register_device' from incompatible pointer type [enabled by default]
include/acpi/acpi_bus.h:345:5: note: expected 'struct device *' but argument is of type 'struct pci_dev *'

Introduced by commit 942dd0958697 ("ACPI/PCI: Notify PCI devices when
their power resource is turned on").
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

linux-next: build warning after merge of the pci-current tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 626 bytes --]

Hi Bjorn,

After merging the pci-current tree, today's linux-next build
(arm_multi_v7_defconfig) produced this warning:

drivers/pci/probe.c: In function 'pci_read_bridge_mmio_pref':
drivers/pci/probe.c:438:5: warning: left shift count >= width of type
     base |= ((dma_addr_t) mem_base_hi) << 32;
     ^
drivers/pci/probe.c:439:5: warning: left shift count >= width of type
     limit |= ((dma_addr_t) mem_limit_hi) << 32;
     ^

Introduced by commit 3a02517d5e2a ("PCI: Support 64-bit bridge windows
if we have 64-bit dma_addr_t").

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

linux-next: build warning after merge of the pci-current tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 557 bytes --]

Hi all,

After merging the pci-current tree, today's linux-next build (htmldocs)
produced this warning:

drivers/pci/bus.c:440: warning: Function parameter or struct member 'top' not described in 'pci_walk_bus'
drivers/pci/bus.c:440: warning: Function parameter or struct member 'cb' not described in 'pci_walk_bus'
drivers/pci/bus.c:440: warning: Function parameter or struct member 'userdata' not described in 'pci_walk_bus'

Introduced by commit

  69fb843fdbd9 ("PCI/ASPM: Fix deadlock when enabling ASPM")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the pci-current tree

[Johan Hovold]

[-- Attachment #1: Type: text/plain, Size: 1619 bytes --]

On Wed, Jan 31, 2024 at 12:58:43PM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the pci-current tree, today's linux-next build (htmldocs)
> produced this warning:
> 
> drivers/pci/bus.c:440: warning: Function parameter or struct member 'top' not described in 'pci_walk_bus'
> drivers/pci/bus.c:440: warning: Function parameter or struct member 'cb' not described in 'pci_walk_bus'
> drivers/pci/bus.c:440: warning: Function parameter or struct member 'userdata' not described in 'pci_walk_bus'
> 
> Introduced by commit
> 
>   69fb843fdbd9 ("PCI/ASPM: Fix deadlock when enabling ASPM")

Bah, I added a newline after the opening /** when moving a comment
without noticing that the kernel doc comment was malformed.

Bjorn, you could either remove that newline or squash the below patch
address this.

Johan


diff --git a/drivers/pci/bus.c b/drivers/pci/bus.c
index 116415f91195..826b5016a101 100644
--- a/drivers/pci/bus.c
+++ b/drivers/pci/bus.c
@@ -425,9 +425,9 @@ static void __pci_walk_bus(struct pci_bus *top, int (*cb)(struct pci_dev *, void
 
 /**
  *  pci_walk_bus - walk devices on/under bus, calling callback.
- *  @top      bus whose devices should be walked
- *  @cb       callback to be called for each device found
- *  @userdata arbitrary pointer to be passed to callback.
+ *  @top: bus whose devices should be walked
+ *  @cb: callback to be called for each device found
+ *  @userdata: arbitrary pointer to be passed to callback
  *
  *  Walk the given bus, including any bridged devices
  *  on buses under this bus.  Call the provided callback

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: linux-next: build warning after merge of the pci-current tree

[Bjorn Helgaas]

On Wed, Jan 31, 2024 at 08:42:41AM +0100, Johan Hovold wrote:
> On Wed, Jan 31, 2024 at 12:58:43PM +1100, Stephen Rothwell wrote:
> > Hi all,
> > 
> > After merging the pci-current tree, today's linux-next build (htmldocs)
> > produced this warning:
> > 
> > drivers/pci/bus.c:440: warning: Function parameter or struct member 'top' not described in 'pci_walk_bus'
> > drivers/pci/bus.c:440: warning: Function parameter or struct member 'cb' not described in 'pci_walk_bus'
> > drivers/pci/bus.c:440: warning: Function parameter or struct member 'userdata' not described in 'pci_walk_bus'
> > 
> > Introduced by commit
> > 
> >   69fb843fdbd9 ("PCI/ASPM: Fix deadlock when enabling ASPM")
> 
> Bah, I added a newline after the opening /** when moving a comment
> without noticing that the kernel doc comment was malformed.
> 
> Bjorn, you could either remove that newline or squash the below patch
> address this.

Squashed in, thanks!

> diff --git a/drivers/pci/bus.c b/drivers/pci/bus.c
> index 116415f91195..826b5016a101 100644
> --- a/drivers/pci/bus.c
> +++ b/drivers/pci/bus.c
> @@ -425,9 +425,9 @@ static void __pci_walk_bus(struct pci_bus *top, int (*cb)(struct pci_dev *, void
>  
>  /**
>   *  pci_walk_bus - walk devices on/under bus, calling callback.
> - *  @top      bus whose devices should be walked
> - *  @cb       callback to be called for each device found
> - *  @userdata arbitrary pointer to be passed to callback.
> + *  @top: bus whose devices should be walked
> + *  @cb: callback to be called for each device found
> + *  @userdata: arbitrary pointer to be passed to callback
>   *
>   *  Walk the given bus, including any bridged devices
>   *  on buses under this bus.  Call the provided callback