From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A3F8165C for ; Wed, 14 Feb 2024 01:09:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707872993; cv=none; b=j/eL8kPzJUPTvc5/HuVjb5SCThVhz87wTaHh0+UpuI3M7VTNR6BysGKwkr2bVd8UnMqn5T7WMpTw7+In3+3k64J4yr358jIW6NFjbBTrOPx7afkkUqEzYBPlQBduc44ICgGbiLVfoNcPgOpKGcjH69rtw5JyCljcTJoeJhXFbiQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707872993; c=relaxed/simple; bh=0++dCt5M+qrC+v7l1aP0aX+LFZP9kiitQYr/pwq70xs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hfZKowCCvi7ahSqpeSI94vRl10IkywyVB1xLGaABvYE4gNdefiGhO8iomhFMqdbl7axKSIg/Mvi8qv8CYgJupneXiGaQjkzA6M9IzoowN6mhvg6mKBQS/cSiwckYR0JS9gxm521dDHeTkJg3xA6MSuRzlpu99bqG3t8G5VmspG0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=kaidmu5M; arc=none smtp.client-ip=209.85.210.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="kaidmu5M" Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-6e0a37751cbso2580073b3a.2 for ; Tue, 13 Feb 2024 17:09:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1707872991; x=1708477791; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ySw3Cfl6z732P4TVdG3DLSaryHos4nnJoKBVe6EUUAI=; b=kaidmu5MxkGYyBRJ/5tAyXQ+sHStJ2RN+OTZ6XcENx9HokUcAGRQyG82vHZ+j9HWID FFC8UrK1ZCvvajGzWp4SieqwVnO/IJQZahVNY+PD1feiH8oTYsKmuQNSmA698J2z1jK7 5liZc5jJtFPh3diYvWrTZINYnIEN4wzI1u1zw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707872991; x=1708477791; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ySw3Cfl6z732P4TVdG3DLSaryHos4nnJoKBVe6EUUAI=; b=I9Hi/riX148aO40RAkC6JP4OZGK4NWkX/i2nCF/2LOIK2qPDUEdVl1AMWFwByrxBI9 Qc6MlXx6of6ht0MuoLW1xm+BgoCy4OQH7fI0kFyWGzJ/QOt8czAJDjVBCKZpI4ymnpeS 4a5v+IG5SM2FOT1m+jkzfn3B7oivU5xUIW9ahIMM2iEjpg+PgllL73lltMmMfP53NemR YXn97KQItXANJmXOUNXUkEINvvmesh6ad9dsueXdZF4bQqXm7s/Uh6v9IX2V/shz17PK IfNBFgLNxXSJPUgC8/6oav7+DVMiGjRZoGdSbZWfoQbBSDLQgaSKGux5VuhSgmyvn9uJ S06w== X-Forwarded-Encrypted: i=1; AJvYcCWHQ2SqaWnPYRInsLeub7ahKGDZ067e7WJXdrGReo9irOt0u1jw7VMXKfVm6bus2IHIXCYQkwtHnOdIrHv20f6pncuE8iMhu7Icyg== X-Gm-Message-State: AOJu0YzPHdLglJJovrZXHLoxVu2M2BqJsA/kQ90aEytNilULK+tw49T7 2bs3DGUB3OqUmS+aro9GStuBV1TmO75nh7h6Cecp0Jkgrbjjz2va8016aryJ0q/rThHx7/AenNE = X-Google-Smtp-Source: AGHT+IG7FNeQRxjlB3Lep4iTRHs1fKy5fZqrJmPqxB8tuFX5rYKAsrvyT0TnrPV5XvF/6hNpR2iUrQ== X-Received: by 2002:a05:6a20:9597:b0:19e:a25e:a7f5 with SMTP id iu23-20020a056a20959700b0019ea25ea7f5mr1606402pzb.46.1707872991047; Tue, 13 Feb 2024 17:09:51 -0800 (PST) Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id sw16-20020a17090b2c9000b00296a23e407csm157804pjb.7.2024.02.13.17.09.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Feb 2024 17:09:50 -0800 (PST) Date: Tue, 13 Feb 2024 17:09:49 -0800 From: Kees Cook To: Kent Overstreet Cc: Stephen Rothwell , Linux Kernel Mailing List , Linux Next Mailing List , "Darrick J. Wong" Subject: Re: linux-next: build failure after merge of the bcachefs tree Message-ID: <202402131705.5C6517B9@keescook> References: <20240212105456.65194f29@canb.auug.org.au> <202402131606.A70D5347F3@keescook> Precedence: bulk X-Mailing-List: linux-next@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Feb 13, 2024 at 07:29:32PM -0500, Kent Overstreet wrote: > On Tue, Feb 13, 2024 at 04:16:34PM -0800, Kees Cook wrote: > > On Mon, Feb 12, 2024 at 10:54:56AM +1100, Stephen Rothwell wrote: > > > Hi all, > > > > > > After merging the bcachefs tree, today's linux-next build (x86_64 > > > allmodconfig) failed like this: > > > > > > ERROR: modpost: missing MODULE_LICENSE() in lib/thread_with_file.o > > > ERROR: modpost: "stdio_redirect_vprintf" [fs/bcachefs/bcachefs.ko] undefined! > > > ERROR: modpost: "thread_with_file_exit" [fs/bcachefs/bcachefs.ko] undefined! > > > ERROR: modpost: "run_thread_with_stdio" [fs/bcachefs/bcachefs.ko] undefined! > > > ERROR: modpost: "__darray_resize_slowpath" [fs/bcachefs/bcachefs.ko] undefined! > > > ERROR: modpost: "stdio_redirect_readline" [fs/bcachefs/bcachefs.ko] undefined! > > > ERROR: modpost: "run_thread_with_file" [fs/bcachefs/bcachefs.ko] undefined! > > > ERROR: modpost: "__darray_resize_slowpath" [lib/thread_with_file.ko] undefined! > > > > > > Caused by commit > > > > > > f894f9e5f0ad ("thread_with_file: Lift from bcachefs") > > > > > > I have used the version of bcachefs from next-20240206 again. > > > > I've mentioned this before, but this patch (and I assume others) was not > > posted to any mailing list before it appeared in -next. This process > > failure really needs to be fixed. Please post _everything_ going into > > your tree to at least linux-bcachefs mailing list, and for things that > > toss stuff into lib/ it really needs to go to lkml too and CCed to some > > subset of people who have touched lib/Kconfig, etc last. > > thread_wih_file definitely was; the patch moving it to lib/ might not > have, I'd have to check. > > We're having ongoing discussions among us fs developers about how to do > patch review, and the emerging consensus seems to be that we actually > don't want to spam the list with every patch (because not every patch is > interesting!) - we don't want the human-to-human interaction to be > drowned out on the list. Then at least CC lkml. Sending to a mailing list isn't optional -- this is required for Linux development. It's the basis for patch review, how b4 operates, how tooling finds threads to respond to, etc. It has to go _somewhere_ before it lands in -next. And using get_maintainers.pl is the right thing for this -- it'll find the people to CC based on the MAINTAINERS file, which means more than just file paths, there are "K:" entries too (e.g. I am CCed on anything using seccomp). This really needs to happen or you're going to be landing code that didn't get reviewed fully. > That doesn't mean we're not doing code review, though! We're > experimenting with different workflows, there's different thoughts out > there right now. If that's true, I would expect to see some "Reviewed-by:" tags, which I don't see on the patch I mentioned. The netdev folks have a significantly higher through-put on patches, and they check all these boxes. Their CI even verifies that emailed patches are corrected CCed to all expected get_maintainers.pl output, runs checkpatch, etc. Please please fix this process. > Regarding CCing people who have touched lib/Kconfig - you sure that's > the best way to get interested parties who'll do real review? I would > think review from the people actively working with and using that code > would be more valuable - that's Darrick, in this instance. Eh, get_maintainers is usually fine. But adding something new in lib/ means more than fs people are going to be using/changing it, so get their review early. -Kees -- Kees Cook