From: Christian Brauner <brauner@kernel.org>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Tycho Andersen <tycho@tycho.pizza>,
coverity-bot <keescook@chromium.org>,
Nicholas Piggin <npiggin@gmail.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Peng Zhang <zhangpeng.00@bytedance.com>,
Ard Biesheuvel <ardb@kernel.org>,
Luis Chamberlain <mcgrof@kernel.org>,
Heiko Carstens <hca@linux.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>,
Suren Baghdasaryan <surenb@google.com>,
Thomas Gleixner <tglx@linutronix.de>,
Mateusz Guzik <mjguzik@gmail.com>,
Dmitry Vyukov <dvyukov@google.com>,
Tycho Andersen <tandersen@netflix.com>,
Mike Christie <michael.christie@oracle.com>,
"Paul E. McKenney" <paulmck@kernel.org>,
linux-kernel@vger.kernel.org,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
linux-next@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: Coverity: __do_sys_pidfd_send_signal(): UNINIT
Date: Fri, 16 Feb 2024 13:37:49 +0100 [thread overview]
Message-ID: <20240216-polster-stopfen-7fafe753180f@brauner> (raw)
In-Reply-To: <20240214191801.GA27799@redhat.com>
On Wed, Feb 14, 2024 at 08:18:01PM +0100, Oleg Nesterov wrote:
> On 02/14, Tycho Andersen wrote:
> >
> > On Wed, Feb 14, 2024 at 06:55:55PM +0100, Oleg Nesterov wrote:
> > >
> > > We want to check the "flags" argument at the start, we do not want to
> > > delay the "case 0:" check until we have f.file (so that we can check
> > > f.file->f_flags).
> >
> > Fair point. I was thinking delaying it would make it simpler, but then
> > you have to free the file and it's less fast in the EINVAL case.
>
> plus we do not want to return, say, -EBADF if the "flags" argument is wrong.
>
> > I also don't have a strong opinion here.
>
> Neither me.
Or you know, we just don't care about this. ;)
In any case since tis is a false positive it's not urgent in any way. If
either of you cares enough about this then please just send me patch that
reorders the checks to please that tool. The specific way doesn't matter
to me as well as long as we don't pointlessly fdget()/fdput().
next prev parent reply other threads:[~2024-02-16 12:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-13 23:59 Coverity: __do_sys_pidfd_send_signal(): UNINIT coverity-bot
2024-02-14 0:18 ` Tycho Andersen
2024-02-14 9:03 ` Oleg Nesterov
2024-02-14 9:06 ` Oleg Nesterov
2024-02-14 14:18 ` Tycho Andersen
2024-02-14 17:55 ` Oleg Nesterov
2024-02-14 18:11 ` Tycho Andersen
2024-02-14 19:18 ` Oleg Nesterov
2024-02-16 12:37 ` Christian Brauner [this message]
2024-02-14 18:51 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240216-polster-stopfen-7fafe753180f@brauner \
--to=brauner@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=ardb@kernel.org \
--cc=bigeasy@linutronix.de \
--cc=dvyukov@google.com \
--cc=gustavo@embeddedor.com \
--cc=hca@linux.ibm.com \
--cc=keescook@chromium.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=michael.christie@oracle.com \
--cc=mjguzik@gmail.com \
--cc=npiggin@gmail.com \
--cc=oleg@redhat.com \
--cc=paulmck@kernel.org \
--cc=surenb@google.com \
--cc=tandersen@netflix.com \
--cc=tglx@linutronix.de \
--cc=tycho@tycho.pizza \
--cc=zhangpeng.00@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).