linux-next: build warnings after merge of the mm tree

linux-next: build warnings after merge of the mm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 635 bytes --]

Hi all,

After merging the mm tree, today's linux-next build (htmldocs) produced
these warnings:

Documentation/admin-guide/mm/damon/usage.rst:186: WARNING: undefined label: 'damon_design_confiurable_operations_set'
Documentation/admin-guide/mm/damon/usage.rst:369: WARNING: undefined label: 'damon_design_damos_quota_auto_tuning'

Introduced by commits

  afc858f0e6db ("Docs/mm/damon: move DAMON operation sets list from the usage to the design document")
  d50e871bd78b ("Docs/admin-guide/mm/damon/usage: document quota goal metric file")

from the mm-unstable branch of the mm tree.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warnings after merge of the mm tree

[SeongJae Park]

On Wed, 21 Feb 2024 16:27:45 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> --Sig_/rZSz2XyBy4/Li.uOi0DLWDM
> Content-Type: text/plain; charset=US-ASCII
> Content-Transfer-Encoding: quoted-printable
> 
> Hi all,
> 
> After merging the mm tree, today's linux-next build (htmldocs) produced
> these warnings:
> 
> Documentation/admin-guide/mm/damon/usage.rst:186: WARNING: undefined label:
>  'damon_design_confiurable_operations_set'
> Documentation/admin-guide/mm/damon/usage.rst:369: WARNING: undefined label:
>  'damon_design_damos_quota_auto_tuning'
> 
> Introduced by commits
> 
>   afc858f0e6db ("Docs/mm/damon: move DAMON operation sets list from the usage
> to the design document")
>   d50e871bd78b ("Docs/admin-guide/mm/damon/usage: document quota goal metric
> file")
> 
> from the mm-unstable branch of the mm tree.

Thank you for this nice report.  Just sent fixes:
https://lore.kernel.org/damon/20240221170852.55529-1-sj@kernel.org/


Thanks,
SJ

[...]

linux-next: build warnings after merge of the mm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 635 bytes --]

Hi all,

After merging the mm tree, today's linux-next build (htmldocs) produced
these warnings:

include/linux/mm_types.h:482: warning: Function parameter or struct member '_usable_1' not described in 'folio'
include/linux/mm_types.h:482: warning: Function parameter or struct member '_mapcount_1' not described in 'folio'
include/linux/mm_types.h:482: warning: Function parameter or struct member '_refcount_1' not described in 'folio'

Introduced by commit

  bbde3b621cf7 ("mm: let _folio_nr_pages overlay memcg_data in first tail page")

from the mm-unstable branch of the mm tree.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warnings after merge of the mm tree

[David Hildenbrand]

On 05.03.25 10:42, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the mm tree, today's linux-next build (htmldocs) produced
> these warnings:
> 
> include/linux/mm_types.h:482: warning: Function parameter or struct member '_usable_1' not described in 'folio'
> include/linux/mm_types.h:482: warning: Function parameter or struct member '_mapcount_1' not described in 'folio'
> include/linux/mm_types.h:482: warning: Function parameter or struct member '_refcount_1' not described in 'folio'
> 
> Introduced by commit
> 
>    bbde3b621cf7 ("mm: let _folio_nr_pages overlay memcg_data in first tail page")
> 
> from the mm-unstable branch of the mm tree.

Hm, we also don't document other dummy placeholders like:

* _flags_1
* _head_1
* __page_1

So I assume there must be one way to silence these warnings, let me dig ...

-- 
Cheers,

David / dhildenb

Re: linux-next: build warnings after merge of the mm tree

[David Hildenbrand]

On 05.03.25 10:53, David Hildenbrand wrote:
> On 05.03.25 10:42, Stephen Rothwell wrote:
>> Hi all,
>>
>> After merging the mm tree, today's linux-next build (htmldocs) produced
>> these warnings:
>>
>> include/linux/mm_types.h:482: warning: Function parameter or struct member '_usable_1' not described in 'folio'
>> include/linux/mm_types.h:482: warning: Function parameter or struct member '_mapcount_1' not described in 'folio'
>> include/linux/mm_types.h:482: warning: Function parameter or struct member '_refcount_1' not described in 'folio'
>>
>> Introduced by commit
>>
>>     bbde3b621cf7 ("mm: let _folio_nr_pages overlay memcg_data in first tail page")
>>
>> from the mm-unstable branch of the mm tree.
> 
> Hm, we also don't document other dummy placeholders like:
> 
> * _flags_1
> * _head_1
> * __page_1
> 
> So I assume there must be one way to silence these warnings, let me dig ...

Ah, likely because they are part of the "private:" section.

-- 
Cheers,

David / dhildenb

linux-next: build warnings after merge of the mm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 695 bytes --]

Hi all,

After merging the mm tree, today's linux-next build (htmldocs) produced
these warnings:

Documentation/core-api/refcount-vs-atomic.rst:90: WARNING: Title underline too short.

case 2) - non-"Read/Modify/Write" (RMW) ops with release ordering
------------------------------------------- [docutils]
Documentation/core-api/refcount-vs-atomic.rst:142: WARNING: Title underline too short.

case 6) - increment-based RMW ops with acquire ordering that return a value
----------------------------------------------------- [docutils]

Introduced by commit

  03b412c8b184 ("refcount: provide ops for cases when object's memory can be reused")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warnings after merge of the mm tree

[Suren Baghdasaryan]

On Sun, Feb 16, 2025 at 10:10 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> After merging the mm tree, today's linux-next build (htmldocs) produced
> these warnings:
>
> Documentation/core-api/refcount-vs-atomic.rst:90: WARNING: Title underline too short.
>
> case 2) - non-"Read/Modify/Write" (RMW) ops with release ordering
> ------------------------------------------- [docutils]
> Documentation/core-api/refcount-vs-atomic.rst:142: WARNING: Title underline too short.
>
> case 6) - increment-based RMW ops with acquire ordering that return a value
> ----------------------------------------------------- [docutils]
>
> Introduced by commit
>
>   03b412c8b184 ("refcount: provide ops for cases when object's memory can be reused")

Fix is posted at
https://lore.kernel.org/all/20250217161645.3137927-1-surenb@google.com/
Thanks!

>
> --
> Cheers,
> Stephen Rothwell

linux-next: build warnings after merge of the mm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 384 bytes --]

Hi all,

After merging the mm tree, today's linux-next build (htmldocs) produced
these warnings:

Documentation/kho/usage.rst:10: WARNING: undefined label: 'concepts' [ref.ref]
Documentation/kho/usage.rst:31: WARNING: undefined label: 'kho active phase' [ref.ref]

Introduced by commit

  cf8eba2f58e1 ("kexec: add documentation for KHO")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warnings after merge of the mm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1069 bytes --]

Hi all,

After merging the mm tree, today's linux-next build (x86_64 allmodconfig)
produced these warnings:

WARNING: modpost: vmlinux: section mismatch in reference: kho_reserve_scratch+0xa9 (section: .text.unlikely) -> memblock_alloc_try_nid (section: .init.text)
WARNING: modpost: vmlinux: section mismatch in reference: kho_reserve_scratch+0xd5 (section: .text.unlikely) -> scratch_size (section: .init.text)
WARNING: modpost: vmlinux: section mismatch in reference: kho_reserve_scratch+0xe9 (section: .text.unlikely) -> memblock_phys_alloc_range (section: .init.text)
WARNING: modpost: vmlinux: section mismatch in reference: kho_reserve_scratch+0x1b4 (section: .text.unlikely) -> scratch_size (section: .init.text)
WARNING: modpost: vmlinux: section mismatch in reference: kho_reserve_scratch+0x1d1 (section: .text.unlikely) -> memblock_alloc_range_nid (section: .init.text)

Introduced by commit

  5a86a3085351 ("kexec: add Kexec HandOver (KHO) generation helpers")

from the mm-unstable branch of the mm tree.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warnings after merge of the mm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 808 bytes --]

Hi all,

After merging the mm tree, today's linux-next build (htmldocs)
produced these warnings:

Documentation/core-api/kernel-api:108: lib/sort.c:206: ERROR: Unexpected indentation.
Documentation/core-api/kernel-api:108: lib/sort.c:207: WARNING: Block quote ends without a blank line; unexpected unindent.
Documentation/core-api/kernel-api:111: lib/list_sort.c:114: ERROR: Unexpected indentation.
Documentation/core-api/kernel-api:111: lib/list_sort.c:115: WARNING: Block quote ends without a blank line; unexpected unindent.

Introduced by commits

  504556ace988 ("lib/sort: clarify comparison function requirements in sort_r()")
  d61e15e52019 ("lib/list_sort: clarify comparison function requirements in list_sort()")

from the mm-nonmm-unstable branch.
-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warnings after merge of the mm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 577 bytes --]

Hi all,

After merging the mm tree, today's linux-next build (htmldocs) produced
these warnings:

fs/inode.c:242: warning: expecting prototype for inode_init_always(). Prototype was for inode_init_always_gfp() instead
security/security.c:749: warning: Function parameter or struct member 'gfp' not described in 'lsm_inode_alloc'
security/security.c:1689: warning: Function parameter or struct member 'gfp' not described in 'security_inode_alloc'

Introduced by commit

  3346ada04cf5 ("bcachefs: do not use PF_MEMALLOC_NORECLAIM")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warnings after merge of the mm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 416 bytes --]

Hi all,

After merging the mm tree, today's linux-next build (htmldocs) produced
these warnings:

Documentation/admin-guide/sysctl/vm.rst:278: ERROR: Unexpected indentation.
Documentation/admin-guide/sysctl/vm.rst:279: WARNING: Block quote ends without a blank line; unexpected unindent.

Introduced by commit

  2cba7831f62c ("docs: mm: add enable_soft_offline sysctl")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warnings after merge of the mm tree

[Andrew Morton]

On Mon, 1 Jul 2024 18:49:12 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> Hi all,
> 
> After merging the mm tree, today's linux-next build (htmldocs) produced
> these warnings:
> 
> Documentation/admin-guide/sysctl/vm.rst:278: ERROR: Unexpected indentation.
> Documentation/admin-guide/sysctl/vm.rst:279: WARNING: Block quote ends without a blank line; unexpected unindent.
> 
> Introduced by commit
> 
>   2cba7831f62c ("docs: mm: add enable_soft_offline sysctl")

Well that's annoying.

@@ -267,6 +268,37 @@ used::
 These are informational only.  They do not mean that anything is wrong
 with your system.  To disable them, echo 4 (bit 2) into drop_caches.
 
+enable_soft_offline
+===================
+Correctable memory errors are very common on servers. Soft-offline is kernel's
+solution for memory pages having (excessive) corrected memory errors.
+
+For different types of page, soft-offline has different behaviors / costs.
+- For a raw error page, soft-offline migrates the in-use page's content to
+  a new raw page.
+- For a page that is part of a transparent hugepage, soft-offline splits the
+  transparent hugepage into raw pages, then migrates only the raw error page.
+  As a result, user is transparently backed by 1 less hugepage, impacting
+  memory access performance.
+- For a page that is part of a HugeTLB hugepage, soft-offline first migrates
+  the entire HugeTLB hugepage, during which a free hugepage will be consumed
+  as migration target.  Then the original hugepage is dissolved into raw
+  pages without compensation, reducing the capacity of the HugeTLB pool by 1.
+
+ ...

This seems a reasonable thing to do so there's probably some way in
which to do it, but a bit of grepping failed to turn up examples in
existing .rst files.  Can someone please suggest?

Re: linux-next: build warnings after merge of the mm tree

[Jiaqi Yan]

On Mon, Jul 1, 2024 at 8:15 PM Andrew Morton <akpm@linux-foundation.org> wrote:
>
> On Mon, 1 Jul 2024 18:49:12 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> > Hi all,
> >
> > After merging the mm tree, today's linux-next build (htmldocs) produced
> > these warnings:
> >
> > Documentation/admin-guide/sysctl/vm.rst:278: ERROR: Unexpected indentation.
> > Documentation/admin-guide/sysctl/vm.rst:279: WARNING: Block quote ends without a blank line; unexpected unindent.
> >
> > Introduced by commit
> >
> >   2cba7831f62c ("docs: mm: add enable_soft_offline sysctl")
>
> Well that's annoying.
>
> @@ -267,6 +268,37 @@ used::
>  These are informational only.  They do not mean that anything is wrong
>  with your system.  To disable them, echo 4 (bit 2) into drop_caches.
>
> +enable_soft_offline
> +===================
> +Correctable memory errors are very common on servers. Soft-offline is kernel's
> +solution for memory pages having (excessive) corrected memory errors.
> +
> +For different types of page, soft-offline has different behaviors / costs.
> +- For a raw error page, soft-offline migrates the in-use page's content to
> +  a new raw page.
> +- For a page that is part of a transparent hugepage, soft-offline splits the
> +  transparent hugepage into raw pages, then migrates only the raw error page.
> +  As a result, user is transparently backed by 1 less hugepage, impacting
> +  memory access performance.
> +- For a page that is part of a HugeTLB hugepage, soft-offline first migrates
> +  the entire HugeTLB hugepage, during which a free hugepage will be consumed
> +  as migration target.  Then the original hugepage is dissolved into raw
> +  pages without compensation, reducing the capacity of the HugeTLB pool by 1.
> +
> + ...
>
> This seems a reasonable thing to do so there's probably some way in
> which to do it, but a bit of grepping failed to turn up examples in
> existing .rst files.  Can someone please suggest?

It seems I need to add some blank lines according to [1], especially
to add a blank line above the first list item:

diff --git a/Documentation/admin-guide/sysctl/vm.rst
b/Documentation/admin-guide/sysctl/vm.rst
index 75e22137d849..74b4c0f65213 100644
--- a/Documentation/admin-guide/sysctl/vm.rst
+++ b/Documentation/admin-guide/sysctl/vm.rst
@@ -274,12 +274,15 @@ Correctable memory errors are very common on
servers. Soft-offline is kernel's
 solution for memory pages having (excessive) corrected memory errors.

 For different types of page, soft-offline has different behaviors / costs.
+
 - For a raw error page, soft-offline migrates the in-use page's content to
   a new raw page.
+
 - For a page that is part of a transparent hugepage, soft-offline splits the
   transparent hugepage into raw pages, then migrates only the raw error page.
   As a result, user is transparently backed by 1 less hugepage, impacting
   memory access performance.
+
 - For a page that is part of a HugeTLB hugepage, soft-offline first migrates
   the entire HugeTLB hugepage, during which a free hugepage will be consumed
   as migration target.  Then the original hugepage is dissolved into raw

But I am having trouble testing the build, so wasn't able to validate
the change above:

Documentation$ make
/tools/net/ynl/ynl-gen-rst.py -o
/Documentation/networking/netlink_spec/index.rst -x
make: /tools/net/ynl/ynl-gen-rst.py: No such file or directory
make: *** [Makefile:113:
/Documentation/networking/netlink_spec/index.rst] Error 127

[1] https://docutils.sourceforge.io/docs/ref/rst/restructuredtext.html#bullet-lists

Re: linux-next: build warnings after merge of the mm tree

[Jiaqi Yan]

On Mon, Jul 1, 2024 at 9:15 PM Jiaqi Yan <jiaqiyan@google.com> wrote:
>
> On Mon, Jul 1, 2024 at 8:15 PM Andrew Morton <akpm@linux-foundation.org> wrote:
> >
> > On Mon, 1 Jul 2024 18:49:12 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > > Hi all,
> > >
> > > After merging the mm tree, today's linux-next build (htmldocs) produced
> > > these warnings:
> > >
> > > Documentation/admin-guide/sysctl/vm.rst:278: ERROR: Unexpected indentation.
> > > Documentation/admin-guide/sysctl/vm.rst:279: WARNING: Block quote ends without a blank line; unexpected unindent.
> > >
> > > Introduced by commit
> > >
> > >   2cba7831f62c ("docs: mm: add enable_soft_offline sysctl")
> >
> > Well that's annoying.
> >
> > @@ -267,6 +268,37 @@ used::
> >  These are informational only.  They do not mean that anything is wrong
> >  with your system.  To disable them, echo 4 (bit 2) into drop_caches.
> >
> > +enable_soft_offline
> > +===================
> > +Correctable memory errors are very common on servers. Soft-offline is kernel's
> > +solution for memory pages having (excessive) corrected memory errors.
> > +
> > +For different types of page, soft-offline has different behaviors / costs.
> > +- For a raw error page, soft-offline migrates the in-use page's content to
> > +  a new raw page.
> > +- For a page that is part of a transparent hugepage, soft-offline splits the
> > +  transparent hugepage into raw pages, then migrates only the raw error page.
> > +  As a result, user is transparently backed by 1 less hugepage, impacting
> > +  memory access performance.
> > +- For a page that is part of a HugeTLB hugepage, soft-offline first migrates
> > +  the entire HugeTLB hugepage, during which a free hugepage will be consumed
> > +  as migration target.  Then the original hugepage is dissolved into raw
> > +  pages without compensation, reducing the capacity of the HugeTLB pool by 1.
> > +
> > + ...
> >
> > This seems a reasonable thing to do so there's probably some way in
> > which to do it, but a bit of grepping failed to turn up examples in
> > existing .rst files.  Can someone please suggest?
>
> It seems I need to add some blank lines according to [1], especially
> to add a blank line above the first list item:
>
> diff --git a/Documentation/admin-guide/sysctl/vm.rst
> b/Documentation/admin-guide/sysctl/vm.rst
> index 75e22137d849..74b4c0f65213 100644
> --- a/Documentation/admin-guide/sysctl/vm.rst
> +++ b/Documentation/admin-guide/sysctl/vm.rst
> @@ -274,12 +274,15 @@ Correctable memory errors are very common on
> servers. Soft-offline is kernel's
>  solution for memory pages having (excessive) corrected memory errors.
>
>  For different types of page, soft-offline has different behaviors / costs.
> +
>  - For a raw error page, soft-offline migrates the in-use page's content to
>    a new raw page.
> +
>  - For a page that is part of a transparent hugepage, soft-offline splits the
>    transparent hugepage into raw pages, then migrates only the raw error page.
>    As a result, user is transparently backed by 1 less hugepage, impacting
>    memory access performance.
> +
>  - For a page that is part of a HugeTLB hugepage, soft-offline first migrates
>    the entire HugeTLB hugepage, during which a free hugepage will be consumed
>    as migration target.  Then the original hugepage is dissolved into raw
>
> But I am having trouble testing the build, so wasn't able to validate
> the change above:
>
> Documentation$ make
> /tools/net/ynl/ynl-gen-rst.py -o
> /Documentation/networking/netlink_spec/index.rst -x
> make: /tools/net/ynl/ynl-gen-rst.py: No such file or directory
> make: *** [Makefile:113:
> /Documentation/networking/netlink_spec/index.rst] Error 127

I tried another way: make htmldocs at repo's root directory. Although
I wasn't able to finish the make process,

- without the blank lines:

  Documentation/admin-guide/sysctl/vm.rst:278: ERROR: Unexpected indentation.
  Documentation/admin-guide/sysctl/vm.rst:279: WARNING: Block quote
ends without a blank line; unexpected unindent.

- with the blank lines added, the ERROR and WARNING in vm/rst are gone.

Andrew and Stephen, what is the best way to post the fix for this?
Should I send out a v8 of the patch with the blank lines added? or a
standalone commit for this fix?

>
> [1] https://docutils.sourceforge.io/docs/ref/rst/restructuredtext.html#bullet-lists

Re: linux-next: build warnings after merge of the mm tree

[Andrew Morton]

On Mon, 1 Jul 2024 21:33:20 -0700 Jiaqi Yan <jiaqiyan@google.com> wrote:

> > > This seems a reasonable thing to do so there's probably some way in
> > > which to do it, but a bit of grepping failed to turn up examples in
> > > existing .rst files.  Can someone please suggest?
> >
> > It seems I need to add some blank lines according to [1], especially
> > to add a blank line above the first list item:
> >
> > diff --git a/Documentation/admin-guide/sysctl/vm.rst
> > b/Documentation/admin-guide/sysctl/vm.rst
> > index 75e22137d849..74b4c0f65213 100644
> > --- a/Documentation/admin-guide/sysctl/vm.rst
> > +++ b/Documentation/admin-guide/sysctl/vm.rst
> > @@ -274,12 +274,15 @@ Correctable memory errors are very common on
> > servers. Soft-offline is kernel's
> >  solution for memory pages having (excessive) corrected memory errors.
> >
> >  For different types of page, soft-offline has different behaviors / costs.
> > +
> >  - For a raw error page, soft-offline migrates the in-use page's content to
> >    a new raw page.
> > +
> >  - For a page that is part of a transparent hugepage, soft-offline splits the
> >    transparent hugepage into raw pages, then migrates only the raw error page.
> >    As a result, user is transparently backed by 1 less hugepage, impacting
> >    memory access performance.
> > +
> >  - For a page that is part of a HugeTLB hugepage, soft-offline first migrates
> >    the entire HugeTLB hugepage, during which a free hugepage will be consumed
> >    as migration target.  Then the original hugepage is dissolved into raw
> >
> > But I am having trouble testing the build, so wasn't able to validate
> > the change above:
> >
> > Documentation$ make
> > /tools/net/ynl/ynl-gen-rst.py -o
> > /Documentation/networking/netlink_spec/index.rst -x
> > make: /tools/net/ynl/ynl-gen-rst.py: No such file or directory
> > make: *** [Makefile:113:
> > /Documentation/networking/netlink_spec/index.rst] Error 127

You need to install all sorts of whacky system and python packages. 
The (failed) build process should guide you through this.

> I tried another way: make htmldocs at repo's root directory. Although
> I wasn't able to finish the make process,
> 
> - without the blank lines:
> 
>   Documentation/admin-guide/sysctl/vm.rst:278: ERROR: Unexpected indentation.
>   Documentation/admin-guide/sysctl/vm.rst:279: WARNING: Block quote
> ends without a blank line; unexpected unindent.
> 
> - with the blank lines added, the ERROR and WARNING in vm/rst are gone.
> 
> Andrew and Stephen, what is the best way to post the fix for this?
> Should I send out a v8 of the patch with the blank lines added? or a
> standalone commit for this fix?

I added your fix, thanks.

Re: linux-next: build warnings after merge of the mm tree

[Jiaqi Yan]

On Mon, Jul 1, 2024 at 11:18 PM Andrew Morton <akpm@linux-foundation.org> wrote:
>
> On Mon, 1 Jul 2024 21:33:20 -0700 Jiaqi Yan <jiaqiyan@google.com> wrote:
>
> > > > This seems a reasonable thing to do so there's probably some way in
> > > > which to do it, but a bit of grepping failed to turn up examples in
> > > > existing .rst files.  Can someone please suggest?
> > >
> > > It seems I need to add some blank lines according to [1], especially
> > > to add a blank line above the first list item:
> > >
> > > diff --git a/Documentation/admin-guide/sysctl/vm.rst
> > > b/Documentation/admin-guide/sysctl/vm.rst
> > > index 75e22137d849..74b4c0f65213 100644
> > > --- a/Documentation/admin-guide/sysctl/vm.rst
> > > +++ b/Documentation/admin-guide/sysctl/vm.rst
> > > @@ -274,12 +274,15 @@ Correctable memory errors are very common on
> > > servers. Soft-offline is kernel's
> > >  solution for memory pages having (excessive) corrected memory errors.
> > >
> > >  For different types of page, soft-offline has different behaviors / costs.
> > > +
> > >  - For a raw error page, soft-offline migrates the in-use page's content to
> > >    a new raw page.
> > > +
> > >  - For a page that is part of a transparent hugepage, soft-offline splits the
> > >    transparent hugepage into raw pages, then migrates only the raw error page.
> > >    As a result, user is transparently backed by 1 less hugepage, impacting
> > >    memory access performance.
> > > +
> > >  - For a page that is part of a HugeTLB hugepage, soft-offline first migrates
> > >    the entire HugeTLB hugepage, during which a free hugepage will be consumed
> > >    as migration target.  Then the original hugepage is dissolved into raw
> > >
> > > But I am having trouble testing the build, so wasn't able to validate
> > > the change above:
> > >
> > > Documentation$ make
> > > /tools/net/ynl/ynl-gen-rst.py -o
> > > /Documentation/networking/netlink_spec/index.rst -x
> > > make: /tools/net/ynl/ynl-gen-rst.py: No such file or directory
> > > make: *** [Makefile:113:
> > > /Documentation/networking/netlink_spec/index.rst] Error 127
>
> You need to install all sorts of whacky system and python packages.
> The (failed) build process should guide you through this.
>
> > I tried another way: make htmldocs at repo's root directory. Although
> > I wasn't able to finish the make process,
> >
> > - without the blank lines:
> >
> >   Documentation/admin-guide/sysctl/vm.rst:278: ERROR: Unexpected indentation.
> >   Documentation/admin-guide/sysctl/vm.rst:279: WARNING: Block quote
> > ends without a blank line; unexpected unindent.
> >
> > - with the blank lines added, the ERROR and WARNING in vm/rst are gone.
> >
> > Andrew and Stephen, what is the best way to post the fix for this?
> > Should I send out a v8 of the patch with the blank lines added? or a
> > standalone commit for this fix?
>
> I added your fix, thanks.

Ah, sorry Andrew, I should sent out this diff, as there are more blank
lines needed:

diff --git a/Documentation/admin-guide/sysctl/vm.rst
b/Documentation/admin-guide/sysctl/vm.rst
index 75e22137d849..f48eaa98d22d 100644
--- a/Documentation/admin-guide/sysctl/vm.rst
+++ b/Documentation/admin-guide/sysctl/vm.rst
@@ -274,12 +274,15 @@ Correctable memory errors are very common on
servers. Soft-offline is kernel's
 solution for memory pages having (excessive) corrected memory errors.

 For different types of page, soft-offline has different behaviors / costs.
+
 - For a raw error page, soft-offline migrates the in-use page's content to
   a new raw page.
+
 - For a page that is part of a transparent hugepage, soft-offline splits the
   transparent hugepage into raw pages, then migrates only the raw error page.
   As a result, user is transparently backed by 1 less hugepage, impacting
   memory access performance.
+
 - For a page that is part of a HugeTLB hugepage, soft-offline first migrates
   the entire HugeTLB hugepage, during which a free hugepage will be consumed
   as migration target.  Then the original hugepage is dissolved into raw
@@ -296,8 +299,11 @@ the request to soft offline the pages.  Its
default value is 1.

 It is worth mentioning that after setting enable_soft_offline to 0, the
 following requests to soft offline pages will not be performed:
+
 - Request to soft offline pages from RAS Correctable Errors Collector.
+
 - On ARM, the request to soft offline pages from GHES driver.
+
 - On PARISC, the request to soft offline pages from Page Deallocation Table.

 extfrag_threshold

Re: linux-next: build warnings after merge of the mm tree

[SeongJae Park]

Hello Jiaqi,


On Mon, 1 Jul 2024 23:37:55 -0700 Jiaqi Yan <jiaqiyan@google.com> wrote:

> On Mon, Jul 1, 2024 at 11:18 PM Andrew Morton <akpm@linux-foundation.org> wrote:
> >
> > On Mon, 1 Jul 2024 21:33:20 -0700 Jiaqi Yan <jiaqiyan@google.com> wrote:
> >
> > > > > This seems a reasonable thing to do so there's probably some way in
> > > > > which to do it, but a bit of grepping failed to turn up examples in
> > > > > existing .rst files.  Can someone please suggest?
> > > >
> > > > It seems I need to add some blank lines according to [1], especially
> > > > to add a blank line above the first list item:

According to my understanding and testing on my machine, it seems we need blank
lines only before and after the blocks.

[...]
> 
> Ah, sorry Andrew, I should sent out this diff, as there are more blank
> lines needed:
> 
> diff --git a/Documentation/admin-guide/sysctl/vm.rst
> b/Documentation/admin-guide/sysctl/vm.rst
> index 75e22137d849..f48eaa98d22d 100644
> --- a/Documentation/admin-guide/sysctl/vm.rst
> +++ b/Documentation/admin-guide/sysctl/vm.rst
> @@ -274,12 +274,15 @@ Correctable memory errors are very common on
> servers. Soft-offline is kernel's
>  solution for memory pages having (excessive) corrected memory errors.
> 
>  For different types of page, soft-offline has different behaviors / costs.
> +

So, this was needed to make 'make htmldocs' quiet on my machine.

>  - For a raw error page, soft-offline migrates the in-use page's content to
>    a new raw page.
> +
>  - For a page that is part of a transparent hugepage, soft-offline splits the
>    transparent hugepage into raw pages, then migrates only the raw error page.
>    As a result, user is transparently backed by 1 less hugepage, impacting
>    memory access performance.
> +

But above two blank lines were not really needed to make 'make htmldocs' calm,
at least on my setup.  Many other documents also don't have this kind of blank
line.

>  - For a page that is part of a HugeTLB hugepage, soft-offline first migrates
>    the entire HugeTLB hugepage, during which a free hugepage will be consumed
>    as migration target.  Then the original hugepage is dissolved into raw
> @@ -296,8 +299,11 @@ the request to soft offline the pages.  Its
> default value is 1.
> 
>  It is worth mentioning that after setting enable_soft_offline to 0, the
>  following requests to soft offline pages will not be performed:
> +

Interestingly, 'make htmldocs' didn't complain even if I don't put this blank
line.  But for consistency (see the beginning of sysctl/vm.rst), I think having
this would be good.

>  - Request to soft offline pages from RAS Correctable Errors Collector.
> +
>  - On ARM, the request to soft offline pages from GHES driver.
> +

Again, same to the reason above, it seems above two blank lines are not really
needed.

>  - On PARISC, the request to soft offline pages from Page Deallocation Table.
> 
>  extfrag_threshold
> 

I have no strong opinion about these, though.  Having four more blank lines
that might unnecessary is obviously no problem.


Thanks,
SJ

Re: linux-next: build warnings after merge of the mm tree

[Jiaqi Yan]

On Tue, Jul 2, 2024 at 4:10 PM SeongJae Park <sj@kernel.org> wrote:
>
> Hello Jiaqi,
>
>
> On Mon, 1 Jul 2024 23:37:55 -0700 Jiaqi Yan <jiaqiyan@google.com> wrote:
>
> > On Mon, Jul 1, 2024 at 11:18 PM Andrew Morton <akpm@linux-foundation.org> wrote:
> > >
> > > On Mon, 1 Jul 2024 21:33:20 -0700 Jiaqi Yan <jiaqiyan@google.com> wrote:
> > >
> > > > > > This seems a reasonable thing to do so there's probably some way in
> > > > > > which to do it, but a bit of grepping failed to turn up examples in
> > > > > > existing .rst files.  Can someone please suggest?
> > > > >
> > > > > It seems I need to add some blank lines according to [1], especially
> > > > > to add a blank line above the first list item:
>
> According to my understanding and testing on my machine, it seems we need blank
> lines only before and after the blocks.

Yes, as stated in [1], "The blank line above the first list item is
required; blank lines between list items (such as below this
paragraph) are optional."

>
> [...]
> >
> > Ah, sorry Andrew, I should sent out this diff, as there are more blank
> > lines needed:
> >
> > diff --git a/Documentation/admin-guide/sysctl/vm.rst
> > b/Documentation/admin-guide/sysctl/vm.rst
> > index 75e22137d849..f48eaa98d22d 100644
> > --- a/Documentation/admin-guide/sysctl/vm.rst
> > +++ b/Documentation/admin-guide/sysctl/vm.rst
> > @@ -274,12 +274,15 @@ Correctable memory errors are very common on
> > servers. Soft-offline is kernel's
> >  solution for memory pages having (excessive) corrected memory errors.
> >
> >  For different types of page, soft-offline has different behaviors / costs.
> > +
>
> So, this was needed to make 'make htmldocs' quiet on my machine.

Absolutely.

>
> >  - For a raw error page, soft-offline migrates the in-use page's content to
> >    a new raw page.
> > +
> >  - For a page that is part of a transparent hugepage, soft-offline splits the
> >    transparent hugepage into raw pages, then migrates only the raw error page.
> >    As a result, user is transparently backed by 1 less hugepage, impacting
> >    memory access performance.
> > +
>
> But above two blank lines were not really needed to make 'make htmldocs' calm,
> at least on my setup.  Many other documents also don't have this kind of blank
> line.

Yes, they are optional.

>
> >  - For a page that is part of a HugeTLB hugepage, soft-offline first migrates
> >    the entire HugeTLB hugepage, during which a free hugepage will be consumed
> >    as migration target.  Then the original hugepage is dissolved into raw
> > @@ -296,8 +299,11 @@ the request to soft offline the pages.  Its
> > default value is 1.
> >
> >  It is worth mentioning that after setting enable_soft_offline to 0, the
> >  following requests to soft offline pages will not be performed:
> > +
>
> Interestingly, 'make htmldocs' didn't complain even if I don't put this blank

In fact, without this blank line, even though make htmldocs doesn't
throw ERROR or WARNING, the output html file is broken: there is no
bullet point for the list items below.

> line.  But for consistency (see the beginning of sysctl/vm.rst), I think having
> this would be good.

Agreed.

>
> >  - Request to soft offline pages from RAS Correctable Errors Collector.
> > +
> >  - On ARM, the request to soft offline pages from GHES driver.
> > +
>
> Again, same to the reason above, it seems above two blank lines are not really
> needed.

Yep, optional again. I mainly just want to be consistent.

>
> >  - On PARISC, the request to soft offline pages from Page Deallocation Table.
> >
> >  extfrag_threshold
> >
>
> I have no strong opinion about these, though.  Having four more blank lines
> that might unnecessary is obviously no problem.
>
>
> Thanks,
> SJ

linux-next: build warnings after merge of the mm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 908 bytes --]

Hi all,

After merging the mm tree, today's linux-next build (arm
multi_v7_defconfig) produced these warnings:

fs/proc/task_mmu.c: In function 'do_procmap_query':
fs/proc/task_mmu.c:598:48: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
  598 |         if (karg.vma_name_size && copy_to_user((void __user *)karg.vma_name_addr,
      |                                                ^
fs/proc/task_mmu.c:605:48: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
  605 |         if (karg.build_id_size && copy_to_user((void __user *)karg.build_id_addr,
      |                                                ^

Introduced by commits

  3757be498749 ("fs/procfs: implement efficient VMA querying API for /proc/<pid>/maps")
  df789ce1eb90 ("fs/procfs: add build ID fetching to PROCMAP_QUERY API")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warnings after merge of the mm tree

[Andrii Nakryiko]

On Sun, Jun 30, 2024 at 6:01 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> After merging the mm tree, today's linux-next build (arm
> multi_v7_defconfig) produced these warnings:
>
> fs/proc/task_mmu.c: In function 'do_procmap_query':
> fs/proc/task_mmu.c:598:48: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
>   598 |         if (karg.vma_name_size && copy_to_user((void __user *)karg.vma_name_addr,
>       |                                                ^
> fs/proc/task_mmu.c:605:48: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
>   605 |         if (karg.build_id_size && copy_to_user((void __user *)karg.build_id_addr,

argh, 32-bit strikes back. We have to do (void __user *)(unsigned
long) cast to satisfy 32-bit compilers. I'll send a patch for mm tree,
thanks for the heads up


>       |                                                ^
>
> Introduced by commits
>
>   3757be498749 ("fs/procfs: implement efficient VMA querying API for /proc/<pid>/maps")
>   df789ce1eb90 ("fs/procfs: add build ID fetching to PROCMAP_QUERY API")
>
> --
> Cheers,
> Stephen Rothwell

Re: linux-next: build warnings after merge of the mm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1110 bytes --]

Hi all,

On Mon, 1 Jul 2024 11:01:13 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the mm tree, today's linux-next build (arm
> multi_v7_defconfig) produced these warnings:
> 
> fs/proc/task_mmu.c: In function 'do_procmap_query':
> fs/proc/task_mmu.c:598:48: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
>   598 |         if (karg.vma_name_size && copy_to_user((void __user *)karg.vma_name_addr,
>       |                                                ^
> fs/proc/task_mmu.c:605:48: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
>   605 |         if (karg.build_id_size && copy_to_user((void __user *)karg.build_id_addr,
>       |                                                ^
> 
> Introduced by commits
> 
>   3757be498749 ("fs/procfs: implement efficient VMA querying API for /proc/<pid>/maps")
>   df789ce1eb90 ("fs/procfs: add build ID fetching to PROCMAP_QUERY API")

This became a build failure in my i386 defconfig build, so I applied
Andrii's patch.
-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warnings after merge of the mm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 2692 bytes --]

Hi all,

After merging the mm tree, today's linux-next build (htmldocs) produced
these warnings:

include/linux/slab.h:545: warning: expecting prototype for kmem_cache_alloc(). Prototype was for kmem_cache_alloc_noprof() instead
include/linux/slab.h:652: warning: expecting prototype for kmalloc(). Prototype was for kmalloc_noprof() instead
include/linux/slab.h:692: warning: expecting prototype for kmalloc_array(). Prototype was for kmalloc_array_noprof() instead
include/linux/slab.h:714: warning: expecting prototype for krealloc_array(). Prototype was for krealloc_array_noprof() instead
include/linux/slab.h:730: warning: Function parameter or struct member '_n' not described in 'kcalloc'
include/linux/slab.h:730: warning: Function parameter or struct member '_size' not described in 'kcalloc'
include/linux/slab.h:730: warning: Function parameter or struct member '_flags' not described in 'kcalloc'
include/linux/slab.h:730: warning: Excess function parameter 'n' description in 'kcalloc'
include/linux/slab.h:730: warning: Excess function parameter 'size' description in 'kcalloc'
include/linux/slab.h:730: warning: Excess function parameter 'flags' description in 'kcalloc'
include/linux/slab.h:774: warning: expecting prototype for kzalloc(). Prototype was for kzalloc_noprof() instead
mm/slab_common.c:1217: warning: expecting prototype for krealloc(). Prototype was for krealloc_noprof() instead
mm/util.c:751: warning: expecting prototype for __vcalloc(). Prototype was for __vcalloc_noprof() instead
mm/vmalloc.c:3897: warning: expecting prototype for vmalloc(). Prototype was for vmalloc_noprof() instead
mm/vmalloc.c:3916: warning: expecting prototype for vmalloc_huge(). Prototype was for vmalloc_huge_noprof() instead
mm/vmalloc.c:3953: warning: expecting prototype for vmalloc_user(). Prototype was for vmalloc_user_noprof() instead
mm/mempool.c:245: warning: expecting prototype for mempool_init(). Prototype was for mempool_init_noprof() instead
mm/mempool.c:271: warning: Function parameter or struct member 'gfp_mask' not described in 'mempool_create_node_noprof'
mm/mempool.c:271: warning: Function parameter or struct member 'node_id' not described in 'mempool_create_node_noprof'
mm/mempool.c:271: warning: expecting prototype for mempool_create_node(). Prototype was for mempool_create_node_noprof() instead

Introduced by commits

  c64e38ed88d1 ("mm/slab: enable slab allocation tagging for kmalloc and friends")
  ea7b8933f21b ("mempool: hook up to memory allocation profiling")
  576477564ede ("mm: vmalloc: enable memory allocation profiling")

from the mm-unstable branch of the mm tree.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warnings after merge of the mm tree

[Suren Baghdasaryan]

On Sun, Mar 24, 2024 at 6:36 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> After merging the mm tree, today's linux-next build (htmldocs) produced
> these warnings:
>
> include/linux/slab.h:545: warning: expecting prototype for kmem_cache_alloc(). Prototype was for kmem_cache_alloc_noprof() instead
> include/linux/slab.h:652: warning: expecting prototype for kmalloc(). Prototype was for kmalloc_noprof() instead
> include/linux/slab.h:692: warning: expecting prototype for kmalloc_array(). Prototype was for kmalloc_array_noprof() instead
> include/linux/slab.h:714: warning: expecting prototype for krealloc_array(). Prototype was for krealloc_array_noprof() instead
> include/linux/slab.h:730: warning: Function parameter or struct member '_n' not described in 'kcalloc'
> include/linux/slab.h:730: warning: Function parameter or struct member '_size' not described in 'kcalloc'
> include/linux/slab.h:730: warning: Function parameter or struct member '_flags' not described in 'kcalloc'
> include/linux/slab.h:730: warning: Excess function parameter 'n' description in 'kcalloc'
> include/linux/slab.h:730: warning: Excess function parameter 'size' description in 'kcalloc'
> include/linux/slab.h:730: warning: Excess function parameter 'flags' description in 'kcalloc'
> include/linux/slab.h:774: warning: expecting prototype for kzalloc(). Prototype was for kzalloc_noprof() instead
> mm/slab_common.c:1217: warning: expecting prototype for krealloc(). Prototype was for krealloc_noprof() instead
> mm/util.c:751: warning: expecting prototype for __vcalloc(). Prototype was for __vcalloc_noprof() instead
> mm/vmalloc.c:3897: warning: expecting prototype for vmalloc(). Prototype was for vmalloc_noprof() instead
> mm/vmalloc.c:3916: warning: expecting prototype for vmalloc_huge(). Prototype was for vmalloc_huge_noprof() instead
> mm/vmalloc.c:3953: warning: expecting prototype for vmalloc_user(). Prototype was for vmalloc_user_noprof() instead
> mm/mempool.c:245: warning: expecting prototype for mempool_init(). Prototype was for mempool_init_noprof() instead
> mm/mempool.c:271: warning: Function parameter or struct member 'gfp_mask' not described in 'mempool_create_node_noprof'
> mm/mempool.c:271: warning: Function parameter or struct member 'node_id' not described in 'mempool_create_node_noprof'
> mm/mempool.c:271: warning: expecting prototype for mempool_create_node(). Prototype was for mempool_create_node_noprof() instead
>
> Introduced by commits
>
>   c64e38ed88d1 ("mm/slab: enable slab allocation tagging for kmalloc and friends")
>   ea7b8933f21b ("mempool: hook up to memory allocation profiling")
>   576477564ede ("mm: vmalloc: enable memory allocation profiling")
>
> from the mm-unstable branch of the mm tree.

Thanks for the report, Stephen!
Let us check with Randy Dunlap how we should handle these. I assume we
still want documentation to document kmalloc(), not kmalloc_noprof().
Maybe there is a way to mute these warnings.

>
> --
> Cheers,
> Stephen Rothwell

Re: linux-next: build warnings after merge of the mm tree

[Randy Dunlap]

On 3/25/24 19:19, Suren Baghdasaryan wrote:
> On Sun, Mar 24, 2024 at 6:36 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>>
>> Hi all,
>>
>> After merging the mm tree, today's linux-next build (htmldocs) produced
>> these warnings:
>>
>> include/linux/slab.h:545: warning: expecting prototype for kmem_cache_alloc(). Prototype was for kmem_cache_alloc_noprof() instead
>> include/linux/slab.h:652: warning: expecting prototype for kmalloc(). Prototype was for kmalloc_noprof() instead
>> include/linux/slab.h:692: warning: expecting prototype for kmalloc_array(). Prototype was for kmalloc_array_noprof() instead
>> include/linux/slab.h:714: warning: expecting prototype for krealloc_array(). Prototype was for krealloc_array_noprof() instead
>> include/linux/slab.h:730: warning: Function parameter or struct member '_n' not described in 'kcalloc'
>> include/linux/slab.h:730: warning: Function parameter or struct member '_size' not described in 'kcalloc'
>> include/linux/slab.h:730: warning: Function parameter or struct member '_flags' not described in 'kcalloc'
>> include/linux/slab.h:730: warning: Excess function parameter 'n' description in 'kcalloc'
>> include/linux/slab.h:730: warning: Excess function parameter 'size' description in 'kcalloc'
>> include/linux/slab.h:730: warning: Excess function parameter 'flags' description in 'kcalloc'
>> include/linux/slab.h:774: warning: expecting prototype for kzalloc(). Prototype was for kzalloc_noprof() instead
>> mm/slab_common.c:1217: warning: expecting prototype for krealloc(). Prototype was for krealloc_noprof() instead
>> mm/util.c:751: warning: expecting prototype for __vcalloc(). Prototype was for __vcalloc_noprof() instead
>> mm/vmalloc.c:3897: warning: expecting prototype for vmalloc(). Prototype was for vmalloc_noprof() instead
>> mm/vmalloc.c:3916: warning: expecting prototype for vmalloc_huge(). Prototype was for vmalloc_huge_noprof() instead
>> mm/vmalloc.c:3953: warning: expecting prototype for vmalloc_user(). Prototype was for vmalloc_user_noprof() instead
>> mm/mempool.c:245: warning: expecting prototype for mempool_init(). Prototype was for mempool_init_noprof() instead
>> mm/mempool.c:271: warning: Function parameter or struct member 'gfp_mask' not described in 'mempool_create_node_noprof'
>> mm/mempool.c:271: warning: Function parameter or struct member 'node_id' not described in 'mempool_create_node_noprof'
>> mm/mempool.c:271: warning: expecting prototype for mempool_create_node(). Prototype was for mempool_create_node_noprof() instead
>>
>> Introduced by commits
>>
>>   c64e38ed88d1 ("mm/slab: enable slab allocation tagging for kmalloc and friends")
>>   ea7b8933f21b ("mempool: hook up to memory allocation profiling")
>>   576477564ede ("mm: vmalloc: enable memory allocation profiling")
>>
>> from the mm-unstable branch of the mm tree.
> 
> Thanks for the report, Stephen!
> Let us check with Randy Dunlap how we should handle these. I assume we
> still want documentation to document kmalloc(), not kmalloc_noprof().
> Maybe there is a way to mute these warnings.

A proposed patch is here:
  https://lore.kernel.org/lkml/20240326054149.2121-1-rdunlap@infradead.org/T/#u


-- 
#Randy

Re: linux-next: build warnings after merge of the mm tree

[Suren Baghdasaryan]

On Mon, Mar 25, 2024 at 10:44 PM Randy Dunlap <rdunlap@infradead.org> wrote:
>
>
>
> On 3/25/24 19:19, Suren Baghdasaryan wrote:
> > On Sun, Mar 24, 2024 at 6:36 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >>
> >> Hi all,
> >>
> >> After merging the mm tree, today's linux-next build (htmldocs) produced
> >> these warnings:
> >>
> >> include/linux/slab.h:545: warning: expecting prototype for kmem_cache_alloc(). Prototype was for kmem_cache_alloc_noprof() instead
> >> include/linux/slab.h:652: warning: expecting prototype for kmalloc(). Prototype was for kmalloc_noprof() instead
> >> include/linux/slab.h:692: warning: expecting prototype for kmalloc_array(). Prototype was for kmalloc_array_noprof() instead
> >> include/linux/slab.h:714: warning: expecting prototype for krealloc_array(). Prototype was for krealloc_array_noprof() instead
> >> include/linux/slab.h:730: warning: Function parameter or struct member '_n' not described in 'kcalloc'
> >> include/linux/slab.h:730: warning: Function parameter or struct member '_size' not described in 'kcalloc'
> >> include/linux/slab.h:730: warning: Function parameter or struct member '_flags' not described in 'kcalloc'
> >> include/linux/slab.h:730: warning: Excess function parameter 'n' description in 'kcalloc'
> >> include/linux/slab.h:730: warning: Excess function parameter 'size' description in 'kcalloc'
> >> include/linux/slab.h:730: warning: Excess function parameter 'flags' description in 'kcalloc'
> >> include/linux/slab.h:774: warning: expecting prototype for kzalloc(). Prototype was for kzalloc_noprof() instead
> >> mm/slab_common.c:1217: warning: expecting prototype for krealloc(). Prototype was for krealloc_noprof() instead
> >> mm/util.c:751: warning: expecting prototype for __vcalloc(). Prototype was for __vcalloc_noprof() instead
> >> mm/vmalloc.c:3897: warning: expecting prototype for vmalloc(). Prototype was for vmalloc_noprof() instead
> >> mm/vmalloc.c:3916: warning: expecting prototype for vmalloc_huge(). Prototype was for vmalloc_huge_noprof() instead
> >> mm/vmalloc.c:3953: warning: expecting prototype for vmalloc_user(). Prototype was for vmalloc_user_noprof() instead
> >> mm/mempool.c:245: warning: expecting prototype for mempool_init(). Prototype was for mempool_init_noprof() instead
> >> mm/mempool.c:271: warning: Function parameter or struct member 'gfp_mask' not described in 'mempool_create_node_noprof'
> >> mm/mempool.c:271: warning: Function parameter or struct member 'node_id' not described in 'mempool_create_node_noprof'
> >> mm/mempool.c:271: warning: expecting prototype for mempool_create_node(). Prototype was for mempool_create_node_noprof() instead
> >>
> >> Introduced by commits
> >>
> >>   c64e38ed88d1 ("mm/slab: enable slab allocation tagging for kmalloc and friends")
> >>   ea7b8933f21b ("mempool: hook up to memory allocation profiling")
> >>   576477564ede ("mm: vmalloc: enable memory allocation profiling")
> >>
> >> from the mm-unstable branch of the mm tree.
> >
> > Thanks for the report, Stephen!
> > Let us check with Randy Dunlap how we should handle these. I assume we
> > still want documentation to document kmalloc(), not kmalloc_noprof().
> > Maybe there is a way to mute these warnings.
>
> A proposed patch is here:
>   https://lore.kernel.org/lkml/20240326054149.2121-1-rdunlap@infradead.org/T/#u

Thanks! I'll change back all the instances in the documentation where
we replaced original names with _noprof versions.

>
>
> --
> #Randy

Re: linux-next: build warnings after merge of the mm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 9103 bytes --]

Hi all,

On Mon, 25 Mar 2024 23:16:55 -0700 Suren Baghdasaryan <surenb@google.com> wrote:
>
> Thanks! I'll change back all the instances in the documentation where
> we replaced original names with _noprof versions.

I now have the following:

mm/util.c:128: warning: expecting prototype for kmemdup_noprof(). Prototype was for kmemdup() instead
mm/util.c:613: warning: expecting prototype for kvmalloc_node_noprof(). Prototype was for kvmalloc_node() instead
mm/util.c:724: warning: expecting prototype for __vmalloc_array_noprof(). Prototype was for __vmalloc_array() instead
mm/util.c:739: warning: expecting prototype for vmalloc_array_noprof(). Prototype was for vmalloc_array() instead
mm/util.c:762: warning: expecting prototype for vcalloc_noprof(). Prototype was for vcalloc() instead
drivers/gpu/drm/amd/display/dc/inc/hw/hubp.h:1: warning: no structured comments found
drivers/gpu/drm/amd/display/dc/inc/hw/hubp.h:1: warning: no structured comments found
drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:1: warning: no structured comments found
drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:547: warning: Function parameter or struct member 'read_mpcc_state' not described in 'mpc_funcs'
drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:547: warning: Function parameter or struct member 'mpc_init_single_inst' not described in 'mpc_funcs'
drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:547: warning: Function parameter or struct member 'get_mpcc_for_dpp_from_secondary' not described in 'mpc_funcs'
drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:547: warning: Function parameter or struct member 'get_mpcc_for_dpp' not described in 'mpc_funcs'
drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:547: warning: Function parameter or struct member 'wait_for_idle' not described in 'mpc_funcs'
drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:547: warning: Function parameter or struct member 'assert_mpcc_idle_before_connect' not described in 'mpc_funcs'
drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:547: warning: Function parameter or struct member 'init_mpcc_list_from_hw' not described in 'mpc_funcs'
drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:547: warning: Function parameter or struct member 'set_denorm' not described in 'mpc_funcs'
drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:547: warning: Function parameter or struct member 'set_denorm_clamp' not described in 'mpc_funcs'
drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:547: warning: Function parameter or struct member 'set_output_csc' not described in 'mpc_funcs'
drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:547: warning: Function parameter or struct member 'set_ocsc_default' not described in 'mpc_funcs'
drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:547: warning: Function parameter or struct member 'set_output_gamma' not described in 'mpc_funcs'
drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:547: warning: Function parameter or struct member 'power_on_mpc_mem_pwr' not described in 'mpc_funcs'
drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:547: warning: Function parameter or struct member 'set_dwb_mux' not described in 'mpc_funcs'
drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:547: warning: Function parameter or struct member 'disable_dwb_mux' not described in 'mpc_funcs'
drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:547: warning: Function parameter or struct member 'is_dwb_idle' not described in 'mpc_funcs'
drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:547: warning: Function parameter or struct member 'set_out_rate_control' not described in 'mpc_funcs'
drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:547: warning: Function parameter or struct member 'set_gamut_remap' not described in 'mpc_funcs'
drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:547: warning: Function parameter or struct member 'program_1dlut' not described in 'mpc_funcs'
drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:547: warning: Function parameter or struct member 'program_shaper' not described in 'mpc_funcs'
drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:547: warning: Function parameter or struct member 'acquire_rmu' not described in 'mpc_funcs'
drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:547: warning: Function parameter or struct member 'program_3dlut' not described in 'mpc_funcs'
drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:547: warning: Function parameter or struct member 'release_rmu' not described in 'mpc_funcs'
drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:547: warning: Function parameter or struct member 'get_mpc_out_mux' not described in 'mpc_funcs'
drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:547: warning: Function parameter or struct member 'set_bg_color' not described in 'mpc_funcs'
drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:547: warning: Function parameter or struct member 'set_mpc_mem_lp_mode' not described in 'mpc_funcs'
drivers/gpu/drm/amd/display/dc/inc/hw/opp.h:1: warning: no structured comments found
drivers/gpu/drm/amd/display/dc/inc/hw/opp.h:1: warning: no structured comments found
drivers/gpu/drm/amd/display/dc/link/hwss/link_hwss_dio.h:1: warning: no structured comments found
drivers/gpu/drm/amd/display/dc/link/hwss/link_hwss_dio.h:1: warning: no structured comments found
drivers/slimbus/stream.c:49: warning: Excess struct member 'segdist_codes' description in 'segdist_code'
include/linux/slab.h:730: warning: Function parameter or struct member '_n' not described in 'kcalloc'
include/linux/slab.h:730: warning: Function parameter or struct member '_size' not described in 'kcalloc'
include/linux/slab.h:730: warning: Function parameter or struct member '_flags' not described in 'kcalloc'
include/linux/slab.h:730: warning: Excess function parameter 'n' description in 'kcalloc'
include/linux/slab.h:730: warning: Excess function parameter 'size' description in 'kcalloc'
include/linux/slab.h:730: warning: Excess function parameter 'flags' description in 'kcalloc'
mm/slub.c:3969: warning: expecting prototype for kmem_cache_alloc_node_noprof(). Prototype was for kmem_cache_alloc_node() instead
mm/util.c:128: warning: expecting prototype for kmemdup_noprof(). Prototype was for kmemdup() instead
mm/util.c:613: warning: expecting prototype for kvmalloc_node_noprof(). Prototype was for kvmalloc_node() instead
mm/util.c:724: warning: expecting prototype for __vmalloc_array_noprof(). Prototype was for __vmalloc_array() instead
mm/util.c:739: warning: expecting prototype for vmalloc_array_noprof(). Prototype was for vmalloc_array() instead
mm/util.c:762: warning: expecting prototype for vcalloc_noprof(). Prototype was for vcalloc() instead
mm/vmalloc.c:3722: warning: expecting prototype for __vmalloc_node_range_noprof(). Prototype was for __vmalloc_node_range() instead
mm/vmalloc.c:3867: warning: expecting prototype for __vmalloc_node_noprof(). Prototype was for __vmalloc_node() instead
mm/vmalloc.c:3940: warning: expecting prototype for vzalloc_noprof(). Prototype was for vzalloc() instead
mm/vmalloc.c:3978: warning: expecting prototype for vmalloc_node_noprof(). Prototype was for vmalloc_node() instead
mm/vmalloc.c:3996: warning: expecting prototype for vzalloc_node_noprof(). Prototype was for vzalloc_node() instead
mm/vmalloc.c:4024: warning: expecting prototype for vmalloc_32_noprof(). Prototype was for vmalloc_32() instead
mm/vmalloc.c:4040: warning: expecting prototype for vmalloc_32_user_noprof(). Prototype was for vmalloc_32_user() instead
mm/mempool.c:383: warning: expecting prototype for mempool_alloc_noprof(). Prototype was for mempool_alloc() instead
mm/page_alloc.c:4991: warning: expecting prototype for alloc_pages_exact_noprof(). Prototype was for alloc_pages_exact() instead
mm/page_alloc.c:5016: warning: expecting prototype for alloc_pages_exact_nid_noprof(). Prototype was for alloc_pages_exact_nid() instead
mm/page_alloc.c:6463: warning: expecting prototype for alloc_contig_range_noprof(). Prototype was for alloc_contig_range() instead
mm/page_alloc.c:6627: warning: expecting prototype for alloc_contig_pages_noprof(). Prototype was for alloc_contig_pages() instead
mm/mempolicy.c:2223: warning: expecting prototype for alloc_pages_mpol_noprof(). Prototype was for alloc_pages_mpol() instead
mm/mempolicy.c:2298: warning: expecting prototype for vma_alloc_folio_noprof(). Prototype was for vma_alloc_folio() instead
mm/mempolicy.c:2326: warning: expecting prototype for alloc_pages_noprof(). Prototype was for alloc_pages() instead
mm/util.c:128: warning: expecting prototype for kmemdup_noprof(). Prototype was for kmemdup() instead
mm/util.c:613: warning: expecting prototype for kvmalloc_node_noprof(). Prototype was for kvmalloc_node() instead
mm/util.c:724: warning: expecting prototype for __vmalloc_array_noprof(). Prototype was for __vmalloc_array() instead
mm/util.c:739: warning: expecting prototype for vmalloc_array_noprof(). Prototype was for vmalloc_array() instead
mm/util.c:762: warning: expecting prototype for vcalloc_noprof(). Prototype was for vcalloc() instead
mm/percpu.c:1745: warning: expecting prototype for pcpu_alloc_noprof(). Prototype was for pcpu_alloc() instead

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warnings after merge of the mm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 456 bytes --]

Hi all,

On Thu, 28 Mar 2024 15:39:47 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> On Mon, 25 Mar 2024 23:16:55 -0700 Suren Baghdasaryan <surenb@google.com> wrote:
> >
> > Thanks! I'll change back all the instances in the documentation where
> > we replaced original names with _noprof versions.  
> 
> I now have the following:

Sorry, some of those are not relevant here, just the _noprof stuff.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warnings after merge of the mm tree

[Suren Baghdasaryan]

On Wed, Mar 27, 2024 at 9:44 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> On Thu, 28 Mar 2024 15:39:47 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > On Mon, 25 Mar 2024 23:16:55 -0700 Suren Baghdasaryan <surenb@google.com> wrote:
> > >
> > > Thanks! I'll change back all the instances in the documentation where
> > > we replaced original names with _noprof versions.
> >
> > I now have the following:
>
> Sorry, some of those are not relevant here, just the _noprof stuff.

https://lore.kernel.org/all/20240327044649.9199-1-rdunlap@infradead.org/
which seems to not yet been pulled into mm-unstable should fix the
following warnings:

include/linux/slab.h:730: warning: Function parameter or struct member
'_n' not described in 'kcalloc'
include/linux/slab.h:730: warning: Function parameter or struct member
'_size' not described in 'kcalloc'
include/linux/slab.h:730: warning: Function parameter or struct member
'_flags' not described in 'kcalloc'
include/linux/slab.h:730: warning: Excess function parameter 'n'
description in 'kcalloc'
include/linux/slab.h:730: warning: Excess function parameter 'size'
description in 'kcalloc'
include/linux/slab.h:730: warning: Excess function parameter 'flags'
description in 'kcalloc'

And https://lore.kernel.org/all/20240326054149.2121-1-rdunlap@infradead.org/
should handle the _noprof warnings. I can see this patch in
mm-unstable and running "make htmldocs" in mm-unstable does not show
the _noprof warnings anymore. Please let me know if I should try some
other command to reproduce these.
Thanks,
Suren.


>
> --
> Cheers,
> Stephen Rothwell

Re: linux-next: build warnings after merge of the mm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1370 bytes --]

Hi Suren,

On Wed, 27 Mar 2024 22:35:56 -0700 Suren Baghdasaryan <surenb@google.com> wrote:
>
> https://lore.kernel.org/all/20240327044649.9199-1-rdunlap@infradead.org/
> which seems to not yet been pulled into mm-unstable should fix the
> following warnings:
> 
> include/linux/slab.h:730: warning: Function parameter or struct member
> '_n' not described in 'kcalloc'
> include/linux/slab.h:730: warning: Function parameter or struct member
> '_size' not described in 'kcalloc'
> include/linux/slab.h:730: warning: Function parameter or struct member
> '_flags' not described in 'kcalloc'
> include/linux/slab.h:730: warning: Excess function parameter 'n'
> description in 'kcalloc'
> include/linux/slab.h:730: warning: Excess function parameter 'size'
> description in 'kcalloc'
> include/linux/slab.h:730: warning: Excess function parameter 'flags'
> description in 'kcalloc'
> 
> And https://lore.kernel.org/all/20240326054149.2121-1-rdunlap@infradead.org/
> should handle the _noprof warnings. I can see this patch in
> mm-unstable and running "make htmldocs" in mm-unstable does not show
> the _noprof warnings anymore. Please let me know if I should try some
> other command to reproduce these.

Those patches entered the mm tree after I had merge it on Thursday.  It
should all be good on Tuesday.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warnings after merge of the mm tree

[Suren Baghdasaryan]

On Fri, Mar 29, 2024 at 3:49 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi Suren,
>
> On Wed, 27 Mar 2024 22:35:56 -0700 Suren Baghdasaryan <surenb@google.com> wrote:
> >
> > https://lore.kernel.org/all/20240327044649.9199-1-rdunlap@infradead.org/
> > which seems to not yet been pulled into mm-unstable should fix the
> > following warnings:
> >
> > include/linux/slab.h:730: warning: Function parameter or struct member
> > '_n' not described in 'kcalloc'
> > include/linux/slab.h:730: warning: Function parameter or struct member
> > '_size' not described in 'kcalloc'
> > include/linux/slab.h:730: warning: Function parameter or struct member
> > '_flags' not described in 'kcalloc'
> > include/linux/slab.h:730: warning: Excess function parameter 'n'
> > description in 'kcalloc'
> > include/linux/slab.h:730: warning: Excess function parameter 'size'
> > description in 'kcalloc'
> > include/linux/slab.h:730: warning: Excess function parameter 'flags'
> > description in 'kcalloc'
> >
> > And https://lore.kernel.org/all/20240326054149.2121-1-rdunlap@infradead.org/
> > should handle the _noprof warnings. I can see this patch in
> > mm-unstable and running "make htmldocs" in mm-unstable does not show
> > the _noprof warnings anymore. Please let me know if I should try some
> > other command to reproduce these.
>
> Those patches entered the mm tree after I had merge it on Thursday.  It
> should all be good on Tuesday.

Perfect. I'll ignore similar reports with _noprof prototype warnings until then.
Thank you!

>
> --
> Cheers,
> Stephen Rothwell

Re: linux-next: build warnings after merge of the mm tree

[Suren Baghdasaryan]

On Fri, Mar 29, 2024 at 3:49 PM Stephen Rothwell <sfr@canb.auug.orgau> wrote:
>
> Hi Suren,
>
> On Wed, 27 Mar 2024 22:35:56 -0700 Suren Baghdasaryan <surenb@google.com> wrote:
> >
> > https://lore.kernel.org/all/20240327044649.9199-1-rdunlap@infradead.org/
> > which seems to not yet been pulled into mm-unstable should fix the
> > following warnings:
> >
> > include/linux/slab.h:730: warning: Function parameter or struct member
> > '_n' not described in 'kcalloc'
> > include/linux/slab.h:730: warning: Function parameter or struct member
> > '_size' not described in 'kcalloc'
> > include/linux/slab.h:730: warning: Function parameter or struct member
> > '_flags' not described in 'kcalloc'
> > include/linux/slab.h:730: warning: Excess function parameter 'n'
> > description in 'kcalloc'
> > include/linux/slab.h:730: warning: Excess function parameter 'size'
> > description in 'kcalloc'
> > include/linux/slab.h:730: warning: Excess function parameter 'flags'
> > description in 'kcalloc'
> >
> > And https://lore.kernel.org/all/20240326054149.2121-1-rdunlap@infradeadorg/
> > should handle the _noprof warnings. I can see this patch in
> > mm-unstable and running "make htmldocs" in mm-unstable does not show
> > the _noprof warnings anymore. Please let me know if I should try some
> > other command to reproduce these.
>
> Those patches entered the mm tree after I had merge it on Thursday.  It
> should all be good on Tuesday.

Perfect. I'll ignore similar reports with _noprof prototype warnings until then.
Thank you!

>
> --
> Cheers,
> Stephen Rothwell

linux-next: build warnings after merge of the mm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 767 bytes --]

Hi all,

After merging the mm tree, today's linux-next build (powerpc allyesconfig)
produced these warnings:

WARNING: modpost: vmlinux: section mismatch in reference: remove_pte_table+0x230 (section: .text.remove_pte_table) -> free_vmemmap_pages (section: .meminit.text)
WARNING: modpost: vmlinux: section mismatch in reference: remove_pte_table+0x43c (section: .text.remove_pte_table) -> vmemmap_populated (section: .meminit.text)
WARNING: modpost: vmlinux: section mismatch in reference: remove_pte_table+0x4a4 (section: .text.remove_pte_table) -> free_vmemmap_pages (section: .meminit.text)

Introduced by commit

  25081814314b ("powerpc/book3s64/vmemmap: switch radix to use a different vmemmap handling function")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warnings after merge of the mm tree

[Aneesh Kumar K.V]

Stephen Rothwell <sfr@canb.auug.org.au> writes:

> Hi all,
>
> After merging the mm tree, today's linux-next build (powerpc allyesconfig)
> produced these warnings:
>
> WARNING: modpost: vmlinux: section mismatch in reference: remove_pte_table+0x230 (section: .text.remove_pte_table) -> free_vmemmap_pages (section: .meminit.text)
> WARNING: modpost: vmlinux: section mismatch in reference: remove_pte_table+0x43c (section: .text.remove_pte_table) -> vmemmap_populated (section: .meminit.text)
> WARNING: modpost: vmlinux: section mismatch in reference: remove_pte_table+0x4a4 (section: .text.remove_pte_table) -> free_vmemmap_pages (section: .meminit.text)
>
> Introduced by commit
>
>   25081814314b ("powerpc/book3s64/vmemmap: switch radix to use a different vmemmap handling function")
>

I will send this as a separate patch to linuxppc-dev ? Even though the
warning started with this series because it is using functions in
meminit from remove_pte_table, marking remove_pte_table correctly is
applicable outside series that caused this warning ?

From 29ddcbbcae6ec2a7b70015274b2d5c4ec9b6beea Mon Sep 17 00:00:00 2001
From: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>
Date: Thu, 27 Jul 2023 10:02:37 +0530
Subject: [PATCH] powerpc/mm: Fix section mismatch warning

remove_pte_table is only called from remove_pmd_table which is marked
__meminit. These functions are used only during memory hotplug and they
also call functions marked __meminit. Mark remote_pte_table also with
__meminit so that we can avoid the section mismatch warning below.

WARNING: modpost: vmlinux: section mismatch in reference: remove_pte_table+0x230 (section: .text.remove_pte_table) -> free_vmemmap_pages (section: .meminit.text)
WARNING: modpost: vmlinux: section mismatch in reference: remove_pte_table+0x43c (section: .text.remove_pte_table) -> vmemmap_populated (section: .meminit.text)
WARNING: modpost: vmlinux: section mismatch in reference: remove_pte_table+0x4a4 (section: .text.remove_pte_table) -> free_vmemmap_pages (section: .meminit.text)

Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>
---
 arch/powerpc/mm/book3s64/radix_pgtable.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/powerpc/mm/book3s64/radix_pgtable.c b/arch/powerpc/mm/book3s64/radix_pgtable.c
index 59aaa30a7c0d..96679018e7fb 100644
--- a/arch/powerpc/mm/book3s64/radix_pgtable.c
+++ b/arch/powerpc/mm/book3s64/radix_pgtable.c
@@ -782,9 +782,9 @@ static void __meminit free_vmemmap_pages(struct page *page,
 		free_pages((unsigned long)page_address(page), order);
 }
 
-static void remove_pte_table(pte_t *pte_start, unsigned long addr,
-			     unsigned long end, bool direct,
-			     struct vmem_altmap *altmap)
+static void __meminit remove_pte_table(pte_t *pte_start, unsigned long addr,
+				       unsigned long end, bool direct,
+				       struct vmem_altmap *altmap)
 {
 	unsigned long next, pages = 0;
 	pte_t *pte;
-- 
2.41.0

Re: linux-next: build warnings after merge of the mm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 503 bytes --]

Hi Aneesh,

On Thu, 27 Jul 2023 10:16:19 +0530 "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com> wrote:
>
> I will send this as a separate patch to linuxppc-dev ? Even though the
> warning started with this series because it is using functions in
> meminit from remove_pte_table, marking remove_pte_table correctly is
> applicable outside series that caused this warning ?

Please just keep it with the patch that exposed this situation i.e. in
Andrew's tree.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warnings after merge of the mm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 963 bytes --]

Hi all,

After merging the mm tree, today's linux-next build (htmldocs) produced
these warnings:

lib/maple_tree.c:6054: warning: Function parameter or member 'mas' not described in 'mas_find_setup'
lib/maple_tree.c:6054: warning: Function parameter or member 'max' not described in 'mas_find_setup'
lib/maple_tree.c:6054: warning: Function parameter or member 'entry' not described in 'mas_find_setup'
lib/maple_tree.c:6157: warning: Function parameter or member 'mas' not described in 'mas_find_rev_setup'
lib/maple_tree.c:6157: warning: Function parameter or member 'min' not described in 'mas_find_rev_setup'
lib/maple_tree.c:6157: warning: Function parameter or member 'entry' not described in 'mas_find_rev_setup'

Introduced by commits

  ef6a3f9e88a1 ("maple_tree: add mas_next_range() and mas_find_range() interfaces")
  3bd55a4fa16d ("maple_tree: add mas_prev_range() and mas_find_range_rev interface")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warnings after merge of the mm tree

[Liam R. Howlett]

* Stephen Rothwell <sfr@canb.auug.org.au> [230508 00:54]:
> Hi all,
> 
> After merging the mm tree, today's linux-next build (htmldocs) produced
> these warnings:
> 
> lib/maple_tree.c:6054: warning: Function parameter or member 'mas' not described in 'mas_find_setup'
> lib/maple_tree.c:6054: warning: Function parameter or member 'max' not described in 'mas_find_setup'
> lib/maple_tree.c:6054: warning: Function parameter or member 'entry' not described in 'mas_find_setup'
> lib/maple_tree.c:6157: warning: Function parameter or member 'mas' not described in 'mas_find_rev_setup'
> lib/maple_tree.c:6157: warning: Function parameter or member 'min' not described in 'mas_find_rev_setup'
> lib/maple_tree.c:6157: warning: Function parameter or member 'entry' not described in 'mas_find_rev_setup'

Thanks.  I'll fix these.

> 
> Introduced by commits
> 
>   ef6a3f9e88a1 ("maple_tree: add mas_next_range() and mas_find_range() interfaces")
>   3bd55a4fa16d ("maple_tree: add mas_prev_range() and mas_find_range_rev interface")
> 
> -- 
> Cheers,
> Stephen Rothwell

linux-next: build warnings after merge of the mm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 674 bytes --]

Hi all,

After merging the mm tree, today's linux-next build (htmldocs) produced
thess warnings:

/home/sfr/next/next/Documentation/ABI/testing/sysfs-class-bdi:76: ERROR: Unexpected indentation.
/home/sfr/next/next/Documentation/ABI/testing/sysfs-class-bdi:89: ERROR: Unexpected indentation.
/home/sfr/next/next/Documentation/ABI/testing/sysfs-class-bdi:48: ERROR: Unexpected indentation.

Introduced by commit

  93e6d447506d ("mm: document /sys/class/bdi/<bdi>/min_bytes knob")
  a0eef74439b2 ("mm: document /sys/class/bdi/<bdi>/max_ratio_fine knob")
  3aafa9ff1d4f ("mm: document /sys/class/bdi/<bdi>/min_ratio_fine knob")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warnings after merge of the mm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 2388 bytes --]

Hi all,

After merging the mm tree, today's linux-next build (htmldocs) produced
these warnings:

include/linux/maple_tree.h:230: warning: Function parameter or member '__flags' not described in 'MTREE_INIT'
include/linux/maple_tree.h:230: warning: Excess function parameter 'flags' description in 'MTREE_INIT'
include/linux/maple_tree.h:243: warning: Function parameter or member '__flags' not described in 'MTREE_INIT_EXT'
include/linux/maple_tree.h:243: warning: Function parameter or member '__lock' not described in 'MTREE_INIT_EXT'
include/linux/maple_tree.h:243: warning: Excess function parameter 'flags' description in 'MTREE_INIT_EXT'
include/linux/maple_tree.h:243: warning: Excess function parameter 'lock' description in 'MTREE_INIT_EXT'
include/linux/maple_tree.h:523: warning: Function parameter or member '__mas' not described in 'mas_for_each'
include/linux/maple_tree.h:523: warning: Function parameter or member '__entry' not described in 'mas_for_each'
include/linux/maple_tree.h:523: warning: Function parameter or member '__max' not described in 'mas_for_each'
include/linux/maple_tree.h:523: warning: Excess function parameter 'mas' description in 'mas_for_each'
include/linux/maple_tree.h:523: warning: Excess function parameter 'entry' description in 'mas_for_each'
include/linux/maple_tree.h:523: warning: Excess function parameter 'max' description in 'mas_for_each'
include/linux/maple_tree.h:658: warning: Function parameter or member '__tree' not described in 'mt_for_each'
include/linux/maple_tree.h:658: warning: Function parameter or member '__entry' not described in 'mt_for_each'
include/linux/maple_tree.h:658: warning: Function parameter or member '__index' not described in 'mt_for_each'
include/linux/maple_tree.h:658: warning: Function parameter or member '__max' not described in 'mt_for_each'
include/linux/maple_tree.h:658: warning: Excess function parameter 'tree' description in 'mt_for_each'
include/linux/maple_tree.h:658: warning: Excess function parameter 'entry' description in 'mt_for_each'
include/linux/maple_tree.h:658: warning: Excess function parameter 'index' description in 'mt_for_each'
include/linux/maple_tree.h:658: warning: Excess function parameter 'max' description in 'mt_for_each'

Introduced by commit

  96ba2a9525fb ("Maple Tree: add new data structure")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warnings after merge of the mm tree

[Liam Howlett]

* Stephen Rothwell <sfr@canb.auug.org.au> [220822 23:54]:
> Hi all,
> 
> After merging the mm tree, today's linux-next build (htmldocs) produced
> these warnings:
> 
> include/linux/maple_tree.h:230: warning: Function parameter or member '__flags' not described in 'MTREE_INIT'
> include/linux/maple_tree.h:230: warning: Excess function parameter 'flags' description in 'MTREE_INIT'
> include/linux/maple_tree.h:243: warning: Function parameter or member '__flags' not described in 'MTREE_INIT_EXT'
> include/linux/maple_tree.h:243: warning: Function parameter or member '__lock' not described in 'MTREE_INIT_EXT'
> include/linux/maple_tree.h:243: warning: Excess function parameter 'flags' description in 'MTREE_INIT_EXT'
> include/linux/maple_tree.h:243: warning: Excess function parameter 'lock' description in 'MTREE_INIT_EXT'
> include/linux/maple_tree.h:523: warning: Function parameter or member '__mas' not described in 'mas_for_each'
> include/linux/maple_tree.h:523: warning: Function parameter or member '__entry' not described in 'mas_for_each'
> include/linux/maple_tree.h:523: warning: Function parameter or member '__max' not described in 'mas_for_each'
> include/linux/maple_tree.h:523: warning: Excess function parameter 'mas' description in 'mas_for_each'
> include/linux/maple_tree.h:523: warning: Excess function parameter 'entry' description in 'mas_for_each'
> include/linux/maple_tree.h:523: warning: Excess function parameter 'max' description in 'mas_for_each'
> include/linux/maple_tree.h:658: warning: Function parameter or member '__tree' not described in 'mt_for_each'
> include/linux/maple_tree.h:658: warning: Function parameter or member '__entry' not described in 'mt_for_each'
> include/linux/maple_tree.h:658: warning: Function parameter or member '__index' not described in 'mt_for_each'
> include/linux/maple_tree.h:658: warning: Function parameter or member '__max' not described in 'mt_for_each'
> include/linux/maple_tree.h:658: warning: Excess function parameter 'tree' description in 'mt_for_each'
> include/linux/maple_tree.h:658: warning: Excess function parameter 'entry' description in 'mt_for_each'
> include/linux/maple_tree.h:658: warning: Excess function parameter 'index' description in 'mt_for_each'
> include/linux/maple_tree.h:658: warning: Excess function parameter 'max' description in 'mt_for_each'
> 
> Introduced by commit
> 
>   96ba2a9525fb ("Maple Tree: add new data structure")
> 

Thanks.  I forgot to update the docs when I updated the arguments.  I'll
send out a patch shortly.

linux-next: build warnings after merge of the mm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 616 bytes --]

Hi all,

After merging the mm tree, today's linux-next build (htmldocs) produced
these warnings:

Documentation/filesystems/proc.rst:1155: WARNING: Definition list ends without a blank line; unexpected unindent.
Documentation/filesystems/proc.rst:1161: WARNING: Unexpected indentation.
Documentation/filesystems/proc.rst:1162: WARNING: Block quote ends without a blank line; unexpected unindent.
Documentation/filesystems/proc.rst:1165: WARNING: Unexpected indentation.

Introduced by commit

  9e43c820f7b2 ("Documentation: filesystems: proc: update meminfo section")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warnings after merge of the mm tree

[Johannes Weiner]

On Wed, May 11, 2022 at 08:20:45PM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the mm tree, today's linux-next build (htmldocs) produced
> these warnings:
> 
> Documentation/filesystems/proc.rst:1155: WARNING: Definition list ends without a blank line; unexpected unindent.
> Documentation/filesystems/proc.rst:1161: WARNING: Unexpected indentation.
> Documentation/filesystems/proc.rst:1162: WARNING: Block quote ends without a blank line; unexpected unindent.
> Documentation/filesystems/proc.rst:1165: WARNING: Unexpected indentation.
> 
> Introduced by commit
> 
>   9e43c820f7b2 ("Documentation: filesystems: proc: update meminfo section")

The patch below fixes it. The html output looks good too.

Andrew, could you please pick this up as delta for    ^^^ ? Thanks!

Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
---

diff --git a/Documentation/filesystems/proc.rst b/Documentation/filesystems/proc.rst
index 736ed384750c..9749ff8c0ecf 100644
--- a/Documentation/filesystems/proc.rst
+++ b/Documentation/filesystems/proc.rst
@@ -1146,16 +1146,9 @@ CmaTotal
               Memory reserved for the Contiguous Memory Allocator (CMA)
 CmaFree
               Free remaining memory in the CMA reserves
-HugePages_Total
-HugePages_Free
-HugePages_Rsvd
-HugePages_Surp
-Hugepagesize
-Hugetlb
+HugePages_Total, HugePages_Free, HugePages_Rsvd, HugePages_Surp, Hugepagesize, Hugetlb
               See Documentation/admin-guide/mm/hugetlbpage.rst.
-DirectMap4k
-DirectMap2M
-DirectMap1G
+DirectMap4k, DirectMap2M, DirectMap1G
               Breakdown of page table sizes used in the kernel's
               identity mapping of RAM