linux-next: Fixes tag needs some work in the ftrace tree

linux-next: Fixes tag needs some work in the ftrace tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 434 bytes --]

Hi all,

In commit

  b5e7014fe1c4 ("selftests/ftrace: Update synthetic event syntax errors")

Fixes tag

  Fixes: 81ff92a93d95 (selftests/ftrace: Add test case for synthetic

has these problem(s):

  - Subject has leading but no trailing parentheses

Please do not split Fixes tags over more than one line.  Also, keep all
the commit message tags together at the end of the message.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the ftrace tree

[Steven Rostedt]

On Fri, 12 Feb 2021 07:57:28 +1100
Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> Hi all,
> 
> In commit
> 
>   b5e7014fe1c4 ("selftests/ftrace: Update synthetic event syntax errors")
> 
> Fixes tag
> 
>   Fixes: 81ff92a93d95 (selftests/ftrace: Add test case for synthetic
> 
> has these problem(s):
> 
>   - Subject has leading but no trailing parentheses
> 
> Please do not split Fixes tags over more than one line.  Also, keep all
> the commit message tags together at the end of the message.
> 

Thanks, I didn't even notice that :-/

Tom, FYI for next time ;-)

-- Steve

Re: linux-next: Fixes tag needs some work in the ftrace tree

[Tom Zanussi]

On Thu, 2021-02-11 at 16:21 -0500, Steven Rostedt wrote:
> On Fri, 12 Feb 2021 07:57:28 +1100
> Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> 
> > Hi all,
> > 
> > In commit
> > 
> >   b5e7014fe1c4 ("selftests/ftrace: Update synthetic event syntax
> > errors")
> > 
> > Fixes tag
> > 
> >   Fixes: 81ff92a93d95 (selftests/ftrace: Add test case for
> > synthetic
> > 
> > has these problem(s):
> > 
> >   - Subject has leading but no trailing parentheses
> > 
> > Please do not split Fixes tags over more than one line.  Also, keep
> > all
> > the commit message tags together at the end of the message.
> > 
> 
> Thanks, I didn't even notice that :-/
> 
> Tom, FYI for next time ;-)
> 

Yep, thanks, Stephen, for pointing that out, didn't realize it until
now either.

Tom


> -- Steve

linux-next: Fixes tag needs some work in the ftrace tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 482 bytes --]

Hi all,

In commit

  2fd814ad5713 ("ring-buffer: Make wake once of ring_buffer_wait() more robust")

Fixes tag

  Fixes: 5b37b7eb98a19 ("ring-buffer: Make wake once of ring_buffer_wait() more robust")

has these problem(s):

  - Target SHA1 does not exist

The Fixes tag seems to be referring to the commit that contains the
Fixes tag :-(

Also, pleas keep all the commit message tags together at the end of the
commit message.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the ftrace tree

[Steven Rostedt]

On Mon, 18 Mar 2024 08:35:35 +1100
Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> Hi all,
> 
> In commit
> 
>   2fd814ad5713 ("ring-buffer: Make wake once of ring_buffer_wait() more robust")
> 
> Fixes tag
> 
>   Fixes: 5b37b7eb98a19 ("ring-buffer: Make wake once of ring_buffer_wait() more robust")
> 
> has these problem(s):
> 
>   - Target SHA1 does not exist
> 
> The Fixes tag seems to be referring to the commit that contains the
> Fixes tag :-(
> 
> Also, pleas keep all the commit message tags together at the end of the
> commit message.
> 

Bah, that looks to me to be a cut and paste error. Anyway, I'm rebasing all
of it as one of the commits was nacked by Linus. :-(

-- Steve

linux-next: Fixes tag needs some work in the ftrace tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 400 bytes --]

Hi all,

In commit

  859dc5e29cae ("rtla/timerlat: Do not set params->user_workload with -U")

Fixes tag

  Fixes: fb9e90a67ee9 ("rtla/timerlat: Make user-space threads

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

Please do not split Fixes tags over more than one line.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the ftrace tree

[Steven Rostedt]

On Tue, 19 Nov 2024 17:40:22 +1100
Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> Hi all,
> 
> In commit
> 
>   859dc5e29cae ("rtla/timerlat: Do not set params->user_workload with -U")
> 
> Fixes tag
> 
>   Fixes: fb9e90a67ee9 ("rtla/timerlat: Make user-space threads
> 
> has these problem(s):
> 
>   - Subject has leading but no trailing parentheses
>   - Subject has leading but no trailing quotes
> 
> Please do not split Fixes tags over more than one line.
> 

Fixed, thanks Stephen!

-- Steve

linux-next: Fixes tag needs some work in the ftrace tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 599 bytes --]

Hi all,

In commit

  6d5934331009 ("tracing: Do not use PERF enums when perf is not defined")

Fixes tag

  Fixes: a1e3ad43115e ("tracing: Ensure module defining synth event cannot be unloaded while tracing")

has these problem(s):

  - Subject does not match target commit subject
    Just use
        git log -1 --format='Fixes: %h ("%s")'

Did you mean

Fixes: a1e3ad43115e ("tracing: Fix synth event printk format for str fields")

or

Fixes: 21581dd4e7ff ("tracing: Ensure module defining synth event cannot be unloaded while tracing")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the ftrace tree

[Steven Rostedt]

On Mon, 24 Mar 2025 13:35:33 +1100
Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> Hi all,
> 
> In commit
> 
>   6d5934331009 ("tracing: Do not use PERF enums when perf is not defined")
> 
> Fixes tag
> 
>   Fixes: a1e3ad43115e ("tracing: Ensure module defining synth event cannot be unloaded while tracing")
> 
> has these problem(s):
> 
>   - Subject does not match target commit subject
>     Just use
>         git log -1 --format='Fixes: %h ("%s")'

I rebased due to a conflict between my topic branches. Good thing too, as
it appears it also caught the fact that I cut and pasted the wrong commit
to fix :-p


> 
> Did you mean
> 
> Fixes: a1e3ad43115e ("tracing: Fix synth event printk format for str fields")
> 
> or
> 
> Fixes: 21581dd4e7ff ("tracing: Ensure module defining synth event cannot be unloaded while tracing")

Thanks,

-- Steve

Re: linux-next: Fixes tag needs some work in the ftrace tree

[Steven Rostedt]

On Mon, 24 Mar 2025 16:28:02 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:

> > 
> >   - Subject does not match target commit subject
> >     Just use
> >         git log -1 --format='Fixes: %h ("%s")'  
> 
> I rebased due to a conflict between my topic branches. Good thing too, as
> it appears it also caught the fact that I cut and pasted the wrong commit
> to fix :-p

I take that back. It indeed fixes the commit mentioned.

-- Steve

> 
> 
> > 
> > Did you mean
> > 
> > Fixes: a1e3ad43115e ("tracing: Fix synth event printk format for str fields")
> > 
> > or
> > 
> > Fixes: 21581dd4e7ff ("tracing: Ensure module defining synth event cannot be unloaded while tracing")  

linux-next: Fixes tag needs some work in the ftrace tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 756 bytes --]

Hi all,

In commit

  f45a0cb29720 ("rtla/tests: Fix osnoise test calling timerlat")

Fixes tag

  Fixes: 05b7e10687c ("tools/rtla: Add remaining support for osnoise actions")

has these problem(s):

  - SHA1 should be at least 12 digits long

In commit

  4b8e202c6fe0 ("rtla/tests: Extend action tests to 5s")

Fixes tags

  Fixes: 4e26f84abfb ("rtla/tests: Add tests for actions")
  Fixes: 05b7e10687c ("tools/rtla: Add remaining support for osnoise actions")

has these problem(s):

  - SHA1 should be at least 12 digits long
    This can be fixed for the future by setting core.abbrev to 12 (or
    more) or (for git v2.11 or later) just making sure it is not set
    (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the ftrace tree

[Tomas Glozar]

pá 21. 11. 2025 v 1:00 odesílatel Stephen Rothwell
<sfr@canb.auug.org.au> napsal:
>
> Hi all,
>
> In commit
>
>   f45a0cb29720 ("rtla/tests: Fix osnoise test calling timerlat")
>
> Fixes tag
>
>   Fixes: 05b7e10687c ("tools/rtla: Add remaining support for osnoise actions")
>
> has these problem(s):
>
>   - SHA1 should be at least 12 digits long
>
>  ...

Oops! Apparently, I forgot to use checkpatch on the patchset:

$ scripts/checkpatch.pl /tmp/test.patch
WARNING: Please use correct Fixes: style 'Fixes: <12+ chars of sha1>
("<title line>")' - ie: 'Fixes: 05b7e10687c6 ("tools/rtla: Add
remaining support for osnoise actions"
)'
#75:
Fixes: 05b7e10687c ("tools/rtla: Add remaining support for osnoise actions")

>     This can be fixed for the future by setting core.abbrev to 12 (or
>     more) or (for git v2.11 or later) just making sure it is not set
>     (or set to "auto").
>

Ah, good to know! My setup is fine, the issue was that I have not used
git log --oneline, but regular git log, and counted the characters by
myself.

Thank you for catching this.

Tomas