public inbox for linux-next@vger.kernel.org
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Takashi Iwai <tiwai@suse.de>
Cc: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: linux-next: Fixes tag needs some work in the sound-current tree
Date: Tue, 2 Apr 2024 07:58:53 +1100	[thread overview]
Message-ID: <20240402075853.4e5a61cf@canb.auug.org.au> (raw)

[-- Attachment #1: Type: text/plain, Size: 758 bytes --]

Hi all,

In commit

  e1d8acf35ce7 ("Revert "ALSA: emu10k1: fix synthesizer sample playback position and caching"")

Fixes tag

  Fixes: df335e9a8b (ALSA: emu10k1: fix synthesizer sample playback position and caching, 2023-05-18)

has these problem(s):

  - SHA1 should be at least 12 digits long
    This can be fixed for the future by setting core.abbrev to 12 (or
    more) or (for git v2.11 or later) just making sure it is not set
    (or set to "auto").
  - Subject does not match target commit subject
    Just use
        git log -1 --format='Fixes: %h ("%s")'

The date field adds nothing.

Thus:

Fixes: df335e9a8bcb ("ALSA: emu10k1: fix synthesizer sample playback position and caching")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

             reply	other threads:[~2024-04-01 20:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-01 20:58 Stephen Rothwell [this message]
2024-04-02  5:56 ` linux-next: Fixes tag needs some work in the sound-current tree Takashi Iwai
  -- strict thread matches above, loose matches on Subject: below --
2024-05-30 23:44 Stephen Rothwell
2024-05-31  7:31 ` Takashi Iwai
2021-06-02  7:09 Stephen Rothwell
2021-06-02  7:13 ` Dongliang Mu
2021-06-02  7:36 ` Takashi Iwai
2021-06-02  7:42   ` Dongliang Mu
2021-06-02  7:47     ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240402075853.4e5a61cf@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=oswald.buddenhagen@gmx.de \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox