From: Andrew Morton <akpm@linux-foundation.org>
To: Jiaqi Yan <jiaqiyan@google.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
linux-doc@vger.kernel.org
Subject: Re: linux-next: build warnings after merge of the mm tree
Date: Mon, 1 Jul 2024 23:18:26 -0700 [thread overview]
Message-ID: <20240701231826.fb3044bb52dc97bedc9853ab@linux-foundation.org> (raw)
In-Reply-To: <CACw3F52wm=5Rg+QP-E7JDOjBvA2mYv0uDBL+8=KPCfQ8tkHQaA@mail.gmail.com>
On Mon, 1 Jul 2024 21:33:20 -0700 Jiaqi Yan <jiaqiyan@google.com> wrote:
> > > This seems a reasonable thing to do so there's probably some way in
> > > which to do it, but a bit of grepping failed to turn up examples in
> > > existing .rst files. Can someone please suggest?
> >
> > It seems I need to add some blank lines according to [1], especially
> > to add a blank line above the first list item:
> >
> > diff --git a/Documentation/admin-guide/sysctl/vm.rst
> > b/Documentation/admin-guide/sysctl/vm.rst
> > index 75e22137d849..74b4c0f65213 100644
> > --- a/Documentation/admin-guide/sysctl/vm.rst
> > +++ b/Documentation/admin-guide/sysctl/vm.rst
> > @@ -274,12 +274,15 @@ Correctable memory errors are very common on
> > servers. Soft-offline is kernel's
> > solution for memory pages having (excessive) corrected memory errors.
> >
> > For different types of page, soft-offline has different behaviors / costs.
> > +
> > - For a raw error page, soft-offline migrates the in-use page's content to
> > a new raw page.
> > +
> > - For a page that is part of a transparent hugepage, soft-offline splits the
> > transparent hugepage into raw pages, then migrates only the raw error page.
> > As a result, user is transparently backed by 1 less hugepage, impacting
> > memory access performance.
> > +
> > - For a page that is part of a HugeTLB hugepage, soft-offline first migrates
> > the entire HugeTLB hugepage, during which a free hugepage will be consumed
> > as migration target. Then the original hugepage is dissolved into raw
> >
> > But I am having trouble testing the build, so wasn't able to validate
> > the change above:
> >
> > Documentation$ make
> > /tools/net/ynl/ynl-gen-rst.py -o
> > /Documentation/networking/netlink_spec/index.rst -x
> > make: /tools/net/ynl/ynl-gen-rst.py: No such file or directory
> > make: *** [Makefile:113:
> > /Documentation/networking/netlink_spec/index.rst] Error 127
You need to install all sorts of whacky system and python packages.
The (failed) build process should guide you through this.
> I tried another way: make htmldocs at repo's root directory. Although
> I wasn't able to finish the make process,
>
> - without the blank lines:
>
> Documentation/admin-guide/sysctl/vm.rst:278: ERROR: Unexpected indentation.
> Documentation/admin-guide/sysctl/vm.rst:279: WARNING: Block quote
> ends without a blank line; unexpected unindent.
>
> - with the blank lines added, the ERROR and WARNING in vm/rst are gone.
>
> Andrew and Stephen, what is the best way to post the fix for this?
> Should I send out a v8 of the patch with the blank lines added? or a
> standalone commit for this fix?
I added your fix, thanks.
next prev parent reply other threads:[~2024-07-02 6:18 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-01 8:49 linux-next: build warnings after merge of the mm tree Stephen Rothwell
2024-07-02 3:14 ` Andrew Morton
2024-07-02 4:15 ` Jiaqi Yan
2024-07-02 4:33 ` Jiaqi Yan
2024-07-02 6:18 ` Andrew Morton [this message]
2024-07-02 6:37 ` Jiaqi Yan
2024-07-02 23:09 ` SeongJae Park
2024-07-02 23:55 ` Jiaqi Yan
-- strict thread matches above, loose matches on Subject: below --
2025-03-05 9:42 Stephen Rothwell
2025-03-05 9:53 ` David Hildenbrand
2025-03-05 10:05 ` David Hildenbrand
2025-02-17 6:10 Stephen Rothwell
2025-02-17 16:28 ` Suren Baghdasaryan
2025-02-10 3:49 Stephen Rothwell
2025-02-09 23:06 Stephen Rothwell
2025-01-06 6:42 Stephen Rothwell
2024-09-11 10:21 Stephen Rothwell
2024-07-01 1:01 Stephen Rothwell
2024-07-01 1:13 ` Andrii Nakryiko
2024-07-01 8:28 ` Stephen Rothwell
2024-03-25 1:36 Stephen Rothwell
2024-03-26 2:19 ` Suren Baghdasaryan
2024-03-26 5:44 ` Randy Dunlap
2024-03-26 6:16 ` Suren Baghdasaryan
2024-03-28 4:39 ` Stephen Rothwell
2024-03-28 4:44 ` Stephen Rothwell
2024-03-28 5:35 ` Suren Baghdasaryan
2024-03-29 22:49 ` Stephen Rothwell
2024-03-29 23:01 ` Suren Baghdasaryan
2024-03-29 23:01 ` Suren Baghdasaryan
2024-02-21 5:27 Stephen Rothwell
2024-02-21 17:12 ` SeongJae Park
2023-07-27 4:28 Stephen Rothwell
2023-07-27 4:46 ` Aneesh Kumar K.V
2023-07-27 5:00 ` Stephen Rothwell
2023-05-08 4:54 Stephen Rothwell
2023-05-08 16:10 ` Liam R. Howlett
2022-11-22 6:50 Stephen Rothwell
2022-08-23 3:54 Stephen Rothwell
2022-08-23 14:55 ` Liam Howlett
2022-05-11 10:20 Stephen Rothwell
2022-05-11 16:06 ` Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240701231826.fb3044bb52dc97bedc9853ab@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=jiaqiyan@google.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox